Bug 1320783

Description of problem:
nova-compute-wait complains about invalid nova host name when domain resource attribute is specified, hostname of node is FQDN and nova host is specified as FQDN.
There is a check in resource agent code:
   NOVA_HOST=$(openstack-config --get /etc/nova/nova.conf DEFAULT host 2>/dev/null)
   if [ $? = 1 ]; then
       if [ "x${OCF_RESKEY_domain}" != x ]; then
	   NOVA_HOST=$(uname -n | awk -F. '{print $1}')
       else
	   NOVA_HOST=$(uname -n)
       fi
   fi

    # We only need to check a configured value, calculated ones are fine
   if [ $? = 0 ]; then
	if [ "x${OCF_RESKEY_domain}" != x ]; then
	    short_host=$(uname -n | awk -F. '{print $1}')
	    if [ "x$NOVA_HOST" != "x${short_host}" ]; then
		ocf_exit_reason "Invalid Nova host name, must be ${short_host} in order for instance recovery to function"
		rc=$OCF_ERR_CONFIGURED
	    fi

	elif [ "x$NOVA_HOST" != "x$(uname -n)" ]; then
            ocf_exit_reason "Invalid Nova host name, must be $(uname -n) in order for instance recovery to function"
	    rc=$OCF_ERR_CONFIGURED
	fi
    fi

This seems to cause following:
1. If Nova host in nova.conf is specified as FQDN, hostname of the node is specified as FQDN and domain attribute of resource agent is specified then nova-compute-wait refuses to start and complains about invalid nova host name.
- If I do not specify domain attribute it would work but I think resource agent should handle that situation or it should be exactly written in the description of resource attribute that If setup uses FQDN then domain attribute should not be specified.
2. The check actually checks the opposite situation from resource description, description of domain attribute says: "domain: DNS domain in which hosts live, useful when the cluster uses short names and nova uses FQDN" but in the reality It checks that when nova does not use FQDN it equals node hostname without domain. If nova host is specified in nova.conf as FQDN and hostname of node is not FQDN, It would fail to start.

I do not really know what the reason of the check is, so I may be wrong somewhere, Initially I understood from the description that host attribute from nova.conf is being compared with the name of host from pacemaker point of view. But from the code it compares it with node hostname.

Version-Release number of selected component (if applicable):
resource-agents-3.9.5-54.el7_2.9

How reproducible:
Always