Bug 132564 - Add back redhat-web.desktop with NoDisplay=true
Summary: Add back redhat-web.desktop with NoDisplay=true
Alias: None
Product: Fedora
Classification: Fedora
Component: htmlview
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jonathan Blandford
QA Contact:
: 136062 (view as bug list)
Depends On:
Blocks: 131589
TreeView+ depends on / blocked
Reported: 2004-09-14 18:59 UTC by Seth Nickell
Modified: 2013-04-02 04:20 UTC (History)
5 users (show)

Clone Of:
Last Closed: 2004-10-19 01:45:14 UTC

Attachments (Terms of Use)
Quick patch (1.63 KB, patch)
2004-09-22 22:24 UTC, Jonathan Blandford
no flags Details | Diff

Description Seth Nickell 2004-09-14 18:59:35 UTC
We should remove all .desktop files from htmlview, never again to
return. It creates duplicate entries for apps, and doesn't really help
anything out.

Comment 1 Mark McLoughlin 2004-09-17 07:53:45 UTC
jrb: don't forget to fix the panel :)

Comment 2 Jonathan Blandford 2004-09-22 22:24:36 UTC
Created attachment 104154 [details]
Quick patch

Comment 3 Mark McLoughlin 2004-09-24 09:05:31 UTC
And when someone changes their preferred browser?

Couldn't we not add back the .desktop file and set NoDisplay=true?

Comment 5 Bryan W Clark 2004-09-24 16:46:00 UTC
Changing the items (either their name or the fact that they display)
that appear in the menu would be a bad thing.  Users obviously may
change their default browser to be Firefox, but that's because they
know the different between the browsers and will be fine with
launching "Firefox Web Browser".

Of course on the flip side, the panel launcher would probably do
better to be an htmlview launcher.  Adding and removing launchers from
the panel isn't the easiest thing right now and I wouldn't want to
expect that people do it when they change their default browser.

Comment 6 Ray Strode [halfline] 2004-09-29 06:55:40 UTC
Note that having htmlview in a desktop file causes difficult problems
because not all browsers are created equal.  For instance the value of
StartupNotify= can't really be hard coded.

If redhat-web is important to have then what I think what we really
need is a htmlview type program that launches desktop files instead of
programs directly.  

I guess this would mean changing the Preferred Applications hard coded
list of browser (name, command) pairs to a list of known desktop
files.  For custom browers, a user specific desktop entry would need
to be written to ~/.local/share/applications like eel does when
changing default applications for mime types.   Then the currently
selected browser's desktop file would be stored in gconf.

Comment 7 Warren Togami 2004-10-13 09:51:57 UTC
Just to clarify, both redhat-web.desktop and redhat-email.desktop to
launch htmlview and launchmail scripts are wanted?  (Yes it does work,
only caveat being the StartupNotify thing, which can be easily worked
around for 99.9% cases.)

Comment 8 Jonathan Blandford 2004-10-13 19:06:50 UTC
Mark convinced me that we should add it back, just for the panel.

Comment 9 Warren Togami 2004-10-15 04:41:21 UTC
Both redhat-web.desktop and redhat-email.desktop to launch each
respective Preferred Application?

Comment 10 Alexander Larsson 2004-10-15 13:18:19 UTC
redhat-web.desktop is the default handler for .html files in gnome. Is
this right? Will this file point to the default web browser?

Comment 11 Seth Nickell 2004-10-15 16:48:34 UTC
I would rather not have this sort of one off hack set as the default
handler...but jrb probably has a better sense here?

Comment 12 Jonathan Blandford 2004-10-15 21:28:58 UTC
After talking with mark, the plan is to add those desktop files back
with NoDisplay=True set.  They will just be used by the panel. 
redhat-web.desktop will launch htmlview, and the redhat-email.desktop
will just be a symlink to evolution.  They won't appear in the menus
at all.

Comment 13 Jonathan Blandford 2004-10-19 01:45:14 UTC

Comment 14 Marco Pesenti Gritti 2004-10-28 11:02:12 UTC
*** Bug 136062 has been marked as a duplicate of this bug. ***

Comment 15 Orion Poplawski 2004-12-01 00:16:18 UTC
Just another comment -  we install our browsers to a shared NFS
directory and have been counting on the htmlview .desktop icons to
launch the default browser.  It's not a big deal for me to modify the
.desktop icons in our kickstart scripts so they appear in the menus
(though perhaps these would be lost if newer versions of the htmlview
rpm are released?).

Anyways, I'm glad you kept the .desktop files.

Note You need to log in before you can comment on or make changes to this bug.