RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1328102 - 'change CD' won't appear when there is a detached ISO domain
Summary: 'change CD' won't appear when there is a detached ISO domain
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libgovirt
Version: 7.2
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: pre-dev-freeze
: ---
Assignee: Christophe Fergeau
QA Contact: Shira Maximov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-18 13:01 UTC by Shira Maximov
Modified: 2016-04-27 15:19 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-27 15:19:54 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
remote viewer debug log (115.52 KB, text/plain)
2016-04-18 13:01 UTC, Shira Maximov
no flags Details

Description Shira Maximov 2016-04-18 13:01:45 UTC
Created attachment 1148206 [details]
remote viewer debug log

Description of problem:
The Foregin menu ('change CD' tab in VM console) will not appear if there is 2 ISO Domain and one of them is detached 

Version-Release number of selected component (if applicable):
Red Hat Enterprise Virtualization Manager Version: 3.6.5.1-0.1.el6
virt-viewer-3.0-1.fc23.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create 2 ISO domains 
2. Detach one of the ISO domain- The foregin menu doesn't appear
3. Remove the not attached ISO domain - the foregin menu appears again

Actual results:


Expected results:


Additional info:

Comment 1 Michal Skrivanek 2016-04-19 06:28:27 UTC
Christophe, I tried to set the most likely component, but please feel free to reassign to a better match

Comment 2 Christophe Fergeau 2016-04-19 10:03:25 UTC
This is probably caused by a libgovirt limitation where it cannot handle multiple resources/collections of a given type with the same name. My guess here would be that the 2 ISO domains are called 'isos', and then libgovirt/virt-viewer only get to see the one which is inactive.
Is it possible to rename ISO domains to confirm this, or do they have to have a hardcoded name?

On the libgovirt side, I think we should add a OvirtCollection::resources_uuid to use the resource uuid as the hash key rather than the resource name (we need to keep OvirtCollection::resources for ovirt_collection_get_resources() as OvirtCollection need to own the returned hash table, and this will be better for performance reasons). Then we can add an ovirt_collection_get_resources_by_uuid() method to return the new hash indexed by uuid, and use this in virt-viewer. This would allow to deal with the situation we have in this bug without breaking libgovirt ABI (which might be cleaner to do at some point though ;)

Comment 3 Shira Maximov 2016-04-19 10:11:32 UTC
(In reply to Christophe Fergeau from comment #2)
The 2 ISO domain have a different name

Comment 4 Christophe Fergeau 2016-04-19 10:23:08 UTC
I'll need libgovirt version, and the output of
'REST_DEBUG=proxy remote-viewer console.vv' in the non-working case.

Comment 5 Shira Maximov 2016-04-19 11:37:59 UTC
The debug is already attached,
The name of the ISO are:
nsimsolo_ISO and netappISO

the libgovirt version: libgovirt-0.3.4-1.fc23.x86_64

Comment 6 Christophe Fergeau 2016-04-19 11:45:24 UTC
(In reply to Shira Maximov from comment #5)
> The debug is already attached,

Oops, sorry, I missed it, thanks for providing it when opening the bug :)

Comment 7 Christophe Fergeau 2016-04-19 12:08:30 UTC
Ok, this would be https://bugzilla.redhat.com/show_bug.cgi?id=1313371
See in the trace
GET /ovirt-engine/api/storagedomains/9d3b50b9-2ec6-42e3-869f-83f2b75e224e/files HTTP/1.1
so it's trying to use netappISO even if it's not attached.

This is fixed upstream by https://git.fedorahosted.org/cgit/virt-viewer.git/commit/?id=0ea2a674b8a7fd51dc1a115c646fe6ff82da3e39 which is not in a release yet (so not in the fedora package either).

However, looking at that code made me realize that remote-viewer is going to use the first active ISO domain for the list of files in the foreign menu. Is it the right thing to do when there are multiple ISO domains? Or should it pick the storage domain it's going to use in a different way?

Comment 8 Michal Skrivanek 2016-04-19 13:33:35 UTC
There can be multiple active in the whole setup. You'd need to match the VM's data center and the ISO domain in that data center. Then there can be only one such ISO domain active.

Comment 9 Christophe Fergeau 2016-04-20 08:39:32 UTC
Shira, if you want to make sure it's the same bug as #1313371, I made a f24 scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13729845

Comment 10 Christophe Fergeau 2016-04-20 08:50:38 UTC
(In reply to Michal Skrivanek from comment #8)
> There can be multiple active in the whole setup. You'd need to match the
> VM's data center and the ISO domain in that data center. Then there can be
> only one such ISO domain active.

Makes sense... Too bad /ovirt-engine/api/vms/$uuid only has a link to the VM cluster and no to the overall datacenter :( This means one more collection to take a look at.

Comment 11 Christophe Fergeau 2016-04-20 08:56:01 UTC
(In reply to Christophe Fergeau from comment #2)
> On the libgovirt side, I think we should add a
> OvirtCollection::resources_uuid to use the resource uuid as the hash key
> rather than the resource name [snip]

I filed https://bugzilla.gnome.org/show_bug.cgi?id=765298 for this.

(In reply to Michal Skrivanek from comment #8)
> There can be multiple active in the whole setup. You'd need to match the
> VM's data center and the ISO domain in that data center. Then there can be
> only one such ISO domain active.

I filed https://bugzilla.gnome.org/show_bug.cgi?id=765297 for that.

I think we can close this bug now.


Note You need to log in before you can comment on or make changes to this bug.