Created attachment 1149201 [details] Screenshot of duplicate mac after after registration fails Description of problem: During the node registration of an OSP deployment, you can input duplicate mac addresses during manual entry. Version-Release number of selected component (if applicable): TP3 RC4 ISO Installer Media Id:1460504089.674944 How reproducible: 100% Steps to Reproduce: 1. Create an OSP deployment 2. Detect undercloud 3. Select Manual Entry for node registration and input host information 4. Enter any mac address 5. Click "Add Another Node" 6. Enter any mac address that was previously entered or registered Actual results: The duplicate mac generates this error "Unable to register node. POST /fusor/api/openstack/deployments/4/nodes failed with status code 500." The duplicate mac address shows up in the node group list with a partial node uuid instead of the mac address. All attempts to delete the bad mac result in it disappearing and reappearing a few seconds later. Expected results: Duplicate mac address would be flagged for duplication as soon as the textbox loses focus (the same way invalid mac addresses are flagged) or when submitted for registration All mac address selected for registration should be checked for duplicates with any registered mac address also
https://github.com/fusor/fusor/pull/784 Manually adding nodes now check for unique mac addresses against all macs from the undercloud port list and for other entered nodes. I will show a warning and disable the register button. Auto-detected nodes now should omit hosts with mac addresses that are already used. CSVs should not allow mac addresses from the undercloud port list. It will also not allow the same mac to be used twice in the same CSV.
QCI-1.0-RHEL-7-20160422.t.0-QCI-x86_64-dvd1.iso
TP3 RC4 Auto-Detection: The fusor and director are removed from the autodetection list. - If you create a 2nd deployment using the same undercloud, the fusor and director are selection options during autodetection. Any nodes that were registered to another deployment are not visible. I would expect that this list would be empty since this is the fusor/director machine and the overcloud nodes are already registered Upload CSV: Duplicate mac address are flagged immediately on upload Manual Entry: - Duplicate macs are now flagged as "Must be unique" for the original and duplicate mac address - If you add a duplicate mac address, have it flagged as "mark as unique", then correct the mac address. All error checking is enabled while you're typing in the mac. -- Step 1: Enter a valid mac address -- Step 2: Enter a duplicate mac address and have it flagged as "Mark as unique" -- Step 3: Erase the duplicate and start entering a new mac -- While you enter a new mac address it will be flagged as "invalid mac address" until you enter a full mac address with 6 octets. This doesn't match the experience when you first enter a new mac address where it's not flagged until the end.
Created attachment 1150551 [details] Autodetection during 2nd deployment with same undercloud - fusor/director detected
Created attachment 1150552 [details] Manual entry doesn't reset error state during correction of duplicate mac
Verified. Creating a new BZ for the auto-detection and manual entry issue