Bug 1329288 - InstallClass imports are broken on F25+
Summary: InstallClass imports are broken on F25+
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-productimg-atomic
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
Assignee: Colin Walters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-21 14:18 UTC by Stephen Gallagher
Modified: 2016-09-22 18:04 UTC (History)
1 user (show)

Fixed In Version: fedora-productimg-atomic-25-1.fc25
Clone Of:
Environment:
Last Closed: 2016-09-22 18:04:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to update atomic product image to match blivet's updated API. (2.32 KB, patch)
2016-04-21 14:27 UTC, David Lehman
no flags Details | Diff

Description Stephen Gallagher 2016-04-21 14:18:19 UTC
Description of problem:
Fedora 25 now has Blivet 2.0, which included a number of API changes to align it with PEP8 standards. This means that a number of the Blivet imports used to set up the default partitioning scheme are broken and the entire InstallClass is skipped. This doesn't break Anaconda (which will continue with its own defaults), but will result in the end-user installation experience not being as expected.

Version-Release number of selected component (if applicable):
fedora-productimg-atomic-23-7.fc24

How reproducible:
Every time

Steps to Reproduce:
1. Boot Atomic installation media from one of the nightly composes of fedora 25/Rawhide 

Actual results:
Default auto-partitioning will follow Anaconda defaults rather than the expected Atomic setup. All of the available disk space will be consumed.

Expected results:
Default auto-partitioning should create a 3GiB / partition and the remaining free space (aside from /boot and SWAP) will be left in a single large volume group).

Additional info:
See also https://bugzilla.redhat.com/show_bug.cgi?id=1329019 for a similar bug in fedora-productimg-server, along with the fix made to address it.

Comment 1 David Lehman 2016-04-21 14:27:34 UTC
Created attachment 1149474 [details]
Patch to update atomic product image to match blivet's updated API.

This is untested but complete AFAICT.

Comment 2 Stephen Gallagher 2016-04-21 19:20:40 UTC
Patch applied and built in Rawhide as fedora-productimg-atomic-25-1.fc25

Comment 3 Jan Kurik 2016-07-26 05:12:09 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 4 Stephen Gallagher 2016-09-22 18:04:07 UTC
This would have been obvious at Alpha Freeze, so I'm going to call it fixed.


Note You need to log in before you can comment on or make changes to this bug.