Bug 1329019 - Server netinst defaults to 'Minimal Install'
Summary: Server netinst defaults to 'Minimal Install'
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-productimg-server
Version: rawhide
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
Assignee: Matthew Miller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-20 23:40 UTC by Adam Williamson
Modified: 2016-07-05 23:52 UTC (History)
7 users (show)

Fixed In Version: fedora-productimg-server-25-1.fc25
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-05 23:52:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2016-04-20 23:40:57 UTC
Current Rawhide server network install image - e.g. https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20160420.n.0/compose/Server/x86_64/iso/Fedora-Server-netinst-x86_64-Rawhide-20160420.n.0.iso - defaults to 'Minimal Install' environment group, not "Fedora Server".

Filing on anaconda for now but this could easily be comps or something, will triage later, just wanted to file for now.

Comment 1 David Shea 2016-04-21 13:27:07 UTC
The default environment is supposed to be set by the installclass, but if you look at anaconda.log you'll notice some lines along the lines of:

WARN anaconda: module import of fedora-server failed: <class 'ImportError'>

because you can't have a hyphen in a module name in python. Can this be renamed to fedora_server.py?

Comment 2 Stephen Gallagher 2016-04-21 13:33:47 UTC
I can fix that, but any idea why it suddenly started happening on Rawhide and is fine on Fedora 23 and 24?

Comment 3 David Shea 2016-04-21 13:43:02 UTC
Oh whoops, never mind on the name. Part of the reason for all the weird import stuff in installclasses.py is to handle names like that.

The reason it stopped working just recently is because blivet-2.0 hit rawhide just recently. The problem is not the name, but the imports.

dshea@spectre:~/fedpkg/fedora-productimg-server$ python3 fedora-server.py 
Traceback (most recent call last):
  File "fedora-server.py", line 10, in <module>
    from blivet.autopart import swapSuggestion
ImportError: cannot import name 'swapSuggestion'

It's swap_suggestion now.

Comment 4 Stephen Gallagher 2016-04-21 14:12:15 UTC
Thanks for the help, David. Updated package is built in Rawhide now that should fix this.

Comment 5 Adam Williamson 2016-04-24 14:28:16 UTC
Well, since that fedora-productimg-server went out, Rawhide Server installs have failed to boot, showing a tmux error:

https://openqa.fedoraproject.org/tests/14221/modules/_boot_to_anaconda/steps/8

all other flavors don't hit that, so I'm gonna say you broke it. :)

Comment 6 Stephen Gallagher 2016-04-25 13:54:08 UTC
(In reply to Adam Williamson from comment #5)
> Well, since that fedora-productimg-server went out, Rawhide Server installs
> have failed to boot, showing a tmux error:
> 
> https://openqa.fedoraproject.org/tests/14221/modules/_boot_to_anaconda/steps/
> 8
> 
> all other flavors don't hit that, so I'm gonna say you broke it. :)

That doesn't make any sense... we pushed the same change to the Atomic installer, so that should have broken too, if this was the problem.

I'll look into it...

Comment 7 Adam Williamson 2016-04-25 18:39:29 UTC
Now you mention it, Atomic does in fact fail the same way:

https://openqa.fedoraproject.org/tests/14367
https://openqa.fedoraproject.org/tests/14367/modules/_boot_to_anaconda/steps/7

but Everything boot and Workstation boot do not.

Comment 8 Stephen Gallagher 2016-04-25 18:48:06 UTC
When I finally got into the VM, I tried running anaconda directly from the terminal (non-X). I got this crash:


Traceback (most recent call last):
  File "/sbin/anaconda", line 1099, in <module>
    setupDisplay(anaconda, opts, addon_paths)
  File "/sbin/anaconda", line 580, in setupDisplay
    anaconda.initInterface(addons)
  File "/usr/lib64/python3.5/site-packages/pyanaconda/anaconda.py", line 240, in initInterface
    self._intf = TextUserInterface(self.storage, self.payload,
  File "/usr/lib64/python3.5/site-packages/pyanaconda/anaconda.py", line 176, in storage
    self._storage.setDefaultFSType(self.instClass.defaultFS)
AttributeError: 'Blivet' object has no attribute 'setDefaultFSType'



Looks like something was missed when converting to Blivet 2.0.

Comment 9 Stephen Gallagher 2016-04-25 19:15:12 UTC
(In reply to Stephen Gallagher from comment #8)
> When I finally got into the VM, I tried running anaconda directly from the
> terminal (non-X). I got this crash:
> 
> 
> Traceback (most recent call last):
>   File "/sbin/anaconda", line 1099, in <module>
>     setupDisplay(anaconda, opts, addon_paths)
>   File "/sbin/anaconda", line 580, in setupDisplay
>     anaconda.initInterface(addons)
>   File "/usr/lib64/python3.5/site-packages/pyanaconda/anaconda.py", line
> 240, in initInterface
>     self._intf = TextUserInterface(self.storage, self.payload,
>   File "/usr/lib64/python3.5/site-packages/pyanaconda/anaconda.py", line
> 176, in storage
>     self._storage.setDefaultFSType(self.instClass.defaultFS)
> AttributeError: 'Blivet' object has no attribute 'setDefaultFSType'
> 
> 
> 
> Looks like something was missed when converting to Blivet 2.0.

After talking with David Lehman, we realized that this was *indirectly* caused by fedora-productimg-server; We do set a defaultFS that differs from upstream, so this code-path is executed and it was missed in the Blivet 2.0 conversion.

Reassigning to anaconda to sort out.

I'm not sure what's going on with Atomic, since it doesn't follow this code-path. Please open a separate bug to track that one.

Comment 10 Adam Williamson 2016-04-25 19:26:37 UTC
At this point we probably ought to create a new bug, since this is nothing at all to do with the original bug here. I'll close this and open a new one. Leaving this as ON_QA so we can test the fix for the *original* problem once the new problem is fixed.

Comment 11 Radek Vykydal 2016-04-26 10:19:58 UTC
For Atomic (rawhide), https://github.com/projectatomic/fedora-productimg-atomic should be updated for Blivet 2.0. I think.

Comment 12 Stephen Gallagher 2016-04-26 12:08:47 UTC
(In reply to Radek Vykydal from comment #11)
> For Atomic (rawhide),
> https://github.com/projectatomic/fedora-productimg-atomic should be updated
> for Blivet 2.0. I think.

I already built http://koji.fedoraproject.org/koji/buildinfo?buildID=756654 for fedora-productimg-atomic. This was tracked in BZ #1329288

Comment 13 Adam Williamson 2016-04-26 15:45:12 UTC
For the record the Atomic problem here is one we already knew about, https://bugzilla.redhat.com/show_bug.cgi?id=1327460 . The factor that briefly confused us is that "tmux.conf:20: no current client" seems to be the new "pane is dead" for tmux 2.2 - we now we see that message instead of "pane is dead" when anaconda crashes early. But there were two completely different *causes* of the early crashes. So now we have this bug for the blivet port bug that Server hits, we have 1327460 for the Atomic bug, and I also filed https://bugzilla.redhat.com/show_bug.cgi?id=1330300 for the fact that with tmux 2.2, we don't see the anaconda crash output on the screen as we did before.

Comment 14 Adam Williamson 2016-07-05 23:52:45 UTC
the original problem here is long fixed.


Note You need to log in before you can comment on or make changes to this bug.