Spec URL: https://jjames.fedorapeople.org/metamath/metamath.spec SRPM URL: https://jjames.fedorapeople.org/metamath/metamath-0.125-1.fc25.src.rpm Fedora Account System Username: jjames Description: Metamath is a tiny language that can express theorems in abstract mathematics, accompanied by proofs that can be verified by a computer program. Metamath lets you see mathematics developed in complete detail from first principles, with absolute rigor.
Note: I am not (yet) a packager so this should be considered an informal review/comment rpmlint output: metamath.x86_64: E: incorrect-fsf-address /usr/share/licenses/metamath/LICENSE.TXT metamath.x86_64: W: no-manual-page-for-binary metamath metamath-theories.noarch: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 2 warnings. Sections from fedora-review output that probably need dealing with: [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/metamath
Thanks for informal review, Michael. I have fixed the unowned directory problem, and also added the manual. Since the PDF is nearly 1 MB in size, I have given it its own subpackage. This also raises a bit of a license hassle. There is no %license file in the -doc subpackage, because the LICENSE.TXT file describes GPLv2, which applies to the binary and one of the theories. At the top of the LaTeX source for the manual is a notice that the file is covered by CC0; i.e., public domain in effect. There is no file describing CC0, probably since it has a very short description, and I see no point in including the GPLv2 LICENSE.TXT in this subpackage. New URLs: Spec URL: https://jjames.fedorapeople.org/metamath/metamath.spec SRPM URL: https://jjames.fedorapeople.org/metamath/metamath-0.125-2.fc25.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/sagitter/1333962-metamath/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Please update to newest release. - doc sub-package does not provide an own license file - /usr/share/doc/metamath is not owned ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 32 files have unknown license. Detailed output of licensecheck in /home/sagitter/1333962-metamath/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/metamath [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in metamath-theories , metamath-doc , metamath-debuginfo [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: metamath-0.125-2.fc25.x86_64.rpm metamath-theories-0.125-2.fc25.noarch.rpm metamath-doc-0.125-2.fc25.noarch.rpm metamath-debuginfo-0.125-2.fc25.x86_64.rpm metamath-0.125-2.fc25.src.rpm metamath.x86_64: E: incorrect-fsf-address /usr/share/licenses/metamath/LICENSE.TXT metamath.x86_64: W: no-manual-page-for-binary metamath metamath-theories.noarch: W: no-documentation metamath-doc.noarch: W: spelling-error %description -l en_US verifiers -> verifies, versifiers, versifier metamath-doc.noarch: W: spelling-error %description -l en_US provers -> proves, rovers, proverbs metamath.src: W: file-size-mismatch metamath.tex = 640062, http://us.metamath.org/latex/metamath.tex = 640154 metamath.src: W: file-size-mismatch metamath.tar.bz2 = 9245528, http://us.metamath.org/downloads/metamath.tar.bz2 = 9429437 5 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: metamath-debuginfo-0.125-2.fc25.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory metamath-doc.noarch: W: spelling-error %description -l en_US verifiers -> verifies, versifiers, versifier metamath-doc.noarch: W: spelling-error %description -l en_US provers -> proves, rovers, proverbs metamath-theories.noarch: W: no-documentation metamath.x86_64: E: incorrect-fsf-address /usr/share/licenses/metamath/LICENSE.TXT metamath.x86_64: W: no-manual-page-for-binary metamath 4 packages and 0 specfiles checked; 1 errors, 4 warnings. Requires -------- metamath-doc (rpmlib, GLIBC filtered): metamath-theories (rpmlib, GLIBC filtered): metamath metamath (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) metamath-debuginfo (rpmlib, GLIBC filtered): Provides -------- metamath-doc: metamath-doc metamath-theories: metamath-theories metamath: metamath metamath(x86-64) metamath-debuginfo: metamath-debuginfo metamath-debuginfo(x86-64) Source checksums ---------------- http://us.metamath.org/downloads/metamath.tar.bz2 : CHECKSUM(SHA256) this package : e34565740e7a4cad5c34424d1234b4f3bb548f961d388a2c3421a20f935022e9 CHECKSUM(SHA256) upstream package : e96d17cdc8c68a815e5956780d2b95ff3ee4927b4c7b8f3c7dd3b21aa4fdd47f http://us.metamath.org/latex/metamath.tex : CHECKSUM(SHA256) this package : 81e0f69aa53579a64f857462b1effdf8d03cf8e663f7274c088400232179d5b7 CHECKSUM(SHA256) upstream package : 2abb091ff0395a28eb091fb7dbd87100756dd2980658d7ccd7db5d5e7690d0a3 diff -r also reports differences Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1333962 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks for the review, Antonio. I have fixed the issues you identified. New URLs: Spec URL: https://jjames.fedorapeople.org/metamath/metamath.spec SRPM URL: https://jjames.fedorapeople.org/metamath/metamath-0.131-1.fc25.src.rpm
- Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 32 files have unknown license. Detailed output of licensecheck in /home/sagitter/1333962-metamath/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in metamath-theories , metamath-doc , metamath-debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: metamath-0.131-1.fc25.x86_64.rpm metamath-theories-0.131-1.fc25.noarch.rpm metamath-doc-0.131-1.fc25.noarch.rpm metamath-debuginfo-0.131-1.fc25.x86_64.rpm metamath-0.131-1.fc25.src.rpm metamath.x86_64: E: incorrect-fsf-address /usr/share/licenses/metamath/LICENSE.TXT metamath.x86_64: W: no-manual-page-for-binary metamath metamath-theories.noarch: W: no-documentation metamath-doc.noarch: W: spelling-error %description -l en_US verifiers -> verifies, versifiers, versifier metamath-doc.noarch: W: spelling-error %description -l en_US provers -> proves, rovers, proverbs metamath-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/metamath-doc/LICENSE.TXT 5 packages and 0 specfiles checked; 2 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: metamath-debuginfo-0.131-1.fc25.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- metamath-doc.noarch: W: spelling-error %description -l en_US verifiers -> verifies, versifiers, versifier metamath-doc.noarch: W: spelling-error %description -l en_US provers -> proves, rovers, proverbs metamath-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/metamath-doc/LICENSE.TXT metamath-theories.noarch: W: no-documentation metamath.x86_64: E: incorrect-fsf-address /usr/share/licenses/metamath/LICENSE.TXT metamath.x86_64: W: no-manual-page-for-binary metamath 4 packages and 0 specfiles checked; 2 errors, 4 warnings. Requires -------- metamath-doc (rpmlib, GLIBC filtered): metamath-theories (rpmlib, GLIBC filtered): metamath metamath (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) metamath-debuginfo (rpmlib, GLIBC filtered): Provides -------- metamath-doc: metamath-doc metamath-theories: metamath-theories metamath: metamath metamath(x86-64) metamath-debuginfo: metamath-debuginfo metamath-debuginfo(x86-64) Source checksums ---------------- http://us.metamath.org/downloads/metamath.tar.bz2 : CHECKSUM(SHA256) this package : 99d8ee5d9b12aad581df695091086a774fb6975e8e227e379c9795f860672a25 CHECKSUM(SHA256) upstream package : 99d8ee5d9b12aad581df695091086a774fb6975e8e227e379c9795f860672a25 http://us.metamath.org/latex/metamath.tex : CHECKSUM(SHA256) this package : 2abb091ff0395a28eb091fb7dbd87100756dd2980658d7ccd7db5d5e7690d0a3 CHECKSUM(SHA256) upstream package : 2abb091ff0395a28eb091fb7dbd87100756dd2980658d7ccd7db5d5e7690d0a3 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1333962 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Can you take a look to 'giac' please? https://bugzilla.redhat.com/show_bug.cgi?id=1335988
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/metamath
metamath-0.131-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0ce9b85399
metamath-0.131-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0ce9b85399
metamath-0.131-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.