Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1336328

Summary:	[FEAT] jbr: Improve code modularity
Product:	[Community] GlusterFS	Reporter:	Avra Sengupta <asengupt>
Component:	replicate	Assignee:	Avra Sengupta <asengupt>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-27 18:25:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1158654

Description Avra Sengupta 2016-05-16 08:04:16 UTC

Description of problem:
Make code more modular to leverage more of the code generation framework

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-05-16 09:14:28 UTC

REVIEW: http://review.gluster.org/14355 (jbr: Making fop functions more modular to reuse more code) posted (#1) for review on master by Avra Sengupta (asengupt)

Comment 2 Vijay Bellur 2016-05-16 10:11:46 UTC

REVIEW: http://review.gluster.org/14355 (jbr: Making fop functions more modular to reuse more code) posted (#2) for review on master by Avra Sengupta (asengupt)

Comment 3 Vijay Bellur 2016-05-18 06:36:24 UTC

REVIEW: http://review.gluster.org/14355 (jbr: Making fop functions more modular to reuse more code) posted (#3) for review on master by Avra Sengupta (asengupt)

Comment 4 Vijay Bellur 2016-05-18 12:12:44 UTC

REVIEW: http://review.gluster.org/14355 (jbr: Making fop functions more modular to reuse more code) posted (#4) for review on master by Avra Sengupta (asengupt)

Comment 5 Vijay Bellur 2016-05-18 12:35:29 UTC

REVIEW: http://review.gluster.org/14355 (jbr: Making fop functions more modular to reuse more code) posted (#5) for review on master by Avra Sengupta (asengupt)

Comment 6 Vijay Bellur 2016-05-25 09:51:51 UTC

REVIEW: http://review.gluster.org/14355 (jbr: Making fop functions more modular to reuse more code) posted (#6) for review on master by Avra Sengupta (asengupt)

Comment 7 Vijay Bellur 2016-05-25 18:52:48 UTC

COMMIT: http://review.gluster.org/14355 committed in master by Jeff Darcy (jdarcy) 
------
commit f8f16595d8dd8c8a869630bb77b7fd1b42b97e08
Author: Avra Sengupta <asengupt>
Date:   Tue May 10 12:13:18 2016 +0530

    jbr: Making fop functions more modular to reuse more code
    
    Putting bigger chunks of re-usable code like leader checks
    and init into functions thereby reducing the size of the
    'fop' call.
    
    Introduced 'perform_local_op' in the 'fop' call, where
    regular functions as of now just call dispatch, but fops
    like 'lk' can do their fop specific operations.
    
    Introduced selective_generate to allow certain functions
    for a particular fop to be generated. The rest of the
    functions can be customised and added in jbr.c
    
    Change-Id: I3754ed68983e763329e14a2faef911428e36e4f0
    BUG: 1336328
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/14355
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 8 Shyamsundar 2017-03-27 18:25:08 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/