Bug 1337323 - "NewListTag": Expandable/Tree-structures interact *badly* with filtering/select-all
Summary: "NewListTag": Expandable/Tree-structures interact *badly* with filtering/sele...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Spacewalk
Classification: Community
Component: WebUI
Version: 2.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michael Mráka
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-18 20:11 UTC by Grant Gainey
Modified: 2019-10-21 13:12 UTC (History)
0 users

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-21 13:12:12 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1291031 0 high CLOSED "Select All" button on Satellite 5.7 Web UI ignores filters and selects all packages 2021-02-22 00:41:40 UTC

Internal Links: 1291031

Description Grant Gainey 2016-05-18 20:11:20 UTC
Bugzilla 1291031 (q.v.) describes how the behavior of the SelectAll button, when viewing a filtered-list, violates the concept of "least user astonishment". For that BZ, the behavior was changed to make more sense - but only for the NewListTag-controlled pages.

In the process of addressing that issue, uncovered an issue with the NewListTag: the existing support for filtering-on-parent and filtering-on-child was broken, was only taken advantage of on the DuplicateIP/IPv6/HostName/MACAddress pages, was only marginally 'working' there, and only as a result of some suboptimal code in a variety of places.

The behavior on those pages interacts with filtering better now. Other behavior of those pages is no worse than it was before. However, the behavior of the NewListTag in the face of the Expandable interface and tree-structures, is fragile and occasionally user-surprising. 

This BZ is a placeholder to remind us to go back and clean the tag up. It needs to handle being able to filter-parent, filter-child, and their interactions with select-all, unselect-all, and filtering.

See Expandable, DuplicateSystemsAction, ListFilterHelper, BaseSetHelper, and DataSetManipulator for a start on where we need to do more refactoring to restore sanity.

Comment 1 Michael Mráka 2019-10-21 13:12:12 UTC
Spacewalk 2.8 (and older) has already reached it's End Of Life.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before end of life. If you would still like
to see this bug fixed and are able to reproduce it against current version
of Spacewalk 2.9, you are encouraged change the 'version' and re-open it.


Note You need to log in before you can comment on or make changes to this bug.