Bug 1338545 - Add AlertOnNumberOfLVs to engine-config.sh
Summary: Add AlertOnNumberOfLVs to engine-config.sh
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Tools.Config
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ovirt-4.0.0-rc
: 4.0.0
Assignee: Allon Mureinik
QA Contact: Carlos Mestre González
Depends On:
TreeView+ depends on / blocked
Reported: 2016-05-22 16:46 UTC by Allon Mureinik
Modified: 2016-07-05 08:01 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2016-07-05 08:01:58 UTC
oVirt Team: Storage
rule-engine: ovirt-4.0.0+
rule-engine: planning_ack+
amureini: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
oVirt gerrit 57852 0 master MERGED tools: Add AlertOnNumberOfLVs to engine-config 2016-05-23 04:14:36 UTC

Description Allon Mureinik 2016-05-22 16:46:04 UTC
Description of problem:
AlertOnNumberOfLVs is the config value that controls how many LVs are allowed in a block storage domain before the user gets warned about it.
As stated in https://bugzilla.redhat.com/show_bug.cgi?id=1275182#c14:

we should [have this config value in engine-config] since for some storage we can have more and for some less. It's also a matter of how conservative the customer is. Users would like to change this.

This bz is to track adding the option to configure it via the tool.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. On the engine machine, run ${OVIRT_HOME}/share/ovirt-engine/bin/engine-config.sh -g AlertOnNumberOfLVs

Actual results:
Error fetching AlertOnNumberOfLVs value: no such entry. Please verify key name and property file support.

Expected results:
Value of the config value is displayed.

[similartly, setting it should be possible via the -s flag]

Comment 1 Natalie Gavrielov 2016-06-07 16:54:27 UTC

This issue only takes care of displaying the value?
What about the option of setting it to a different value?

Comment 2 Allon Mureinik 2016-06-08 13:06:19 UTC
Yup, indeed - any value that can be queried by engine-config can also be updated, by using the -s flag:

${OVIRT_HOME}/share/ovirt-engine/bin/engine-config.sh -s AlertOnNumberOfLVs=<some number>

The legal values are integers of 6 and above (due to the special LVs we create on the domain)

Comment 3 Carlos Mestre González 2016-06-17 14:44:49 UTC
#engine-config  -g AlertOnNumberOfLVs
AlertOnNumberOfLVs: 300 version: general
# engine-config  -s AlertOnNumberOfLVs=5
Cannot set value 5 to key AlertOnNumberOfLVs. 
# engine-config  -s AlertOnNumberOfLVs=6
# engine-config  -g AlertOnNumberOfLVs
AlertOnNumberOfLVs: 6 version: general
engine=> SELECT * from vdc_options WHERE option_name = 'AlertOnNumberOfLVs';
 option_id |    option_name     | option_value | version 
       375 | AlertOnNumberOfLVs | 6            | general
(1 row)

(also tested negative: char, float, negative...)


Comment 4 Sandro Bonazzola 2016-07-05 08:01:58 UTC
oVirt 4.0.0 has been released, closing current release.

Note You need to log in before you can comment on or make changes to this bug.