Bug 1340587 - fwupd holds usbfs filedescriptors open, preventing device suspend and draining battery.
Summary: fwupd holds usbfs filedescriptors open, preventing device suspend and drainin...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: fwupd
Version: 25
Hardware: All
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-28 02:08 UTC by Oleg Drokin
Modified: 2017-12-12 10:42 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-12 10:42:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Oleg Drokin 2016-05-28 02:08:45 UTC
Description of problem:

I noticed that my laptop draws only 700-800 mW of power right after start in idle (screen off). But as soon as I login into Gnome, the power draw increases to 1.1W at the lowest, so +300-400mW power draw out of nowhere.
Powertop helpfully identified my bt device (intel btusb usb-device-8087-0a2a), though it was not immediately clear why.
After some painstaking debugging I finally tracked it to fsupd holding usbfs descriptor open all the time and usbdevfs prevents the device from suspending while device file is open (not unreasonably).

[root@gnome ~]# ps ax | grep fwup
 3051 ?        Sl     0:00 /usr/libexec/fwupd/fwupd
 3168 pts/0    S+     0:00 grep --color=auto fwup
[root@gnome ~]# ls -la /proc/3051/fd | grep usb
lrwx------. 1 root root 64 May 27 21:58 21 -> /dev/bus/usb/001/004


the daemon appears not to be started via systemctl either since systemctl sees it as not started and killing it cannot be done with systemctl either as the result.
[root@gnome ~]# systemctl status -l fwupd
* fwupd.service - Firmware update daemon
   Loaded: loaded (/usr/lib/systemd/system/fwupd.service; static; vendor preset
   Active: inactive (dead)

It's totally unclear why such a file descriptor needs to be held, perhaps a leak?
Killing fwupd stops the power draw as expected.


With such a file descriptor being held in place, I wonder if it also interferes with other device operations like some reports I found e.g. bug 1277837 where a mouse stopped working due to fwupd.

Comment 1 Richard Hughes 2016-06-28 07:45:48 UTC
Is this still happening with fwupd 0.7.2 out of interest? Thanks.

Comment 2 Oleg Drokin 2016-06-28 17:39:52 UTC
Is there an rpm of 0.7.2 I can use somewhere? even rawhide is still on 0.7.1

I cannot build it myself because it pulls in too many dependencies for my measly tablet.

I see in the changelog there's some patch about closing audio usb devices, so hopefully it works for other usb devices too.

Comment 3 Oleg Drokin 2016-06-30 17:39:26 UTC
I tried 0.7.2 from today's rawhide and it does not help, the problem is still there:

[root@gnome ~]# service fwupd start
Redirecting to /bin/systemctl start  fwupd.service
[root@gnome ~]# ps ax | grep fwupd
 1793 ?        Ssl    0:00 /usr/libexec/fwupd/fwupd
 1808 pts/0    S+     0:00 grep --color=auto fwupd
[root@gnome ~]# ls -al /proc/1793/fd
total 0
dr-x------. 2 root root  0 Jun 30 13:37 .
dr-xr-xr-x. 9 root root  0 Jun 30 13:37 ..
lr-x------. 1 root root 64 Jun 30 13:37 0 -> /dev/null
lrwx------. 1 root root 64 Jun 30 13:37 1 -> 'socket:[31431]'
lr-x------. 1 root root 64 Jun 30 13:37 10 -> 'pipe:[31468]'
l-wx------. 1 root root 64 Jun 30 13:37 11 -> 'pipe:[31468]'
lrwx------. 1 root root 64 Jun 30 13:37 12 -> 'anon_inode:[timerfd]'
lr-x------. 1 root root 64 Jun 30 13:37 13 -> 'pipe:[31469]'
l-wx------. 1 root root 64 Jun 30 13:37 14 -> 'pipe:[31469]'
lrwx------. 1 root root 64 Jun 30 13:37 15 -> 'anon_inode:[timerfd]'
lr-x------. 1 root root 64 Jun 30 13:37 16 -> 'pipe:[31470]'
l-wx------. 1 root root 64 Jun 30 13:37 17 -> 'pipe:[31470]'
lrwx------. 1 root root 64 Jun 30 13:37 18 -> 'anon_inode:[timerfd]'
lrwx------. 1 root root 64 Jun 30 13:37 19 -> 'socket:[31471]'
lrwx------. 1 root root 64 Jun 30 13:37 2 -> 'socket:[31431]'
lrwx------. 1 root root 64 Jun 30 13:37 20 -> 'anon_inode:[eventfd]'
lrwx------. 1 root root 64 Jun 30 13:37 21 -> /dev/bus/usb/001/004
lrwx------. 1 root root 64 Jun 30 13:37 3 -> 'anon_inode:[eventfd]'
lrwx------. 1 root root 64 Jun 30 13:37 4 -> 'socket:[31465]'
lr-x------. 1 root root 64 Jun 30 13:37 5 -> anon_inode:inotify
lrwx------. 1 root root 64 Jun 30 13:37 6 -> 'anon_inode:[eventfd]'
lrwx------. 1 root root 64 Jun 30 13:37 7 -> 'socket:[31466]'
lr-x------. 1 root root 64 Jun 30 13:37 8 -> 'pipe:[31467]'
l-wx------. 1 root root 64 Jun 30 13:37 9 -> 'pipe:[31467]'
[root@gnome ~]# rpm -qf /usr/libexec/fwupd/fwupd
fwupd-0.7.2-1.fc25.x86_64

Comment 4 Oleg Drokin 2016-12-20 16:44:35 UTC
The problem is still there in Fedora 25 with fwupd-0.7.5-1.fc25.x86_64

Comment 5 Peter Jones 2017-01-06 17:15:29 UTC
I'm seeing this in f25 on the XPS-13 9350 as well:

[root@trillian ~]# ps ax | grep fwupd
 1949 ?        Sl     0:02 /usr/libexec/fwupd/fwupd
29704 pts/2    S+     0:00 grep --color=auto fwupd
[root@trillian ~]# ls -l /proc/1949/fd/ | grep usb/
lrwx------. 1 root root 64 Jan  6 09:17 30 -> /dev/bus/usb/001/002

In this case the device is the bluetooth transceiver (btusb) rather than the mouse, but the result is the same.

Comment 6 Oleg Drokin 2017-06-16 16:48:40 UTC
I was just looking into this and it appears that this bug is now gone, at least I no longer see the usbfs descriptor hanging in fwupd on fedora26.
fwupd-0.9.3-1.fc26.x86_64

Comment 7 Fedora End Of Life 2017-11-16 18:42:28 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 8 Fedora End Of Life 2017-12-12 10:42:25 UTC
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.