Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1341952

Summary:	changelog: changelog_rollover breaks when number of fds opened is more than 1024
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	changelog	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.7.11	CC:	bugs, rabhat
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.12	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1334314
Clones:	1342083 (view as bug list)		Environment:
Last Closed:	2016-06-28 12:19:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1334314
Bug Blocks:	1342083

Description Kotresh HR 2016-06-02 06:38:19 UTC

+++ This bug was initially created as a clone of Bug #1334314 +++

Description of problem:
Changelog_rollover breaks when number of fds opened is more than 1024

This is because, 'select' is being used to wait on fd. This is known limitation
with select. Hence replace select with poll or some other mechanism.


Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Steps to Reproduce:
1. Open >1024 files and then enable changelog


Actual results:
changelog_rollover fails

Expected results:
changelog rollover should not fail

Comment 1 Vijay Bellur 2016-06-02 12:27:34 UTC

REVIEW: http://review.gluster.org/14615 (features/changelog: Change barrier notification mechanism) posted (#1) for review on release-3.7 by Kotresh HR (khiremat)

Comment 2 Vijay Bellur 2016-06-16 16:03:19 UTC

COMMIT: http://review.gluster.org/14615 committed in release-3.7 by Jeff Darcy (jdarcy) 
------
commit 650459c4178eff6fba82351d044c995ab7d046b1
Author: Kotresh HR <khiremat>
Date:   Mon May 9 16:54:00 2016 +0530

    features/changelog: Change barrier notification mechanism
    
    Backport of http://review.gluster.org/14272
    
    The barrier notification mechanism was fd based and 'select'
    was being used. 'select' breaks when number of fds opened
    by brick process exceeds 1024. To avoid this and also
    the maintainance of pipe between notify and 'changelog_rollover',
    the pipe has been replaced with pthread condition signal
    and timed wait mechanism.
    
    Change-Id: I530ea90d9a06953f8b23b4e12d122872ee1925de
    BUG: 1341952
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/14615
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 3 Kaushal 2016-06-28 12:19:23 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report.

glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user