+++ This bug was initially created as a clone of Bug #1341952 +++ +++ This bug was initially created as a clone of Bug #1334314 +++ Description of problem: Changelog_rollover breaks when number of fds opened is more than 1024 This is because, 'select' is being used to wait on fd. This is known limitation with select. Hence replace select with poll or some other mechanism. Version-Release number of selected component (if applicable): mainline How reproducible: always Steps to Reproduce: 1. Open >1024 files and then enable changelog Actual results: changelog_rollover fails Expected results: changelog rollover should not fail
REVIEW: http://review.gluster.org/14614 (features/changelog: Change barrier notification mechanism) posted (#1) for review on release-3.8 by Kotresh HR (khiremat)
REVIEW: http://review.gluster.org/14614 (features/changelog: Change barrier notification mechanism) posted (#2) for review on release-3.8 by Kotresh HR (khiremat)
COMMIT: http://review.gluster.org/14614 committed in release-3.8 by Niels de Vos (ndevos) ------ commit faaee8c7cee1c3d8fcdcf7fcd3b27feba943f76f Author: Kotresh HR <khiremat> Date: Mon May 9 16:54:00 2016 +0530 features/changelog: Change barrier notification mechanism Backport of http://review.gluster.org/#/c/14272/ The barrier notification mechanism was fd based and 'select' was being used. 'select' breaks when number of fds opened by brick process exceeds 1024. To avoid this and also the maintainance of pipe between notify and 'changelog_rollover', the pipe has been replaced with pthread condition signal and timed wait mechanism. > Change-Id: I530ea90d9a06953f8b23b4e12d122872ee1925de > BUG: 1334314 > Signed-off-by: Kotresh HR <khiremat> > Reviewed-on: http://review.gluster.org/14272 (cherry picked from commit be00012e7be55d25870411f3e975db9a8e19c70a) Change-Id: I530ea90d9a06953f8b23b4e12d122872ee1925de BUG: 1342083 Signed-off-by: Kotresh HR <khiremat> Reviewed-on: http://review.gluster.org/14614 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> Smoke: Gluster Build System <jenkins.com>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user