Bug 1342217 - Monitoring button in EC2 cloud provider summary should be disabled
Summary: Monitoring button in EC2 cloud provider summary should be disabled
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: GA
: 5.7.0
Assignee: Harpreet Kataria
QA Contact: Nandini Chandra
URL:
Whiteboard: ui:ec2
: 1342258 (view as bug list)
Depends On:
Blocks: 1353235
TreeView+ depends on / blocked
 
Reported: 2016-06-02 16:56 UTC by Matouš Mojžíš
Modified: 2017-01-12 05:15 UTC (History)
8 users (show)

Fixed In Version: 5.7.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1353235 (view as bug list)
Environment:
Last Closed: 2017-01-11 20:13:29 UTC
Category: ---
Cloudforms Team: AWS
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Matouš Mojžíš 2016-06-02 16:56:14 UTC
Description of problem:
Monitoring select button for ec2 cloud provider doesn't list any subbuttons, so I think it should be gray and disabled.

Version-Release number of selected component (if applicable):
5.6.0.9

How reproducible:
Always

Steps to Reproduce:
1. Add ec2 cloud provider
2. Go to ec2 cloud provider summary page
3.

Actual results:
I can click on monitoring select button, but it has no subbuttons, because timelines on ec2 are disabled.

Expected results:
Select button should be gray and unclickable.

Additional info:

Comment 2 Matouš Mojžíš 2016-06-02 19:35:53 UTC
*** Bug 1342258 has been marked as a duplicate of this bug. ***

Comment 4 CFME Bot 2016-06-15 21:45:56 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/d49a91bff7149af08d3202e7830887d025569dba

commit d49a91bff7149af08d3202e7830887d025569dba
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jun 2 15:35:20 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Jun 13 14:50:00 2016 -0400

    Disable timelines button when no timeline data is available for provider
    
    - Also hide Monitoring button group when there are no buttons under it.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1342224
    https://bugzilla.redhat.com/show_bug.cgi?id=1342217

 .../application_helper/button/ems_cloud_timeline.rb       |  5 -----
 .../application_helper/button/ems_infra_timeline.rb       |  5 -----
 app/helpers/application_helper/button/ems_timeline.rb     | 15 +++++++++++++++
 .../application_helper/toolbar/ems_cloud_center.rb        |  2 +-
 .../application_helper/toolbar/ems_infra_center.rb        |  2 +-
 5 files changed, 17 insertions(+), 12 deletions(-)
 delete mode 100644 app/helpers/application_helper/button/ems_cloud_timeline.rb
 delete mode 100644 app/helpers/application_helper/button/ems_infra_timeline.rb
 create mode 100644 app/helpers/application_helper/button/ems_timeline.rb

Comment 5 CFME Bot 2016-06-15 21:46:03 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/db708d9ca35bb67a90a259cc3312e1467fb3aca2

commit db708d9ca35bb67a90a259cc3312e1467fb3aca2
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jun 2 16:56:49 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Jun 13 14:59:59 2016 -0400

    Added spec tests to verify fix.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1342224
    https://bugzilla.redhat.com/show_bug.cgi?id=1342217

 .../application_helper/buttons/ems_timeline.rb     | 39 ++++++++++++++++++++++
 .../application_helper/toolbar_builder_spec.rb     | 15 +++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 spec/helpers/application_helper/buttons/ems_timeline.rb

Comment 8 Nandini Chandra 2016-09-30 15:33:03 UTC
Verified in 5.7.0.1


Note You need to log in before you can comment on or make changes to this bug.