Bug 1342275 - [PATCH] Small typo fixes
Summary: [PATCH] Small typo fixes
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: cli
Version: 3.8.0
Hardware: All
OS: All
low
low
Target Milestone: ---
Assignee: Dustin Black
QA Contact:
URL:
Whiteboard:
Depends On: 1005257
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-02 20:40 UTC by Dustin Black
Modified: 2016-06-16 12:33 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.8.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1005257
Environment:
Last Closed: 2016-06-16 12:33:09 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Dustin Black 2016-06-02 20:40:13 UTC
+++ This bug was initially created as a clone of Bug #1005257 +++

Small typo fixes, patch is straight forward and should apply easily.

Cheers,
James

--- Additional comment from Jiffin on 2015-12-01 07:21:38 EST ---

Can you send the attached patch to upstream, If the issue is still exists.

--- Additional comment from Dustin Black on 2016-06-02 16:13:54 EDT ---

Checked against current mainline, and all of these typos appear to be corrected.

However, I uncovered one more in the process.

--- a/xlators/nfs/server/src/nfs.c      2016-06-02 16:09:14.944255997 -0400
+++ b/xlators/nfs/server/src/nfs.c      2016-06-02 12:31:26.705631769 -0400
@@ -1885,7 +1885,7 @@
           .default_value = "none",
           .description = "Reject a comma separated list of addresses and/or"
                          " hostnames from connecting to the server. By default,"
-                         " all connections are allowed. This allows users to "
+                         " all connections are allowed. This allows users to"
                          "define a general rule for all exported volumes."
         },
         { .key  = {"rpc-auth.addr.*.allow"},

--- Additional comment from Vijay Bellur on 2016-06-02 16:16:34 EDT ---

REVIEW: http://review.gluster.org/14620 (Very very minor typo fix in xlators/nfs/server/src/nfs.c Added space to .description; related to BZ 1005257) posted (#1) for review on release-3.8 by Dustin Black (dblack)

--- Additional comment from Dustin Black on 2016-06-02 16:23:25 EDT ---

Patched in release-3.8 branch.
http://review.gluster.org/#/c/14620/1


I'm guessing I should have patched this at the master... still building my git/gerrit chops.

--- Additional comment from Vijay Bellur on 2016-06-02 16:38:59 EDT ---

REVIEW: http://review.gluster.org/14621 (Very very minor typo fix in xlators/nfs/server/src/nfs.c Added space to .description; related to BZ 1005257) posted (#1) for review on master by Dustin Black (dblack)

Comment 1 Vijay Bellur 2016-06-06 16:16:31 UTC
REVIEW: http://review.gluster.org/14620 (nfs: fix a typo in the help text for option rpc-auth.addr.reject) posted (#2) for review on release-3.8 by Dustin Black (dblack)

Comment 2 Vijay Bellur 2016-06-06 20:28:54 UTC
COMMIT: http://review.gluster.org/14620 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 48f481c64e04d5c7f479f6eee52ea8b8bef9570e
Author: Dustin Black <dblack>
Date:   Thu Jun 2 16:15:25 2016 -0400

    nfs: fix a typo in the help text for option rpc-auth.addr.reject
    
    Added space to .description
    
    Reported-by: James Shubin <purpleidea>
    Change-Id: Ie4dd8774567ac4d8e1e8ec39aa3ab595d037101a
    BUG: 1342275
    Signed-off-by: Dustin Black <dblack>
    Reviewed-on: http://review.gluster.org/14620
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2016-06-16 12:33:09 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.