REVIEW: http://review.gluster.org/14666 (xdr/nfs: free complete groupnode structure) posted (#1) for review on master by bipin kunal (kunalbipin)
REVIEW: http://review.gluster.org/14667 (nfs: build exportlist with multiple groupnodes) posted (#1) for review on master by bipin kunal (kunalbipin)
Issue : showmount -e fails with "Connection timed out" when length of parameter passed to auth.allow is more that 255 character
COMMIT: http://review.gluster.org/14666 committed in master by Niels de Vos (ndevos) ------ commit 8489fe576b6cf148fabcaeee79f298c41858133e Author: Bipin Kunal <bkunal> Date: Tue Jun 7 17:59:27 2016 +0530 xdr/nfs: free complete groupnode structure The groupnode->gr_next pointer is not traversed upon free. This is currently not a problem, because the pointer is never used. However the correct way to free a groupnode should check the ->gr_next pointer and free any of the groups that it encounters. This problem was identified while correcting a problem with the MOUNT protocol. The change "nfs: build exportlist with multiple groups" starts to use ->gr_next. Change-Id: I9d04eaf4c65bdb8db136321d60e70789da1739d7 BUG: 1343286 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14666 Smoke: Gluster Build System <jenkins.com> Reviewed-by: bipin kunal <kunalbipin> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com>
COMMIT: http://review.gluster.org/14667 committed in master by Niels de Vos (ndevos) ------ commit 3bd4b1529817d4ce40c2b9654044e6230cbf7233 Author: Bipin Kunal <bkunal> Date: Tue Jun 7 18:30:16 2016 +0530 nfs: build exportlist with multiple groupnodes The EXPORT procedure of the MOUNT protocol does not correctly create structures for the 'groupnodes' in the reply. Each 'groupnode' should be a single entry in the 'nfs.rpc-auth-allow' volume option. Because the value is handled as a single string, the encoding of the groupnode->gr_name fails when the value of the volume option is longer than 255 characters. In the error case, encoding the EXPORTS reply fails, and the waiting 'showmount' command will not receive a reply and times out. Splitting the allowed entries and creating a groupnode for each one prevents the too long ->gr_name. This is following the structures for the EXPORTS reply in the MOUNT protocol more correctly as well. Note that the contents of ->gr_name is expected to be server dependent. Change-Id: Ibbabad581cc9aa00feb80fbbc851a1b10b28383d BUG: 1343286 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/14667 Smoke: Gluster Build System <jenkins.com> Reviewed-by: bipin kunal <kunalbipin> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: jiffin tony Thottan <jthottan> CentOS-regression: Gluster Build System <jenkins.com>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report. glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html [2] https://www.gluster.org/pipermail/gluster-users/