Bug 1343287 - Enabling glusternfs with nfs.rpc-auth-allow to many hosts failed
Summary: Enabling glusternfs with nfs.rpc-auth-allow to many hosts failed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: nfs
Version: 3.8.0
Hardware: Unspecified
OS: All
high
high
Target Milestone: ---
Assignee: Bipin Kunal
QA Contact:
URL:
Whiteboard:
Depends On: 1343286
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-07 04:25 UTC by Bipin Kunal
Modified: 2016-06-16 12:33 UTC (History)
8 users (show)

Fixed In Version: glusterfs-3.8.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1343286
Environment:
Last Closed: 2016-06-16 12:33:36 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Bipin Kunal 2016-06-07 13:40:17 UTC
Issue : showmount -e fails with "Connection timed out" when length of parameter passed to auth.allow is more that 255 character

Comment 2 Vijay Bellur 2016-06-10 12:20:20 UTC
REVIEW: http://review.gluster.org/14699 (xdr/nfs: free complete groupnode structure) posted (#1) for review on release-3.8 by bipin kunal (kunalbipin)

Comment 3 Vijay Bellur 2016-06-10 12:20:24 UTC
REVIEW: http://review.gluster.org/14700 (nfs: build exportlist with multiple groupnodes) posted (#1) for review on release-3.8 by bipin kunal (kunalbipin)

Comment 4 Vijay Bellur 2016-06-13 10:10:53 UTC
COMMIT: http://review.gluster.org/14699 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 4553ecf1d3f6186ea16864720e0d54773263ba3b
Author: Bipin Kunal <bkunal>
Date:   Fri Jun 10 17:45:58 2016 +0530

    xdr/nfs: free complete groupnode structure
    
    The groupnode->gr_next pointer is not traversed upon free. This is
    currently not a problem, because the pointer is never used. However the
    correct way to free a groupnode should check the ->gr_next pointer and
    free any of the groups that it encounters.
    
    This problem was identified while correcting a problem with the MOUNT
    protocol. The change "nfs: build exportlist with multiple groups" starts
    to use ->gr_next.
    
    This is backport of below mainline fix -
    	http://review.gluster.org/#/c/14666/
    
    Change-Id: I9d04eaf4c65bdb8db136321d60e70789da1739d7
    BUG: 1343287
    Signed-off-by: Niels de Vos <ndevos>
    Signed-off-by: Bipin Kunal <bkunal>
    Reviewed-on: http://review.gluster.org/14699
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: bipin kunal <kunalbipin>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 5 Vijay Bellur 2016-06-13 10:11:04 UTC
COMMIT: http://review.gluster.org/14700 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit dca103a2830746e08bea6b576465956f6568b521
Author: Bipin Kunal <bkunal>
Date:   Fri Jun 10 17:47:51 2016 +0530

    nfs: build exportlist with multiple groupnodes
    
    The EXPORT procedure of the MOUNT protocol does not correctly create
    structures for the 'groupnodes' in the reply. Each 'groupnode' should be
    a single entry in the 'nfs.rpc-auth-allow' volume option. Because the
    value is handled as a single string, the encoding of the
    groupnode->gr_name fails when the value of the volume option is longer
    than 255 characters.
    
    In the error case, encoding the EXPORTS reply fails, and the waiting
    'showmount' command will not receive a reply and times out.
    
    Splitting the allowed entries and creating a groupnode for each one
    prevents the too long ->gr_name. This is following the structures for
    the EXPORTS reply in the MOUNT protocol more correctly as well. Note
    that the contents of ->gr_name is expected to be server dependent.
    
    This is backport of below mainline fix -
    	http://review.gluster.org/#/c/14667/
    
    Change-Id: Ibbabad581cc9aa00feb80fbbc851a1b10b28383d
    BUG: 1343287
    Signed-off-by: Niels de Vos <ndevos>
    Signed-off-by: Bipin Kunal <bkunal>
    Reviewed-on: http://review.gluster.org/14700
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: bipin kunal <kunalbipin>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 6 Niels de Vos 2016-06-16 12:33:36 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.