Spec URL: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec SRPM URL: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.4-0.1.20160613171442.fc25.src.rpm Description: The python-blivet package is a python module for examining and modifying storage configuration. This package provides the old 1.20 API for use with python2. Fedora Account System Username: dlehman
A bit more information: python-blivet-2.x is python3-only. This package contains python-blivet-1.20 packaged for python2 only.
Updated spec and srpm: Spec URL: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec SRPM URL: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.4-0.1.20160614194316.fc25.src.rpm
WARNING: Cannot download url: http://github.com/rhinstaller/blivet/archive/blivet-1.20.4.tar.gz fedora-review also complains about ""python-blivet1.noarch: W: incoherent-version-in-changelog 1.20.4-0.1.20160614194316 ['1:1.20.4-0.1.20160614194316.fc23', '1:1.20.4-0.1.20160614194316'] and python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/kw-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/kw-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/pt-BR/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/pt-BR/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-CN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-CN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-HK/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-HK/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-TW/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-TW/LC_MESSAGES/blivet1.mo " those are also rpmlint errors
any progress?
It doesn't matter that it can't download the archive listed as Source0 for two reasons: 1) dist-git uses its own copy of the sources 2) the upstream archive lacks translations and is therefore not suitable for an rpm build The locale directory is named blivet1 intentionally since python3-blivet and python-blivet1 could coexist on the same system. Using blivet1 allows us to have a unique directory for translations of the compatibility package.
The url does matter for rpmlint and reasonable to have it reachable - you can take care of making Source0 reachable. Users might want to get the actual source tarball, and some tools try to download it as well. I assume you have a reason for the naming, but it doesn't mean the errors are wrong. please ignore them - understand why you are trying to reach /usr/share/locale/en-*/LC_MESSAGES/blivet1.mo. Correcting the change-log prints is quite easy and reasonable to ask as well. You need to fix those errors.. its fedora guidelines, not mine
(In reply to Yaniv Bronhaim from comment #6) > The url does matter for rpmlint and reasonable to have it reachable - you > can take care of making Source0 reachable. Users might want to get the > actual source tarball, and some tools try to download it as well. They can try to download it, but they will not be able to build an rpm with it. I can adjust the url, but nobody will be building rpms from that. > > I assume you have a reason for the naming, but it doesn't mean the errors > are wrong. please ignore them - understand why you are trying to reach > /usr/share/locale/en-*/LC_MESSAGES/blivet1.mo. The errors are not valid in this case, as I explained. The package cannot use /usr/share/locale/en-*/LC_MESSAGES/blivet.mo as that is already in use by python3-blivet-2.x in rawhide. > > Correcting the change-log prints is quite easy and reasonable to ask as well. The version error is because I gave you a scratch build with a timestamp in the version. There is nothing to fix, unless the version I upload must exactly match what I will import into dist-git. > > You need to fix those errors.. its fedora guidelines, not mine I was told that rpmlint errors do not necessarily block the acceptance of a package, especially when there is a reasonable explanation for the warnings/errors. I will upload a new version with a reachable (but unusable) Source0 and an easier to parse version. The translations will not be changed.
New spec and SRPM available: SRPM: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.3-1.fc25.src.rpm SPEC: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec
The changelog complaint was that the version in the changelog didn't match the package's version. The only difference between the two is the %{?dist} tag. I've noticed that even when I add the %{?dist} at the end of the version in %changelog rpmlint makes the same complaint about the versions not matching, which is wrong.
Hi David, Just a question, if this package is for the python2 version, do you still need the below line? BuildRequires: python3-devel python3-setuptools and Shouldn't be pygobject2-base instead of below? Requires: pygobject3-base Thanks!
(In reply to Douglas Schilling Landgraf from comment #10) > Hi David, > > Just a question, if this package is for the python2 version, do you still > need the below line? > > BuildRequires: python3-devel python3-setuptools > > and > > > Shouldn't be pygobject2-base instead of below? > > Requires: pygobject3-base > > Thanks! Yes, any python3 dependencies should probably be removed.
(In reply to David Lehman from comment #11) > (In reply to Douglas Schilling Landgraf from comment #10) > > Hi David, > > > > Just a question, if this package is for the python2 version, do you still > > need the below line? > > > > BuildRequires: python3-devel python3-setuptools > > > > and > > > > > > Shouldn't be pygobject2-base instead of below? > > > > Requires: pygobject3-base > > > > Thanks! > > Yes, any python3 dependencies should probably be removed. Cool, thanks. Waiting a new spec for review.
New spec and SRPM available: SRPM: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.3-2.fc25.src.rpm SPEC: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec (I didn't change pygobject3-base requires since that does not have anything to do with python3.)
Hi David, (In reply to David Lehman from comment #13) > New spec and SRPM available: > > SRPM: > https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.3-2.fc25. > src.rpm > > SPEC: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec > > > > (I didn't change pygobject3-base requires since that does not have anything > to do with python3.) Looks like it has to do with python3, from pygobject3-base spec: <snip> %if 0%{?fedora} > 12 %global with_python3 1 %define python3_version 3.1 %endif </snip> %if 0%{?with_python3} BuildRequires: python3-devel >= %{python3_version} BuildRequires: python3-cairo-devel %endif # if with_python3 </snip> From: https://admin.fedoraproject.org/pkgdb/package/rpms/pygobject2/ rpms/pygobject2 (upstream) Python 2 bindings for GObject The pygobject2 package provides a convenient wrapper for the GObject library for use in Python programs. Additional comment, you can remove the lines below because it's deprecated/obsolete: * rm -rf %{buildroot} * %defattr(-,root,root,-) Thanks!
Hmm, based on the set of packages produced by http://koji.fedoraproject.org/koji/buildinfo?buildID=781960 I wonder if it should be Requires: python-gobject-base.
New spec and SRPM available: SRPM: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.3-3.fc25.src.rpm SPEC: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec
Hi, A few additional comments: $ fedora-review --rpm-spec -n python-blivet1-1.20.3-3.fc25.src.rpm INFO: Processing local files: python-blivet1-1.20.3-3.fc25.src.rpm INFO: Getting .spec and .srpm Urls from : Local files in /home/fedora INFO: --> SRPM url: file:///home/fedora/python-blivet1-1.20.3-3.fc25.src.rpm INFO: Using review directory: /home/fedora/python-blivet1 ERROR: 'Cannot find spec file in srpm' (logs in /home/fedora/.cache/fedora-review.log) This is caused because your spec file is called python-blivet.spec not python-blivet1.spec. I have other question now, I see you are package maint. of python-blivet package, why not use the current spec to create a subpackage of python2 and python3 ? No need to create a new package/review "python-blivet1", just add the new subpackages and rebuild it, like: python2-blivet python3-blivet "Common spec file example" https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file You can always examine the others reviews and specs: https://lists.fedoraproject.org/archives/search?mlist=package-review%40lists.fedoraproject.org&q=python Finally, recommend you to use global instead of define in your python-blivet: https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define From my point of view, we should close this bug and please proceed in the python-blivet spec. Please let me know your thoughts. Thanks!
(In reply to Douglas Schilling Landgraf from comment #17) > ERROR: 'Cannot find spec file in srpm' (logs in > /home/fedora/.cache/fedora-review.log) > > This is caused because your spec file is called python-blivet.spec not > python-blivet1.spec. Yes, I have to fix this. > > I have other question now, I see you are package maint. of python-blivet > package, why not use the current spec to create a subpackage of python2 and > python3 ? No need to create a new package/review "python-blivet1", just add > the new subpackages and rebuild it, like: > > python2-blivet > python3-blivet The python-blivet-2.x codebase is not python2-compatible. That is why this compatibility package is being introduced. We cannot use python2-blivet-1.x because the translations would collide with those from python3-blivet-2.x. > Finally, recommend you to use global instead of define in your python-blivet: Will do. New package coming soon.
New spec and SRPM available: SRPM: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.3-4.fc25.src.rpm SPEC: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec Changes: - renamed specfile to match package - replaced %define w/ %global
Hi David, From fedora-review, could you please check? Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/fedora/python- blivet1/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Installation errors ------------------- INFO: mock.py version 1.2.18 starting (python version = 3.5.1)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.18 INFO: Mock Version: 1.2.18 Finish: chroot init INFO: installing package(s): /home/fedora/python-blivet1/results/python-blivet1-1.20.3-4.fc24.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-24-x86_64/root/ --releasever 24 --disableplugin=local --setopt=deltarpm=false install /home/fedora/python-blivet1/results/python-blivet1-1.20.3-4.fc24.noarch.rpm --setopt=tsflags=nocontexts Source checksums ---------------- http://github.com/rhinstaller/blivet/archive/blivet-1.20.3.tar.gz : CHECKSUM(SHA256) this package : ce17ee5a0320c879416b1bfd5f5e97f33d069501b868d5f6cd9c97bb25d1e5ce CHECKSUM(SHA256) upstream package : c6825857baf79df604c6409f932367ee4834e667397b805fc57b86757c0485eb diff -r also reports differences
New spec and SRPM available: SRPM: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.3-5.fc25.src.rpm SPEC: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec Changes: - use smp make macro - remove obsolete Requires: blivet-data which prevented install in mock > > Issues: > ======= > - Package installs properly. > Note: Installation errors (see attachment) > See: https://fedoraproject.org/wiki/Packaging:Guidelines > - Sources used to build the package match the upstream source, as provided > in the spec URL. > Note: Upstream MD5sum check error, diff is in /home/fedora/python- > blivet1/diff.txt > See: http://fedoraproject.org/wiki/Packaging/SourceURL Upstream tarballs do not include translations, hence the difference. > > > > ===== SHOULD items ===== > > Generic: > [!]: Uses parallel make %{?_smp_mflags} macro. Fixed. > > > ===== EXTRA items ===== > > Generic: > [!]: Rpmlint is run on all installed packages. > Note: Mock build failed > See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Fixed. > > Source checksums > ---------------- > http://github.com/rhinstaller/blivet/archive/blivet-1.20.3.tar.gz : > CHECKSUM(SHA256) this package : > ce17ee5a0320c879416b1bfd5f5e97f33d069501b868d5f6cd9c97bb25d1e5ce > CHECKSUM(SHA256) upstream package : > c6825857baf79df604c6409f932367ee4834e667397b805fc57b86757c0485eb > diff -r also reports differences Upstream tarball does not include translations so this is expected.
Package approved. * Translations are not included in this .tar.gz, stored in zanata (out of scope for this compat package) and the others locale warnings/errors as well. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/fedora/python- blivet1/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock/fedora-24-x86_64/root/builddir/build/BUILD/blivet-1.20.3' returned non-zero exit status 1 [X]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/en-GB, /usr/share/locale/de- CH, /usr/share/locale/pt-BR, /usr/share/locale/kw@kkcor, /usr/share/locale/zh-HK, /usr/share/locale/zh-CN, /usr/share/locale/kw_GB/LC_MESSAGES, /usr/share/locale/kw@kkcor/LC_MESSAGES, /usr/share/locale/kw@uccor, /usr/share/locale/zh-TW, /usr/share/locale/en-GB/LC_MESSAGES, /usr/share/locale/zh-TW/LC_MESSAGES, /usr/share/locale/bn- IN/LC_MESSAGES, /usr/share/locale/de-CH/LC_MESSAGES, /usr/share/locale/wba/LC_MESSAGES, /usr/share/locale/kw_GB, /usr/share/locale/kw-GB, /usr/share/locale/zh-CN/LC_MESSAGES, /usr/share/locale/zh-HK/LC_MESSAGES, /usr/share/locale/pt- BR/LC_MESSAGES, /usr/share/locale/kw-GB/LC_MESSAGES, /usr/share/locale/kw@uccor/LC_MESSAGES, /usr/share/locale/wba, /usr/share/locale/bn-IN [X]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/en-GB, /usr/share/locale/en-GB/LC_MESSAGES, /usr/share/locale/zh- TW/LC_MESSAGES, /usr/share/locale/de-CH, /usr/share/locale/bn- IN/LC_MESSAGES, /usr/share/locale/pt-BR, /usr/share/locale/de- CH/LC_MESSAGES, /usr/share/locale/wba/LC_MESSAGES, /usr/share/locale/kw@kkcor, /usr/share/locale/zh-HK, /usr/share/locale/kw_GB, /usr/share/locale/kw-GB, /usr/share/locale /zh-CN/LC_MESSAGES, /usr/share/locale/zh-CN, /usr/share/locale/kw_GB/LC_MESSAGES, /usr/share/locale/zh- HK/LC_MESSAGES, /usr/share/locale/pt-BR/LC_MESSAGES, /usr/share/locale /kw-GB/LC_MESSAGES, /usr/share/locale/kw@kkcor/LC_MESSAGES, /usr/share/locale/kw@uccor/LC_MESSAGES, /usr/share/locale/kw@uccor, /usr/share/locale/zh-TW, /usr/share/locale/wba, /usr/share/locale/bn- IN [X]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python2.7/site- packages/blivet/formats(python-blivet), /usr/lib/python2.7/site- packages/blivet/devicelibs(python-blivet), /usr/lib/python2.7/site- packages/blivet/tasks(python-blivet), /usr/lib/python2.7/site- packages/blivet(python-blivet), /usr/lib/python2.7/site- packages/blivet/devices(python-blivet) [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: The spec file handles locales properly. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [X]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 645120 bytes in 8 files. [X]: Package complies to the Packaging Guidelines [X]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [X]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [X]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python-blivet1-1.20.3-5.fc24.noarch.rpm python-blivet1-1.20.3-5.fc24.src.rpm python-blivet1.noarch: W: incoherent-version-in-changelog 1.20.3-5.fc24 ['1:1.20.3-5.fc24', '1:1.20.3-5'] python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/kw-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/kw-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/pt-BR/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/pt-BR/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-CN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-CN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-HK/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-HK/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-TW/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-TW/LC_MESSAGES/blivet1.mo python-blivet1.src: W: file-size-mismatch blivet-1.20.3.tar.gz = 699962, http://github.com/rhinstaller/blivet/archive/blivet-1.20.3.tar.gz = 391947 2 packages and 0 specfiles checked; 16 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python-blivet1.noarch: W: incoherent-version-in-changelog 1.20.3-5.fc24 ['1:1.20.3-5.fc24', '1:1.20.3-5'] python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/kw-GB/LC_MESSAGES/blivet1.mo Requires -------- python-blivet1 (rpmlib, GLIBC filtered): dosfstools e2fsprogs libblockdev-plugins-all libselinux-python lsof parted pyparted python python(abi) python-gobject-base python-hawkey python-kickstart python-pyudev python-six python2-blockdev util-linux Provides -------- python-blivet1: python-blivet1 Source checksums ---------------- http://github.com/rhinstaller/blivet/archive/blivet-1.20.3.tar.gz : CHECKSUM(SHA256) this package : ce17ee5a0320c879416b1bfd5f5e97f33d069501b868d5f6cd9c97bb25d1e5ce CHECKSUM(SHA256) upstream package : c6825857baf79df604c6409f932367ee4834e667397b805fc57b86757c0485eb diff -r also reports differences Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --rpm-spec -n python-blivet1-1.20.3-5.fc25.src.rpm Buildroot used: fedora-24-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-blivet1
Douglas, David: would you push the f25 package via bodhi?
python-blivet1-1.20.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3b1c84ea90
python-blivet1-1.20.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3b1c84ea90
python-blivet1-1.20.3-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
removing needinfo, package already provided in f25 branch.