Bug 1346918 - Remove old API of VM disks
Summary: Remove old API of VM disks
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RestAPI
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.0.1
: 4.0.1.1
Assignee: Tal Nisan
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-15 16:04 UTC by Tal Nisan
Modified: 2019-04-28 13:53 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-07-19 06:23:11 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.0.z+
rule-engine: blocker+
rule-engine: planning_ack+
tnisan: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1353175 0 unspecified CLOSED Remove old API of template disks and replace it with the new diskattachments API 2021-02-22 00:41:40 UTC
oVirt gerrit 59931 0 master MERGED Remove vms/{vm_id}/disks from API 2016-07-04 14:13:42 UTC
oVirt gerrit 60145 0 model_4.0 MERGED Remove vms/{vm_id}/disks from API 2016-07-04 14:16:27 UTC
oVirt gerrit 60158 0 master MERGED restapi: Support removing of vms/{vm_id}/disks from the API 2016-07-05 09:51:56 UTC
oVirt gerrit 60199 0 ovirt-engine-4.0 MERGED restapi: Support removing of vms/{vm_id}/disks from the API 2016-07-05 11:15:37 UTC
oVirt gerrit 60202 0 ovirt-engine-4.0.1 MERGED restapi: Support removing of vms/{vm_id}/disks from the API 2016-07-05 11:15:52 UTC

Internal Links: 1353175

Description Tal Nisan 2016-06-15 16:04:12 UTC 
Description of problem:

Currently V4 API still supports V3 lists and actions on VM disks in:

api/vms/{vm_id}/disks
api/vms/{vm_id}/disks/{disk_id}

Those should be removed and the functionality should only be supported in:

api/vms/{vm_id}/diskattachments
api/vms/{vm_id}/diskattachments/{disk_attachment_id}


The functionality in V4 resources used by delegation from V3 should be moved to V3 classes

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Juan Hernández 2016-06-15 16:07:11 UTC 
This kind of change can't be targeted to 4.0.1, as we are not allowed to make backwards compatibility breaking changes once version 4 of the API is released. Please retarget to 4.0.0, or close as WONTFIX.
Comment 2 Yaniv Lavi 2016-06-27 11:43:18 UTC 
We will have a release note on removal of this. We should allow small changes in the first z streams of the 4.0 API.
Comment 3 Yaniv Lavi 2016-06-29 11:47:07 UTC 
We don't have many users that already moved to v4 of the API therefore we can allow small breakages of backwards compatibility on a case by case request.
This one is approved.
Comment 4 Allon Mureinik 2016-07-07 12:11:11 UTC 
Tal - this should be documented. Not sure if here or as part of a broader API documentation.
Comment 5 Raz Tamir 2016-07-17 18:08:04 UTC 
Verified on rhevm-4.0.1.1-0.1.el7ev.noarch.
There is no link to api/vms/{vm_id}/disks with v4 api
Comment 6 Sandro Bonazzola 2016-07-19 06:23:11 UTC 
Since the problem described in this bug report should be
resolved in oVirt 4.0.1 released on July 19th 2016, it has been closed with a
resolution of CURRENT RELEASE.

For information on the release, and how to update to this release, follow the link below.

If the solution does not work for you, open a new bug report.

http://www.ovirt.org/release/4.0.1/
Note You need to log in before you can comment on or make changes to this bug.