Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1353175

Summary: Remove old API of template disks and replace it with the new diskattachments API
Product: [oVirt] ovirt-engine Reporter: Tal Nisan <tnisan>
Component: RestAPIAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Carlos Mestre González <cmestreg>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.0.0CC: acanan, amureini, bugs, cmestreg, tnisan
Target Milestone: ovirt-4.0.1Keywords: ZStream
Target Release: 4.0.1.1Flags: rule-engine: ovirt-4.0.z+
rule-engine: blocker+
rule-engine: planning_ack+
tnisan: devel_ack+
rule-engine: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-19 06:26:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tal Nisan 2016-07-06 11:34:14 UTC
Description of problem:

Currently V4 API still supports V3 lists and actions on template disks in:

api/templates/{template_id}/disks
api/templates/{template_id}/disks/{disk_id}

Those should be removed and the functionality and the new functionality should be added in:

api/templates/{template_id}/diskattachments
api/templates/{template_id}/diskattachments/{disk_attachment_id}

The functionality in V4 resources used by delegation from V3 should be moved to V3 classes

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Allon Mureinik 2016-07-14 15:37:24 UTC
Tal - not sure if this is just documented in the REST documentation already or requires a specific treatment, but flagging as requires-doctext? just to be on the safe side. If it's redundant, feel free to set - instead.

Comment 2 Carlos Mestre González 2016-07-18 12:07:27 UTC
/disks/ returns 404, diskattachments works for single/multiple disks. I tested also different values creating multiple templates and vms fro m those templates.


Regarding methods:

/templates/{template:id}/diskattachments/ allows HEAD, DELETE, GET, OPTIONS
/templates/{template:id}/diskattachments/{disk_attachment:id} allows HEAD, GET, OPTIONS

DELETE works as expected when the disk is copied to multiple storage domains (and is documented on the api)

version: 4.0.1.1-0.1.el7ev

Comment 3 Sandro Bonazzola 2016-07-19 06:26:28 UTC
Since the problem described in this bug report should be
resolved in oVirt 4.0.1 released on July 19th 2016, it has been closed with a
resolution of CURRENT RELEASE.

For information on the release, and how to update to this release, follow the link below.

If the solution does not work for you, open a new bug report.

http://www.ovirt.org/release/4.0.1/