Spec URL: https://jjames.fedorapeople.org/cxsc/cxsc.spec SRPM URL: https://jjames.fedorapeople.org/cxsc/cxsc-2.5.4-1.fc25.src.rpm Fedora Account System Username: jjames Description: C-XSC is the C language variant of the XSC (eXtensions for Scientific Computing) project. It provides routines that guarantee accuracy and reliability of results. Problem-solving routines with automatic result verification have been developed for many standard problems of numerical analysis, such as linear or nonlinear systems of equations, differential and integral equations, etc. as well as for a large number of applications in engineering and the natural sciences. Some of the features of C-XSC are: - Operator concept (user-defined operators) - Overloading concept - Module concept - Dynamic arrays - Controlled rounding - Predefined arithmetic data types real, extended real, complex, interval, complex interval, and corresponding vector and matrix types - Predefined arithmetic operators and elementary functions of the highest accuracy for the arithmetic data types - Data type dotprecision for the exact representation of dot products - Library of mathematical problem-solving routines with automatic result verification and high accuracy
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14606902
> Version: %(tr - . <<< %{upstreamver}) Version: %(v=%{upstreamver}; echo ${v//-/.}) > %global majver %(cut -d. -f1 <<< %{version}) %global majver %(v=%{version}; echo ${v%%.*}) > if [ %{_libdir} = "%{_prefix}/lib64" ]; then > sed -i 's|/lib|/lib64|' CToolbox/Makefile > fi sed -i -e 's|/lib|/%{_lib}|' CToolbox/Makefile > %{_libdir}/sse2/lib%{name}.so.2* not sure how it should be properly handled (SSE2 things)
Hi Igor. Thanks for the suggestions. (In reply to Igor Gnatenko from comment #2) > > Version: %(tr - . <<< %{upstreamver}) > Version: %(v=%{upstreamver}; echo ${v//-/.}) Why is that better? > > %global majver %(cut -d. -f1 <<< %{version}) > %global majver %(v=%{version}; echo ${v%%.*}) Why is that better? > > if [ %{_libdir} = "%{_prefix}/lib64" ]; then > > sed -i 's|/lib|/lib64|' CToolbox/Makefile > > fi > sed -i -e 's|/lib|/%{_lib}|' CToolbox/Makefile Okay, I can see this one. I will make that change. > > %{_libdir}/sse2/lib%{name}.so.2* > not sure how it should be properly handled (SSE2 things) I don't understand what you are talking about with this one.
have time for this https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=1353598 ?
maybe you can safety remove jquery from https://fedoraproject.org/wiki/Changes/jQuery ln -fs %{_datadir}/javascript/jquery/[jquery VERSION]/jquery.min.js [BUNDLE LIBRARY PATH]/jquery.js
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Please, remove BuildRequires: gcc-c++ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 64 files have unknown license. Detailed output of licensecheck in /home/gil/1349075-cxsc/licensecheck.txt Please, report "LGPL (v2 or later) (with incorrect FSF address)" to upstream [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 14 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cxsc- debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 59545600 bytes in /usr/share cxsc- doc-2.5.4-1.fc25.i686.rpm:59453440 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines False [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cxsc-2.5.4-1.fc25.i686.rpm cxsc-devel-2.5.4-1.fc25.i686.rpm cxsc-doc-2.5.4-1.fc25.i686.rpm cxsc-debuginfo-2.5.4-1.fc25.i686.rpm cxsc-2.5.4-1.fc25.src.rpm cxsc.i686: W: spelling-error %description -l en_US eXtensions -> extensions, extension, extension's cxsc.i686: W: spelling-error %description -l en_US dotprecision -> dot precision, dot-precision, imprecision cxsc.i686: W: shared-lib-calls-exit /usr/lib/libcxsc.so.2.5.4 exit cxsc.i686: E: incorrect-fsf-address /usr/share/licenses/cxsc/COPYING cxsc.src: W: spelling-error %description -l en_US eXtensions -> extensions, extension, extension's cxsc.src: W: spelling-error %description -l en_US dotprecision -> dot precision, dot-precision, imprecision cxsc.src:55: W: unversioned-explicit-provides bundled(jquery) cxsc.src:113: W: rpm-buildroot-usage %build %{buildroot}%{_prefix}\n\ cxsc.src:141: W: rpm-buildroot-usage %build %{buildroot}%{_prefix}\n\ 5 packages and 0 specfiles checked; 1 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: cxsc-debuginfo-2.5.4-1.fc25.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- cxsc.i686: W: spelling-error %description -l en_US eXtensions -> extensions, extension, extension's cxsc.i686: W: spelling-error %description -l en_US dotprecision -> dot precision, dot-precision, imprecision cxsc.i686: W: shared-lib-calls-exit /usr/lib/libcxsc.so.2.5.4 exit cxsc.i686: E: incorrect-fsf-address /usr/share/licenses/cxsc/COPYING 4 packages and 0 specfiles checked; 1 errors, 3 warnings. Requires -------- cxsc-debuginfo (rpmlib, GLIBC filtered): cxsc-devel (rpmlib, GLIBC filtered): cxsc(x86-32) libcxsc.so.2 cxsc-doc (rpmlib, GLIBC filtered): cxsc(x86-32) cxsc (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux.so.2 libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgomp.so.1 libgomp.so.1(GOMP_4.0) libgomp.so.1(OMP_1.0) libm.so.6 libsatlas.so.3 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.8) libstdc++.so.6(CXXABI_1.3.9) rtld(GNU_HASH) Provides -------- cxsc-debuginfo: cxsc-debuginfo cxsc-debuginfo(x86-32) cxsc-devel: cxsc-devel cxsc-devel(x86-32) cxsc-doc: bundled(jquery) cxsc-doc cxsc-doc(x86-32) cxsc: cxsc cxsc(x86-32) libcxsc.so.2 Source checksums ---------------- http://www2.math.uni-wuppertal.de/wrswt/xsc/cxsc/cxsc-2-5-4.tar.gz : CHECKSUM(SHA256) this package : fd0d824fd94bef3aae55b95e5ef19342b653fe3ff4fb561364e942c809eb616b CHECKSUM(SHA256) upstream package : fd0d824fd94bef3aae55b95e5ef19342b653fe3ff4fb561364e942c809eb616b Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1349075 --plugins C/C++ -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Issues (non blocking): - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Please, remove BuildRequires: gcc-c++ [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 64 files have unknown license. Detailed output of licensecheck in /home/gil/1349075-cxsc/licensecheck.txt cxsc.i686: E: incorrect-fsf-address /usr/share/licenses/cxsc/COPYING Please, report "LGPL (v2 or later) (with incorrect FSF address)" to upstream
Created attachment 1180222 [details] licensecheck.txt
(In reply to gil cattaneo from comment #5) > maybe you can safety remove jquery > from https://fedoraproject.org/wiki/Changes/jQuery > ln -fs %{_datadir}/javascript/jquery/[jquery VERSION]/jquery.min.js [BUNDLE > LIBRARY PATH]/jquery.js Oh, I didn't know the migration was ready to happen. Great! I will make this change. Except it doesn't work. Doxygen inserts a copy of jquery 1.7.1. I tried using the system version of jquery 1 (currently 1.11.2), and the sidebar became blank, and overlapped the main region of the window. Apparently js-jquery-migrate is required, but that means editing every single HTML file to insert the appropriate magic. Ugh. I don't want to do this. The right fix is to update doxygen so that it can use jquery 1.9 or later, then the symlink trick will work. There is an upstream bug to do this: https://bugzilla.gnome.org/show_bug.cgi?id=768492. As for BuildRequires: gcc-c++, that is now required. See https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires. Apparently rpmlint has not yet been updated to reflect this change. I will contact upstream about the incorrect FSF address. They moved in, what, 2005? It's strange how many projects haven't noticed that more than a decade later.
(In reply to Jerry James from comment #9) > (In reply to gil cattaneo from comment #5) > > maybe you can safety remove jquery > > from https://fedoraproject.org/wiki/Changes/jQuery > > ln -fs %{_datadir}/javascript/jquery/[jquery VERSION]/jquery.min.js [BUNDLE > > LIBRARY PATH]/jquery.js > > Oh, I didn't know the migration was ready to happen. Great! I will make > this change. > > Except it doesn't work. Doxygen inserts a copy of jquery 1.7.1. I tried > using the system version of jquery 1 (currently 1.11.2), and the sidebar > became blank, and overlapped the main region of the window. Apparently > js-jquery-migrate is required, but that means editing every single HTML file > to insert the appropriate magic. Ugh. I don't want to do this. The right > fix is to update doxygen so that it can use jquery 1.9 or later, then the > symlink trick will work. There is an upstream bug to do this: > https://bugzilla.gnome.org/show_bug.cgi?id=768492. leave the bundle js file > As for BuildRequires: gcc-c++, that is now required. See > https://fedoraproject.org/wiki/Packaging: > C_and_C%2B%2B#BuildRequires_and_Requires. Apparently rpmlint has not yet > been updated to reflect this change. Someone have noticed of this change in the development list? > I will contact upstream about the incorrect FSF address. They moved in, > what, 2005? It's strange how many projects haven't noticed that more than a > decade later. Approved
(In reply to gil cattaneo from comment #10) > Someone have noticed of this change in the development list? Yes, see the thread here: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/XGXCCAJNEOIEN3KK6TN2657LSIGZGB3N/ Thank you for the review!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/cxsc
cxsc-2.5.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-73a734e090
cxsc-2.5.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-73a734e090
cxsc-2.5.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.