Spec URL: https://jjames.fedorapeople.org/gap-pkg-float/gap-pkg-float.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-float/gap-pkg-float-0.7.4-1.fc25.src.rpm Fedora Account System Username: jjames Description: This package implements floating-point numbers within GAP, with arbitrary precision, based on the C libraries FPLLL, MPFR, MPFI, MPC and CXSC.
Approved, only two remarks: - You could use %make_build instead of make %{?_smp_mflags} - Upstream could be encouraged to add license headers to the source files: src/floattypes.h: UNKNOWN src/mpc.c: UNKNOWN src/float.c: UNKNOWN src/mpfr.c: UNKNOWN src/mpd.c: UNKNOWN src/mpfi.c: UNKNOWN Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [c]: Package does not contain kernel modules. [c]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gap-pkg- float-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gap-pkg-float-0.7.4-1.fc25.x86_64.rpm gap-pkg-float-debuginfo-0.7.4-1.fc25.x86_64.rpm gap-pkg-float-0.7.4-1.fc25.src.rpm gap-pkg-float.x86_64: W: spelling-error Summary(en_US) mpfr -> mfr, mp fr, mp-fr gap-pkg-float.x86_64: W: spelling-error Summary(en_US) mpfi -> campfire gap-pkg-float.x86_64: W: spelling-error Summary(en_US) mpc -> mp, mic, mac gap-pkg-float.x86_64: W: spelling-error Summary(en_US) fplll -> fillip gap-pkg-float.x86_64: W: spelling-error Summary(en_US) cxsc -> Cisco gap-pkg-float.src: W: spelling-error Summary(en_US) mpfr -> mfr, mp fr, mp-fr gap-pkg-float.src: W: spelling-error Summary(en_US) mpfi -> campfire gap-pkg-float.src: W: spelling-error Summary(en_US) mpc -> mp, mic, mac gap-pkg-float.src: W: spelling-error Summary(en_US) fplll -> fillip gap-pkg-float.src: W: spelling-error Summary(en_US) cxsc -> Cisco 3 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (debuginfo) ------------------- Checking: gap-pkg-float-debuginfo-0.7.4-1.fc25.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- gap-pkg-float.x86_64: W: spelling-error Summary(en_US) mpfr -> mfr, mp fr, mp-fr gap-pkg-float.x86_64: W: spelling-error Summary(en_US) mpfi -> campfire gap-pkg-float.x86_64: W: spelling-error Summary(en_US) mpc -> mp, mic, mac gap-pkg-float.x86_64: W: spelling-error Summary(en_US) fplll -> fillip gap-pkg-float.x86_64: W: spelling-error Summary(en_US) cxsc -> Cisco 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- gap-pkg-float (rpmlib, GLIBC filtered): gap-core libc.so.6()(64bit) libcxsc.so.2()(64bit) libfplll.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libmpc.so.3()(64bit) libmpfi.so.0()(64bit) libmpfr.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) gap-pkg-float-debuginfo (rpmlib, GLIBC filtered): Provides -------- gap-pkg-float: gap-pkg-float gap-pkg-float(x86-64) gap-pkg-float-debuginfo: gap-pkg-float-debuginfo gap-pkg-float-debuginfo(x86-64) Unversioned so-files -------------------- gap-pkg-float: /usr/lib/gap/pkg/float/bin/x86_64-redhat-linux-gnu-gcc-default64/float.so Source checksums ---------------- https://github.com/gap-packages/float/releases/download/v0.7.4/float-0.7.4.tar.gz : CHECKSUM(SHA256) this package : d8e74fe456a27dfa9e7bdfca56072fcfa932f102d11972d1497264c0e6c367b3 CHECKSUM(SHA256) upstream package : d8e74fe456a27dfa9e7bdfca56072fcfa932f102d11972d1497264c0e6c367b3 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1352175 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Sandro Mani from comment #1) > Approved, only two remarks: > > - You could use %make_build instead of make %{?_smp_mflags} Is that a new macro? I don't recall seeing it before. > - Upstream could be encouraged to add license headers to the source files: > src/floattypes.h: UNKNOWN > src/mpc.c: UNKNOWN > src/float.c: UNKNOWN > src/mpfr.c: UNKNOWN > src/mpd.c: UNKNOWN > src/mpfi.c: UNKNOWN Okay. I am already in contact with upstream on a couple of other minor issues, so I will mention this. Thank you for the review!
> > Approved, only two remarks: > > > > - You could use %make_build instead of make %{?_smp_mflags} > > Is that a new macro? I don't recall seeing it before. Newish [1], should be in rpm-4.12+ and backported to EL7 if I'm not mistaken. [1] http://rpm.org/gitweb?p=rpm.git;a=commitdiff;h=89df36524bace71decee4ab4f979d4ffb449c9a7
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-float
gap-pkg-float-0.7.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-49d0bb5c71
gap-pkg-float-0.7.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-49d0bb5c71
gap-pkg-float-0.7.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.