Bug 1350973 - kf5-networkmanager-qt: RFE: drop hard Requires: NetworkManager
Summary: kf5-networkmanager-qt: RFE: drop hard Requires: NetworkManager
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: kf5-networkmanager-qt
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-28 21:52 UTC by Rex Dieter
Modified: 2016-10-18 14:34 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Rex Dieter 2016-06-28 21:52:01 UTC
More than just plasma-nm is linking kf5-networkmanager-qt these days, including powerdevil, and if we want to continue to allow NetworkManager to be an optional dep, we need to do something different packaging-wise.

I propose we consider doing something similar implemented in PackageKit-Qt.  There we changed
Requires to Recommends
and added
Requires: PackageKit-Qt
dependencies to all library consumers that *really* needs it (apper, discover, muon)

In this case, I think the only kf5-networkmanager-qt consumer that *really* needs NetworkManager is plasma-nm, and maybe plasma-workspace-geolocation(1) 

(1) the -geolocation subpkg was created only to allow NetworkManager removal in the past, so once this is implemented, we could consider dropping the subpkg for simplicity

Comment 1 Rex Dieter 2016-06-28 21:53:38 UTC
CC'ing lkundrak , since (according to repoquery): hawaii-shell currently has
Requires: kf5-networkmanager-qt
too.

Comment 2 Rex Dieter 2016-06-28 21:55:05 UTC
Explicitly cc'ing jgrulich too, who had opposed this general idea the last time the topic came up, see also:
https://bugzilla.redhat.com/show_bug.cgi?id=1222097#c4

Comment 3 Jan Grulich 2016-06-29 07:16:04 UTC
For me it doesn't make much sense having a kf5-networkmanager-qt without a runtime it requires for usage, but if you really want to have NetworkManager to be removable, then I'm not against it. I think you only need to have this dependency in plasma-nm where this is really necessary and those who want to remove NetworkManager will need to remove plasma-nm too.

Comment 4 Rex Dieter 2016-06-29 14:20:38 UTC
Thanks for feedback.

Looks like plasma-nm already has
Requires: NetworkManager

So looks like I'll move forward with implementing the proposed change to kf5-networkmanager-qt

Comment 5 Corinna Vinschen 2016-10-17 08:39:18 UTC
Hi,

it appears there's a regression with kf5-networkmanager-qt 5.26.0-1 in
fc23, which pulls in a requirement to NetworkManager again.  So far the
machine I encountered this on is running without NetworkManager, but when
trying to update kf5-networkmanager-qt to 5.26.0-1, it suddenly requires
NetworkManager.


Thanks,
Corinna

Comment 6 Rex Dieter 2016-10-17 11:12:27 UTC
Since,

* Wed Jun 29 2016 Rex Dieter <rdieter> - 5.23.0-3
- Recommends: NetworkManager (#1350973)

The packaging has:

%if 0%{?fedora} > 22
Recommends:     NetworkManager
%else
Requires:       NetworkManager >= 0.9.9.0
%endif

so, on f23, dnf should treat it as a soft (and removable) dependency

Comment 7 Corinna Vinschen 2016-10-18 14:30:27 UTC
Right, dnf update --exclude='NetworkManager*' did the trick.

Sorry for the noise,
Corinna

Comment 8 Rex Dieter 2016-10-18 14:34:38 UTC
fwiw, --exclude=NetworkManager  should be enough in this case


Note You need to log in before you can comment on or make changes to this bug.