Bug 135223 - [PATCH] Don't use libuser entity objects for dict indexing
Summary: [PATCH] Don't use libuser entity objects for dict indexing
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-users
Version: rawhide
Hardware: All
OS: Linux
medium
low
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-10-10 22:05 UTC by Miloslav Trmač
Modified: 2007-11-30 22:10 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2004-10-10 22:50:51 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
s/]/Name]/ in a few places (1.21 KB, patch)
2004-10-10 22:06 UTC, Miloslav Trmač 		no flags Details | Diff
View All

Description Miloslav Trmač 2004-10-10 22:05:08 UTC 
Hello Nils,
While researching bug 113730 I have noticed that libuser entity
names are sometimes used instead of entity names for dict indexing;
the attached patch should clean that up (and also halve the number
of libuser entities needed, although that is unrelated to the
leaks reported in bug 113730).

Another note: the lookupUserByName and lookupGroupByName calls
quoted in the patch should not be necessary because 'user'
and 'group', respectively, already are libuser entities.
Comment 1 Miloslav Trmač 2004-10-10 22:06:37 UTC 
Created attachment 104993 [details]
s/]/Name]/ in a few places
Comment 2 Nils Philippsen 2004-10-10 22:50:51 UTC 
Thanks! I've added your changes and removed the excessive lookups of
user/groups as well, the fixes are in system-config-users-1.2.24-1. Do
you need these in a RHEL3 package as well?
Comment 3 Miloslav Trmač 2004-10-11 07:26:21 UTC 
From my point of view these are just code cleanups, unrelated
to bug 113730.
Note You need to log in before you can comment on or make changes to this bug.