RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1352765 - SLOF can not handle devices attached to an XHCI USB hub
Summary: SLOF can not handle devices attached to an XHCI USB hub
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: SLOF
Version: 7.3
Hardware: ppc64
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Thomas Huth
QA Contact: Virtualization Bugs
URL:
Whiteboard:
: 1369354 (view as bug list)
Depends On:
Blocks: 1354177 1366471
TreeView+ depends on / blocked
 
Reported: 2016-07-05 02:59 UTC by Min Deng
Modified: 2016-11-04 04:34 UTC (History)
8 users (show)

Fixed In Version: SLOF-20160223-6.gitdbbfda4.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1366471 (view as bug list)
Environment:
Last Closed: 2016-11-04 04:34:06 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2016:2355 0 normal SHIPPED_LIVE SLOF bug fix and enhancement update 2016-11-03 13:48:37 UTC

Description Min Deng 2016-07-05 02:59:37 UTC 
Description of problem:
USB keyboard invokes error message from HMP on rhel 6.8 BE guest
Version-Release number of selected component (if applicable):
kernel-3.10.0-456.el7
qemu-kvm-rhev-2.6.0-10.el7
SLOF-20160223-4.gitdbbfda4.el7
Guest kernel to: kernel-2.6.32-642.3.1.el6
How reproducible:
3 times
Steps to Reproduce:
1.boot up guest with the following cli
  /usr/libexec/qemu-kvm -name avocado-vt-vm1 -sandbox off -machine pseries -nodefaults -vga std -chardev socket,id=qmp_id_qmpmonitor1,path=/var/tmp/1,server,nowait -mon chardev=qmp_id_qmpmonitor1,mode=control -chardev socket,id=qmp_id_catch_monitor,path=/var/tmp/2,server,nowait -mon chardev=qmp_id_catch_monitor,mode=control -chardev socket,id=serial_id_serial0,path=/var/tmp/3,server,nowait -device spapr-vty,chardev=serial_id_serial0 -device nec-usb-xhci,id=controller1 -device usb-storage,id=storage,bus=controller1.0,drive=drive0,bootindex=0 -drive file=RHEL-Server-6.8-ppc64-virtio-scsi.qcow2,id=drive0,if=none,format=qcow2 -device spapr-vscsi,id=scsi0,reg=0x1000 -drive if=none,id=drive-scsi0-0-1-0,readonly=on,file=RHEL-6.8-20160414.0-Server-ppc64-dvd1.iso -device scsi-cd,bus=scsi0.0,drive=drive-scsi0-0-1-0,bootindex=1,id=scsi0-0-1-0 -m 8G -smp 8,maxcpus=8,cores=4,threads=1,sockets=2 -vnc :0 -enable-kvm -monitor stdio -uuid cbf8e8f5-6bb7-4d73-9581-d29b43aab22a  -device virtio-net-pci,mac=9a:d4:d5:d6:d7:d8,id=idkdMjSW,vectors=4,netdev=hostnet0,disable-legacy=off,disable-modern=on -netdev tap,id=hostnet0,vhost=on,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -qmp tcp:0:4444,server,nowait -device nec-usb-xhci,id=controller2 -device usb-hub,id=usbhub,bus=controller2.0,port=1 -device nec-usb-xhci,id=controller4 -device usb-hub,id=usbhub4,bus=controller4.0,port=1 -device usb-storage,id=storage1,port=1.1,drive=drive1 -drive file=data.qcow,id=drive1,if=none -device nec-usb-xhci,id=controller3 -device usb-hub,id=usbhub3,bus=controller3.0,port=1 -device usb-mouse,id=usbmouse,port=1.1 -device usb-kbd,id=usbkbd,port=1.2 -device usb-tablet,id=usbtablet,port=1.3

2.During SLOF stage and press "s"
3.

Actual results:
From HMP,
(qemu) usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full
usb-kbd: warning: key event queue full

Expected results:
No error info pops up

Additional info:
Comment 2 Laurent Vivier 2016-07-05 12:35:26 UTC 
USB peripherals are not detected because they are attached behind the USB Hub, if they are attached directly to the USB controller, they works fine:

-device usb-mouse,id=usbmouse,port=2  \
-device usb-kbd,id=usbkbd,port=3  \
-device usb-tablet,id=usbtablet,port=4 \

Moreover, once the system is booted, we can use it: linux correctly detects them.

So I think the bug is in SLOF, not in qemu-kvm-rhev.

I've checked the last upstream revision of SLOF (554eb9b) and this is not fixed.
Comment 3 Thomas Huth 2016-07-19 10:57:54 UTC 
Upstream confirmed that there is an issue in SLOF with devices attached to an XHCI USB hub: https://lists.ozlabs.org/pipermail/slof/2016-July/001153.html
Comment 4 David Gibson 2016-08-01 02:46:01 UTC 
Thomas do you think it's feasible to fix the SLOF bug in the RHEL 7.3 timeframe?
Comment 5 Thomas Huth 2016-08-01 06:50:04 UTC 
(In reply to David Gibson from comment #4)
> Thomas do you think it's feasible to fix the SLOF bug in the RHEL 7.3
> timeframe?

I had a quick look at it, and I think it's a little bit tough but doable ... I'll have a try...
Comment 6 Thomas Huth 2016-08-01 21:52:45 UTC 
I've now suggested a patch series upstream which fixes this issue:
https://lists.ozlabs.org/pipermail/slof/2016-August/001180.html
Comment 7 Miroslav Rezanina 2016-08-05 05:32:19 UTC 
Fix included in SLOF-20160223-6.gitdbbfda4.el7
Comment 9 Min Deng 2016-08-10 05:37:36 UTC 
(In reply to Miroslav Rezanina from comment #7)
> Fix included in SLOF-20160223-6.gitdbbfda4.el7

 Can you double check the issue ? why I still *can reproduce* the issue on build  SLOF-20160223-6.gitdbbfda4.el7,thanks a lot.
Comment 10 Thomas Huth 2016-08-10 07:35:59 UTC 
You mean the keyboard is still now working in your case? Or do you "just" still see the "usb-kbd: warning: key event queue full" messages? I hope keyboard is now working at the firmware and grub prompt and it's just about the "queue full" messages...

So I had another look. If you press "s" only some few times, it should work OK now and there should not be any of those messages. But if I constantly keep bashing "s" (you maybe should have mentioned that in the original description), I am also still seeing these messages. I guess that's because the firmware is at a point where it does not listen for USB keyboard input yet, so the key presses are queued up at the QEMU side and finally QEMU spills out this warning message when the queue is full. The warning should be pretty harmless (as long as the keyboard is working OK for you afterwards), but I'll try to have a closer look at this if we can avoid or at least ease it somehow...
Comment 11 Thomas Huth 2016-08-11 16:07:30 UTC 
I just noticed that there is an upstream commit that silences these mostly harmless warnings / turns them into debug trace-events instead:

http://git.qemu.org/?p=qemu.git;a=commitdiff;h=c80276b4206d534da

I'll backport that patch...
Comment 12 Thomas Huth 2016-08-12 05:20:42 UTC 
dengmin, since we already tracked the non-working USB keyboard issue in SLOF with this bug ticket here (so the component is "SLOF"), but the "key event queue full" warnings are generated by QEMU (i.e. a different component), I had to clone this ticket to track the fixes for the warning messages, see bug 1366471 for details now.

So I'm also setting the state of this ticket here back to ON_QA since the patches in SLOF have already been released. Please check whether the keyboard is working for you at the firmware and/or grub prompt with the configuration that you've mentioned in the patch description (i.e. with a keyboard behind a USB HUB), and if that's working (apart from the "key event queue full" messages), please mark this bug as verified. We'll take care of the "key event queue full" messages in bug 1366471 instead.
Comment 13 Min Deng 2016-08-15 06:56:36 UTC 
(In reply to Thomas Huth from comment #12)
> dengmin, since we already tracked the non-working USB keyboard issue in SLOF
> with this bug ticket here (so the component is "SLOF"), but the "key event
> queue full" warnings are generated by QEMU (i.e. a different component), I
> had to clone this ticket to track the fixes for the warning messages, see
> bug 1366471 for details now.
> 
> So I'm also setting the state of this ticket here back to ON_QA since the
> patches in SLOF have already been released. Please check whether the
> keyboard is working for you at the firmware and/or grub prompt with the
> configuration that you've mentioned in the patch description (i.e. with a
> keyboard behind a USB HUB), and if that's working (apart from the "key event
> queue full" messages), please mark this bug as verified. We'll take care of
> the "key event queue full" messages in bug 1366471 instead.

 As issue of the non-working USB keyboard has been fixed and error message will be traced in another bug 1366471.QE moved it to verified,thanks for developer's efforts.

Best regards
Min
Comment 14 Laurent Vivier 2016-08-25 11:11:27 UTC 
*** Bug 1369354 has been marked as a duplicate of this bug. ***
Comment 16 errata-xmlrpc 2016-11-04 04:34:06 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-2355.html
Note You need to log in before you can comment on or make changes to this bug.