Bug 1352765
| Summary: | SLOF can not handle devices attached to an XHCI USB hub | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Min Deng <mdeng> | |
| Component: | SLOF | Assignee: | Thomas Huth <thuth> | |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 7.3 | CC: | dgibson, knoel, lvivier, mrezanin, qzhang, thuth, virt-maint, xuma | |
| Target Milestone: | rc | |||
| Target Release: | --- | |||
| Hardware: | ppc64 | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | SLOF-20160223-6.gitdbbfda4.el7 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1366471 (view as bug list) | Environment: | ||
| Last Closed: | 2016-11-04 04:34:06 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1354177, 1366471 | |||
|
Description
Min Deng
2016-07-05 02:59:37 UTC
USB peripherals are not detected because they are attached behind the USB Hub, if they are attached directly to the USB controller, they works fine: -device usb-mouse,id=usbmouse,port=2 \ -device usb-kbd,id=usbkbd,port=3 \ -device usb-tablet,id=usbtablet,port=4 \ Moreover, once the system is booted, we can use it: linux correctly detects them. So I think the bug is in SLOF, not in qemu-kvm-rhev. I've checked the last upstream revision of SLOF (554eb9b) and this is not fixed. Upstream confirmed that there is an issue in SLOF with devices attached to an XHCI USB hub: https://lists.ozlabs.org/pipermail/slof/2016-July/001153.html Thomas do you think it's feasible to fix the SLOF bug in the RHEL 7.3 timeframe? (In reply to David Gibson from comment #4) > Thomas do you think it's feasible to fix the SLOF bug in the RHEL 7.3 > timeframe? I had a quick look at it, and I think it's a little bit tough but doable ... I'll have a try... I've now suggested a patch series upstream which fixes this issue: https://lists.ozlabs.org/pipermail/slof/2016-August/001180.html Fix included in SLOF-20160223-6.gitdbbfda4.el7 (In reply to Miroslav Rezanina from comment #7) > Fix included in SLOF-20160223-6.gitdbbfda4.el7 Can you double check the issue ? why I still *can reproduce* the issue on build SLOF-20160223-6.gitdbbfda4.el7,thanks a lot. You mean the keyboard is still now working in your case? Or do you "just" still see the "usb-kbd: warning: key event queue full" messages? I hope keyboard is now working at the firmware and grub prompt and it's just about the "queue full" messages... So I had another look. If you press "s" only some few times, it should work OK now and there should not be any of those messages. But if I constantly keep bashing "s" (you maybe should have mentioned that in the original description), I am also still seeing these messages. I guess that's because the firmware is at a point where it does not listen for USB keyboard input yet, so the key presses are queued up at the QEMU side and finally QEMU spills out this warning message when the queue is full. The warning should be pretty harmless (as long as the keyboard is working OK for you afterwards), but I'll try to have a closer look at this if we can avoid or at least ease it somehow... I just noticed that there is an upstream commit that silences these mostly harmless warnings / turns them into debug trace-events instead: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=c80276b4206d534da I'll backport that patch... dengmin, since we already tracked the non-working USB keyboard issue in SLOF with this bug ticket here (so the component is "SLOF"), but the "key event queue full" warnings are generated by QEMU (i.e. a different component), I had to clone this ticket to track the fixes for the warning messages, see bug 1366471 for details now. So I'm also setting the state of this ticket here back to ON_QA since the patches in SLOF have already been released. Please check whether the keyboard is working for you at the firmware and/or grub prompt with the configuration that you've mentioned in the patch description (i.e. with a keyboard behind a USB HUB), and if that's working (apart from the "key event queue full" messages), please mark this bug as verified. We'll take care of the "key event queue full" messages in bug 1366471 instead. (In reply to Thomas Huth from comment #12) > dengmin, since we already tracked the non-working USB keyboard issue in SLOF > with this bug ticket here (so the component is "SLOF"), but the "key event > queue full" warnings are generated by QEMU (i.e. a different component), I > had to clone this ticket to track the fixes for the warning messages, see > bug 1366471 for details now. > > So I'm also setting the state of this ticket here back to ON_QA since the > patches in SLOF have already been released. Please check whether the > keyboard is working for you at the firmware and/or grub prompt with the > configuration that you've mentioned in the patch description (i.e. with a > keyboard behind a USB HUB), and if that's working (apart from the "key event > queue full" messages), please mark this bug as verified. We'll take care of > the "key event queue full" messages in bug 1366471 instead. As issue of the non-working USB keyboard has been fixed and error message will be traced in another bug 1366471.QE moved it to verified,thanks for developer's efforts. Best regards Min *** Bug 1369354 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHEA-2016-2355.html |