Bug 1353134 - Reconstructing master should prefer shared domains over local domains
Summary: Reconstructing master should prefer shared domains over local domains
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.1.0-alpha
: 4.1.0.2
Assignee: Maor
QA Contact: Lilach Zitnitski
URL:
Whiteboard:
Depends On: 1302185
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-06 08:04 UTC by Allon Mureinik
Modified: 2017-02-01 14:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:34:19 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
amureini: devel_ack+
ratamir: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 60301 0 master MERGED core: Add a shared domains comparator when reconstruct. 2016-07-11 15:05:28 UTC

Description Allon Mureinik 2016-07-06 08:04:33 UTC 
Description of problem:
When electing a new master, reconstruction is attempted according to an ascending order of the last time a domain was used as a master (see org.ovirt.engine.core.bll.storage.domain.StorageDomainCommandBase#electNewMaster(boolean, boolean, boolean)).

In a DC that contains both shared and local domains (see bug 1302185), we should add a secondary criteria to prefer shared domains over local domains for resiliency considerations. 

Version-Release number of selected component (if applicable):
4.0
Comment 1 Sandro Bonazzola 2016-12-12 13:53:48 UTC 
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.
Comment 2 Lilach Zitnitski 2016-12-13 13:21:55 UTC 
--------------------------------------
Tested with the following code:
----------------------------------------
ovirt-engine-4.1.0-0.2.master.20161203231307.gitd7d920b.el7.centos.noarch

Tested with the following scenario:

Steps to Reproduce:
1. move the master storage domain to maintenance

Actual results:
shared storage domain becomes master, though there are other local storage domains in the DC (testes few times to make sure the shared is preferred) 

Expected results:

Moving to VERIFIED!
Note You need to log in before you can comment on or make changes to this bug.