Bug 1355759 - Tests in python-ryu
Summary: Tests in python-ryu
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-ryu
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Alan Pevec
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1424711 1454789
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-12 12:50 UTC by Lumír Balhar
Modified: 2017-07-27 20:47 UTC (History)
2 users (show)

Fixed In Version: python-ryu-4.15-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-27 20:24:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to enable tests (2.82 KB, patch)
2017-05-29 13:40 UTC, Lumír Balhar
no flags Details | Diff

Description Lumír Balhar 2016-07-12 12:50:12 UTC
Hello Arie.

I've found disabled tests in python-ryu package. Tinyrpc is not ported to Python3 yet but AFAIK tinyrpc is not necessary for tests in python-ryu package.

I've tried to run tests in virtual environments (for both pythons) without tinyrcp and only one test is skipped. The reason for skip isn't missing tinyrpc but newer eventlet which isn't supported for this test.

> test_4_call_large_binary (ryu.tests.unit.lib.test_rpc.Test_rpc)SKIP: doesn't work with eventlet 0.18 and later

I've tried it with these commands:

> ./run_tests.sh -N
> python ryu/tests/run_tests.py
> python2.7 ryu/tests/run_tests.py

What do you think about it? Is possible to enable tests in this package? Can I help you with something?

Thank you and have a nice day.
Lumir

Comment 1 Jan Kurik 2016-07-26 04:01:28 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 2 Arie Bregman 2016-08-02 12:18:48 UTC
Hi Lumír,

I didn't disable the tests, so I don't know why they originally were disabled or is it fine now to enable them.
I can only say that for me the tests are also passing

Haïkel - Do you know if we can enable the tests?

Comment 3 Alan Pevec 2017-01-12 22:46:54 UTC
I've renabled tests in ryu 4.9 update I needed to do for RDO Ocata deps:
https://github.com/rdo-common/python-ryu/commit/7681f080b0824a96ab4df44b7c545e7985c766ed
amoralej has also packaged tinyrpc: bug 1412605
But looks like tests were not really running: http://cbs.centos.org/kojifiles/packages/python-ryu/4.9/2.el7/data/logs/noarch/build.log
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK

I've not dug into what's going on in buildroot yet.


BTW Arie, please approve me in https://admin.fedoraproject.org/pkgdb/package/rpms/python-ryu/ so I can push this update to Fedora distgit.

Comment 4 Arie Bregman 2017-01-23 15:49:49 UTC
Done

Comment 5 Lumír Balhar 2017-05-23 12:15:11 UTC
Hello.

I am working on updating python-ryu to the newest version and enabling tests and I found some issues in other packages so I have to fix them in cooperation with maintainers first.

Have a nice day.

Lumír

Comment 6 Lumír Balhar 2017-05-23 14:50:08 UTC
Ryu has tons of tests which are using docker and the internet. I cannot find a way how to run only isolated subset of them so I created thread on ryu-devel mailing list: https://sourceforge.net/p/ryu/mailman/message/35855174/

Comment 7 Lumír Balhar 2017-05-29 13:40:32 UTC
Created attachment 1283226 [details]
Patch to enable tests

Hello.

Here is a patch for the current specfile which enable tests.

Tested in mock and Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19764083

Comment 8 Alan Pevec 2017-07-27 19:17:41 UTC
Forgot to update bz: patch from lbalhar pushed to Fedora master:
http://pkgs.fedoraproject.org/cgit/rpms/python-ryu.git/commit/?id=3ca20c73ed73193ee47f89d285d141bc1f48442f
but it failed building in Koji:
https://koji.fedoraproject.org/koji/buildinfo?buildID=899176

The same .spec did built in CentOS CBS Koji:
http://cbs.centos.org/koji/buildinfo?buildID=17279
...
Ran 121783 tests in 115.255s
OK (SKIP=2)

Fedora build logs are now gone, so I'll update Fedora master to the latest ryu 4.15 and try again.

Comment 9 Alan Pevec 2017-07-27 20:47:19 UTC
From python-ryu-4.15-1.fc27 build.log:
...
Ran 121822 tests in 93.751s
OK (SKIP=2)


Note You need to log in before you can comment on or make changes to this bug.