Bug 1356890 - RPM Bundling Fedora look and feel themes
Summary: RPM Bundling Fedora look and feel themes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: plasma-workspace
Version: rawhide
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: KDE SIG
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1388022 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-15 08:33 UTC by Nick Cross
Modified: 2017-09-27 05:25 UTC (History)
6 users (show)

Fixed In Version: plasma-workspace-5.10.5-2.fc26 plasma-workspace-5.10.5-1.fc25.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-28 16:20:10 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Nick Cross 2016-07-15 08:33:49 UTC
I have just updated to Fedora 24 and noticed that in the KDE Settings / Look-and-Feel module I have F24, Breeze and Breeze Dark that I can choose. I also have two broken modules - Fedora Twenty Three and Fedora Twenty Two.

The files appear to be in /usr/share/plasma/look-and-feel

For e.g. org.fedoraproject.fedora.twenty.four/metadata.desktop it is bundled inside f24-kde-theme

For org.fedoraproject.fedora.twenty.two/* and org.fedoraproject.fedora.twenty.three* they are bundled inside plasma-workspace.

Could they be unbundled (at least for F24 going forward) ?

Comment 1 Rex Dieter 2016-07-15 13:38:39 UTC
Not really, those are really simply consequences of how those previous fedora themes were designed and packaged.

There's really little point in going back and redesigning them now (and risk breaking anything).

Comment 2 Nick Cross 2016-07-15 14:10:40 UTC
Hmm. Reinstalling f22-kde-theme-22.3-7.fc24.noarch and f23-kde-theme resolved the broken modules. 

I would argue that the either the dependencies are broken (in that uninstalling f22-kde-theme/f23-kde-theme leads to broken modules) or plasma-workspace bundling is incorrect.

Comment 3 Rex Dieter 2016-07-15 14:24:35 UTC
Again, it is simply an unfortunate consequence of prior design choices.   And fixing it properly would be (too) invasive (in my opinion).

Comment 4 Nick Cross 2016-07-15 14:35:50 UTC
Fair enough. I have a workaround to prevent the broken modules.

Do you think fixing the packaging (or deps) for a future rawhide would be a problem?

Comment 5 Rex Dieter 2016-07-15 14:41:51 UTC
To clarify, I'm ok with fixing themes for future releases (ie, f22 can be fixed in f23+, and f23 can be fixed in f24+).  It's just not a priority for me, but I'd happily accept help/patches.

Now that I think about it more, fixing f22 should definitely be doable and easy... particularly since it's so close to EOL and we ship older versions of plasma there (so we don't have to worry about keeping plasma-workspace.spec compatible and mergeable).

f23 maybe trickier, but I'm open to any ideas you may have.

Comment 6 Nick Cross 2016-07-15 14:51:14 UTC
Good points! 

So as I understand F22 could be fixed with an update to strip the packaged theme after end of this month (?)

According to https://fedoraproject.org/wiki/Fedora_Release_Life_Cycle F23 will be maintained until 1 month after F25. Would it be easiest to simply wait till it goes EOL like F22 and fix it the same way (which I suppose would be for F26 development ? ) [ I don't know whether plasma-workspace would be always backported to F23 or not... ]

Comment 7 Rex Dieter 2016-07-15 14:55:20 UTC
That approach is acceptable to me.

Note: care probably should be taken to try to migrate users of the previous, but now obsolete and missing, theme to something else... probably the current default.

Comment 8 Nick Cross 2016-07-15 15:11:47 UTC
Sounds good to me :-)

And using the current default seems sensible as well.

Thanks!

Comment 9 Rex Dieter 2016-10-24 11:46:23 UTC
*** Bug 1388022 has been marked as a duplicate of this bug. ***

Comment 10 Nick Cross 2016-11-25 09:25:16 UTC
I have now updated to Fedora 25 and if I remove f22-kde-theme-22.3-7.fc24.noarch.rpm and f22-kde-theme-22.3-7.fc24.noarch then I am left again with broken theme modules because plasma-workspace-5.8.1-1.fc25 bundles 

/usr/share/plasma/look-and-feel/org.fedoraproject.fedora.twenty.two
and
/usr/share/plasma/look-and-feel/org.fedoraproject.fedora.twenty.three

Couldn't the /usr/share/plasma/look-and-feel/org.fedoraproject.fedora.twenty.two/* be bundled inside the f22 theme module therebye allowing for independent removal?

Comment 11 Nick Cross 2017-08-03 14:48:55 UTC
Upgraded to F26 and problem still exists.

Comment 12 Rex Dieter 2017-08-03 15:29:50 UTC
rebasing to rawhide/FutureFeature, to avoid risk of autoclosing this.

Comment 13 Fedora Update System 2017-08-25 12:13:23 UTC
bluedevil-5.10.5-1.fc26 breeze-gtk-5.10.5-1.fc26 grub2-breeze-theme-5.10.5-1.fc26 kactivitymanagerd-5.10.5-1.fc26 kde-cli-tools-5.10.5-1.fc26 kde-gtk-config-5.10.5-1.fc26 kdecoration-5.10.5-1.fc26 kdeplasma-addons-5.10.5-1.fc26 kgamma-5.10.5-1.fc26 khotkeys-5.10.5-1.fc26 kinfocenter-5.10.5-1.fc26 kmenuedit-5.10.5-1.fc26 kscreen-5.10.5-1.fc26 kscreenlocker-5.10.5-1.fc26 ksshaskpass-5.10.5-1.fc26 ksysguard-5.10.5-1.fc26 kwayland-integration-5.10.5-1.fc26 kwin-5.10.5-1.fc26 kwrited-5.10.5-1.fc26 libkscreen-qt5-5.10.5-1.fc26 libksysguard-5.10.5-1.fc26 pam-kwallet-5.10.5-1.fc26 plasma-breeze-5.10.5-1.fc26 plasma-desktop-5.10.5-1.fc26 plasma-discover-5.10.5-1.fc26 plasma-integration-5.10.5-1.fc26 plasma-milou-5.10.5-1.fc26 plasma-nm-5.10.5-1.fc26 plasma-oxygen-5.10.5-1.fc26 plasma-pa-5.10.5-1.fc26 plasma-sdk-5.10.5-1.fc26 plasma-systemsettings-5.10.5-1.fc26 plasma-user-manager-5.10.5-1.fc26 plasma-workspace-5.10.5-2.fc26 plasma-workspace-wallpapers-5.10.5-1.fc26 plymouth-theme-breeze-5.10.5-1.fc26 polkit-kde-5.10.5-1.fc26 powerdevil-5.10.5-1.fc26 sddm-kcm-5.10.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0fd3c6ca02

Comment 14 Fedora Update System 2017-08-25 13:38:06 UTC
bluedevil-5.10.5-1.fc25 breeze-gtk-5.10.5-1.fc25 grub2-breeze-theme-5.10.5-1.fc25 kactivitymanagerd-5.10.5-1.fc25 kde-cli-tools-5.10.5-1.fc25 kde-gtk-config-5.10.5-1.fc25 kdecoration-5.10.5-1.fc25 kdeplasma-addons-5.10.5-1.fc25 kf5-kirigami2-2.1.0-1.fc25 kgamma-5.10.5-1.fc25 khotkeys-5.10.5-1.fc25 kinfocenter-5.10.5-1.fc25 kmenuedit-5.10.5-1.fc25 kscreen-5.10.5-1.fc25 kscreenlocker-5.10.5-1.fc25 ksshaskpass-5.10.5-1.fc25 ksysguard-5.10.5-1.fc25 kwayland-integration-5.10.5-1.fc25 kwin-5.10.5-1.fc25 kwrited-5.10.5-1.fc25 libkscreen-qt5-5.10.5-1.fc25 libksysguard-5.10.5-1.fc25 pam-kwallet-5.10.5-1.fc25 plasma-breeze-5.10.5-1.fc25 plasma-desktop-5.10.5-1.fc25 plasma-discover-5.10.5-1.fc25 plasma-integration-5.10.5-1.fc25 plasma-milou-5.10.5-1.fc25 plasma-nm-5.10.5-1.fc25 plasma-oxygen-5.10.5-1.fc25 plasma-pa-5.10.5-1.fc25 plasma-sdk-5.10.5-1.fc25 plasma-systemsettings-5.10.5-1.fc25 plasma-user-manager-5.10.5-1.fc25 plasma-workspace-5.10.5-1.fc25.1 plasma-workspace-wallpapers-5.10.5-1.fc25 plymouth-theme-breeze-5.10.5-1.fc25 polkit-kde-5.10.5-1.fc25 powerdevil-5.10.5-1.fc25 sddm-kcm-5.10.5-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-73a2d209e4

Comment 15 Fedora Update System 2017-08-26 22:35:44 UTC
bluedevil-5.10.5-1.fc26, breeze-gtk-5.10.5-1.fc26, grub2-breeze-theme-5.10.5-1.fc26, kactivitymanagerd-5.10.5-1.fc26, kde-cli-tools-5.10.5-1.fc26, kde-gtk-config-5.10.5-1.fc26, kdecoration-5.10.5-1.fc26, kdeplasma-addons-5.10.5-1.fc26, kgamma-5.10.5-1.fc26, khotkeys-5.10.5-1.fc26, kinfocenter-5.10.5-1.fc26, kmenuedit-5.10.5-1.fc26, kscreen-5.10.5-1.fc26, kscreenlocker-5.10.5-1.fc26, ksshaskpass-5.10.5-1.fc26, ksysguard-5.10.5-1.fc26, kwayland-integration-5.10.5-1.fc26, kwin-5.10.5-1.fc26, kwrited-5.10.5-1.fc26, libkscreen-qt5-5.10.5-1.fc26, libksysguard-5.10.5-1.fc26, pam-kwallet-5.10.5-1.fc26, plasma-breeze-5.10.5-1.fc26, plasma-desktop-5.10.5-1.fc26, plasma-discover-5.10.5-1.fc26, plasma-integration-5.10.5-1.fc26, plasma-milou-5.10.5-1.fc26, plasma-nm-5.10.5-1.fc26, plasma-oxygen-5.10.5-1.fc26, plasma-pa-5.10.5-1.fc26, plasma-sdk-5.10.5-1.fc26, plasma-systemsettings-5.10.5-1.fc26, plasma-user-manager-5.10.5-1.fc26, plasma-workspace-5.10.5-2.fc26, plasma-workspace-wallpapers-5.10.5-1.fc26, plymouth-theme-breeze-5.10.5-1.fc26, polkit-kde-5.10.5-1.fc26, powerdevil-5.10.5-1.fc26, sddm-kcm-5.10.5-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0fd3c6ca02

Comment 16 Fedora Update System 2017-08-26 22:36:58 UTC
bluedevil-5.10.5-1.fc25, breeze-gtk-5.10.5-1.fc25, grub2-breeze-theme-5.10.5-1.fc25, kactivitymanagerd-5.10.5-1.fc25, kde-cli-tools-5.10.5-1.fc25, kde-gtk-config-5.10.5-1.fc25, kdecoration-5.10.5-1.fc25, kdeplasma-addons-5.10.5-1.fc25, kf5-kirigami2-2.1.0-1.fc25, kgamma-5.10.5-1.fc25, khotkeys-5.10.5-1.fc25, kinfocenter-5.10.5-1.fc25, kmenuedit-5.10.5-1.fc25, kscreen-5.10.5-1.fc25, kscreenlocker-5.10.5-1.fc25, ksshaskpass-5.10.5-1.fc25, ksysguard-5.10.5-1.fc25, kwayland-integration-5.10.5-1.fc25, kwin-5.10.5-1.fc25, kwrited-5.10.5-1.fc25, libkscreen-qt5-5.10.5-1.fc25, libksysguard-5.10.5-1.fc25, pam-kwallet-5.10.5-1.fc25, plasma-breeze-5.10.5-1.fc25, plasma-desktop-5.10.5-1.fc25, plasma-discover-5.10.5-1.fc25, plasma-integration-5.10.5-1.fc25, plasma-milou-5.10.5-1.fc25, plasma-nm-5.10.5-1.fc25, plasma-oxygen-5.10.5-1.fc25, plasma-pa-5.10.5-1.fc25, plasma-sdk-5.10.5-1.fc25, plasma-systemsettings-5.10.5-1.fc25, plasma-user-manager-5.10.5-1.fc25, plasma-workspace-5.10.5-1.fc25.1, plasma-workspace-wallpapers-5.10.5-1.fc25, plymouth-theme-breeze-5.10.5-1.fc25, polkit-kde-5.10.5-1.fc25, powerdevil-5.10.5-1.fc25, sddm-kcm-5.10.5-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-73a2d209e4

Comment 17 Fedora Update System 2017-08-28 16:20:10 UTC
bluedevil-5.10.5-1.fc26, breeze-gtk-5.10.5-1.fc26, grub2-breeze-theme-5.10.5-1.fc26, kactivitymanagerd-5.10.5-1.fc26, kde-cli-tools-5.10.5-1.fc26, kde-gtk-config-5.10.5-1.fc26, kdecoration-5.10.5-1.fc26, kdeplasma-addons-5.10.5-1.fc26, kgamma-5.10.5-1.fc26, khotkeys-5.10.5-1.fc26, kinfocenter-5.10.5-1.fc26, kmenuedit-5.10.5-1.fc26, kscreen-5.10.5-1.fc26, kscreenlocker-5.10.5-1.fc26, ksshaskpass-5.10.5-1.fc26, ksysguard-5.10.5-1.fc26, kwayland-integration-5.10.5-1.fc26, kwin-5.10.5-1.fc26, kwrited-5.10.5-1.fc26, libkscreen-qt5-5.10.5-1.fc26, libksysguard-5.10.5-1.fc26, pam-kwallet-5.10.5-1.fc26, plasma-breeze-5.10.5-1.fc26, plasma-desktop-5.10.5-1.fc26, plasma-discover-5.10.5-1.fc26, plasma-integration-5.10.5-1.fc26, plasma-milou-5.10.5-1.fc26, plasma-nm-5.10.5-1.fc26, plasma-oxygen-5.10.5-1.fc26, plasma-pa-5.10.5-1.fc26, plasma-sdk-5.10.5-1.fc26, plasma-systemsettings-5.10.5-1.fc26, plasma-user-manager-5.10.5-1.fc26, plasma-workspace-5.10.5-2.fc26, plasma-workspace-wallpapers-5.10.5-1.fc26, plymouth-theme-breeze-5.10.5-1.fc26, polkit-kde-5.10.5-1.fc26, powerdevil-5.10.5-1.fc26, sddm-kcm-5.10.5-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2017-09-27 05:25:42 UTC
bluedevil-5.10.5-1.fc25, breeze-gtk-5.10.5-1.fc25, grub2-breeze-theme-5.10.5-1.fc25, kactivitymanagerd-5.10.5-1.fc25, kde-cli-tools-5.10.5-1.fc25, kde-gtk-config-5.10.5-1.fc25, kdecoration-5.10.5-1.fc25, kdeplasma-addons-5.10.5-1.fc25, kf5-kirigami2-2.1.0-1.fc25, kgamma-5.10.5-1.fc25, khotkeys-5.10.5-1.fc25, kinfocenter-5.10.5-1.fc25, kmenuedit-5.10.5-1.fc25, kscreen-5.10.5-1.fc25, kscreenlocker-5.10.5-1.fc25, ksshaskpass-5.10.5-1.fc25, ksysguard-5.10.5-1.fc25, kwayland-integration-5.10.5-1.fc25, kwin-5.10.5-1.fc25, kwrited-5.10.5-1.fc25, libkscreen-qt5-5.10.5-1.fc25, libksysguard-5.10.5-1.fc25, pam-kwallet-5.10.5-1.fc25, plasma-breeze-5.10.5-1.fc25, plasma-desktop-5.10.5-1.fc25, plasma-discover-5.10.5-1.fc25, plasma-integration-5.10.5-1.fc25, plasma-milou-5.10.5-1.fc25, plasma-nm-5.10.5-1.fc25, plasma-oxygen-5.10.5-1.fc25, plasma-pa-5.10.5-1.fc25, plasma-sdk-5.10.5-1.fc25, plasma-systemsettings-5.10.5-1.fc25, plasma-user-manager-5.10.5-1.fc25, plasma-workspace-5.10.5-1.fc25.1, plasma-workspace-wallpapers-5.10.5-1.fc25, plymouth-theme-breeze-5.10.5-1.fc25, polkit-kde-5.10.5-1.fc25, powerdevil-5.10.5-1.fc25, sddm-kcm-5.10.5-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.