Bug 1361094 - Auto generate header files during Make
Summary: Auto generate header files during Make
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: eventsapi
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Aravinda VK
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1351589
TreeView+ depends on / blocked
 
Reported: 2016-07-28 10:42 UTC by Aravinda VK
Modified: 2017-03-27 18:18 UTC (History)
0 users

Fixed In Version: glusterfs-3.9.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-27 18:18:00 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Aravinda VK 2016-07-28 10:42:06 UTC
Description of problem:
To avoid running eventskeygen.py script every time when a new event is added, generate header files automatically during make.

Comment 1 Vijay Bellur 2016-07-28 10:45:38 UTC
REVIEW: http://review.gluster.org/15035 (eventsapi: Auto generate header files during make) posted (#1) for review on master by Aravinda VK (avishwan)

Comment 2 Vijay Bellur 2016-07-28 11:16:52 UTC
REVIEW: http://review.gluster.org/15035 (eventsapi: Auto generate header files during make) posted (#2) for review on master by Aravinda VK (avishwan)

Comment 3 Vijay Bellur 2016-07-28 11:58:34 UTC
REVIEW: http://review.gluster.org/15035 (eventsapi: Auto generate header files during make) posted (#3) for review on master by Aravinda VK (avishwan)

Comment 4 Vijay Bellur 2016-08-01 12:28:04 UTC
REVIEW: http://review.gluster.org/15035 (eventsapi: Auto generate header files during make) posted (#4) for review on master by Aravinda VK (avishwan)

Comment 5 Vijay Bellur 2016-08-02 05:50:03 UTC
COMMIT: http://review.gluster.org/15035 committed in master by Aravinda VK (avishwan) 
------
commit 4429e842236015b51be37f3351d8f8df640744f5
Author: Aravinda VK <avishwan>
Date:   Thu Jul 28 15:49:59 2016 +0530

    eventsapi: Auto generate header files during make
    
    $SRC/libglusterfs/src/eventtypes.h and $SRC/events/src/eventtypes.py are
    generated by running `python $SRC/events/eventskeygen.py`
    
    Header files generation step is added to make file itself, Now All new
    events should be added to only to $SRC/events/eventskeygen.py file.
    
    BUG: 1361094
    Change-Id: I384961ef2978ca2d0be37f288b39ac0d834bdf06
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/15035
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kotresh HR <khiremat>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 6 Shyamsundar 2017-03-27 18:18:00 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.