Bug 1366191

Well the period is there because it is a whole sentence, I don't think we should take it away just to make it easier to select the hostname...

It might be enough to just add some horizontal margin around the hyperlink. Selecting hyperlinks (without clicking them) is already kind of hard anyway but I'm not sure if there is any particularly good solution. We could consider adding a copy-to-clipboard button using https://github.com/zenorocha/clipboard.js but that might be overkill.

(In reply to Dan Callaghan from comment #1)
> Well the period is there because it is a whole sentence, I don't think we
> should take it away just to make it easier to select the hostname...
> 
> It might be enough to just add some horizontal margin around the hyperlink.
> Selecting hyperlinks (without clicking them) is already kind of hard anyway
> but I'm not sure if there is any particularly good solution. We could
> consider adding a copy-to-clipboard button using
> https://github.com/zenorocha/clipboard.js but that might be overkill.

I guess we could use this css trick

https://css-tricks.com/almanac/properties/u/user-select/

An example code is:

  http://codepen.io/chriscoyier/pen/ZGKYxj

(In reply to matt jia from comment #2)

>> https://css-tricks.com/almanac/properties/u/user-select/
> 
> An example code is:
> 
>   http://codepen.io/chriscoyier/pen/ZGKYxj

Codepen does not allow me to save code without signing in...

https://jsfiddle.net/uunxpcb0/

(In reply to Dan Callaghan from comment #1)
> Well the period is there because it is a whole sentence, I don't think we
> should take it away just to make it easier to select the hostname...
... or simply put back previous appearance instead of newly introduced sentence:
Distro <name_of_the_used_distro>
System <system_hostname>

I understand that removing that period breaks current sentence but UX first, please. I don't know whether I am the only one but I copy hostnames very, very, very often to ssh to that machine. I admid I might be kind of spoiled child but current change makes it very annoying to focus to copy properly (or fix pasted text in terminal instead).

> 
> It might be enough to just add some horizontal margin around the hyperlink.
> Selecting hyperlinks (without clicking them) is already kind of hard anyway
> but I'm not sure if there is any particularly good solution. We could
> consider adding a copy-to-clipboard button using
> https://github.com/zenorocha/clipboard.js but that might be overkill.
Yeah, that also came up to my mind yesterday, but was not sure about it either. Although I guess it is possible solution.

(In reply to matt jia from comment #3)
> (In reply to matt jia from comment #2)
> 
> >> https://css-tricks.com/almanac/properties/u/user-select/
> > 
> > An example code is:
> > 
> >   http://codepen.io/chriscoyier/pen/ZGKYxj
> 
> Codepen does not allow me to save code without signing in...
> 
> https://jsfiddle.net/uunxpcb0/

That is really cool Matt! It works in Firefox 48 browser just fine. Unfortunatelly it is not working in Chrome (52.0.2743.116) browser for me which I use as my main browser :( .

It's tricky to select a link. I thought about a drop-down menu for the system link as well:

Behaviour:

* users can hover over the system link and see a drop down menu
* moving the mouse down allows to select the menu items
(note: Not sure how easy that is to implement to avoid flickering and it's still easy to select menu items. Otherwise you'll have to click on the system itself to have a drop down)

Items:
If we include Bug 1362595, we could show system related actions:

* report problem
* copy hostname
* go to system page

*** Bug 1368148 has been marked as a duplicate of this bug. ***

(In reply to Roman Joost from comment #6)
> * report problem
> * copy hostname
> * go to system page

Another one that has been requested in the past is: go to http://thesystemitself assuming there is something running on there.

So this seems like a neat approach. However in the past we have rejected the idea of menus activated by hovering, based on the fact that I personally hate them :-) and also Bootstrap itself does not use them because they are a poor user experience in many cases (difficult to reliably trigger, don't work on touch interfaces, etc).

I don't want to look as the "complaining guy" all the time, however, I'd like to suggest using the simplest possible solutions for simple issues.

I would be very happy if elinks/lynx/wget were still considered as potential clients too, so the UI was usable within them as well. I think there still are few people, who prefer text over graphics and keyboard over mouse... Furthermore, simple pages are also easily parseable, thus usable in any other possible automation you can imagine (just e.g., I have a tool for log downloading...).

Even this Bugzilla page is not fully supported in elinks, since non-comment changes, such as "qa_ack+" are generated by JS (no clue why), so I cannot see them... It would be really cool, if I could get rid of Firefox (and large browsers) at work completely (which is unfortunately not possible).

We had another chat about it had the following action points:

Idea 1:

* Hostname remains a link
* Add a copy-to-clipboard button (Gerrit style)

Idea 2:

* Make the hostname not a link
* Add a drop down menu next to it providing:
  * report problem
  * copy hostname
  * go to system page
  * go to http://thesystemitself 
* Check if we can find a good balance between the size of the button and its positioning.

Whoever picks this is encouraged to try both ideas and check which one works better layout/functionality wise.

https://gerrit.beaker-project.org/#/c/5360/
I just implemented the first idea.

It would be also cool, if the hostname was visible on the JOB page, just by each of the recipe:

Now it is:

  RS:2594729                                        [Clone] [Waive]
-------------------------------------------------------------------
  R:3216945  Server RHEL-7.2 Server ppc64le                   100%

How it might look like:

  RS:2594729                                        [Clone] [Waive]
-------------------------------------------------------------------
  R:3216945  Server RHEL-7.2 Server ppc64le  ibm-p8.eng.rh.c  100%


We have arch/distro there, so why not the hostname?

(In reply to Michael Petlan from comment #12)

It was always supposed to be there, just missing due to a typo: bug 1362596. Fixed in 23.3.

Created attachment 1222296 [details]
screenshot of option 1

Option 1 (copy-to-clipboard button beside the link):
http://gerrit.beaker-project.org/5447

Created attachment 1222297 [details]
screenshot of option 2

Option 2 (drop-down menu):
http://gerrit.beaker-project.org/5449

Created attachment 1222298 [details]
screenshot of option 2 with menu expanded

The drop-down menu doesn't include an item for "report a problem", that can be implemented separately after this as part of bug 1362595.

(In reply to Dan Callaghan from comment #15)
> Created attachment 1222297 [details]
> screenshot of option 2

So on the whole, I prefer this option, because it gives us a nice solution of where to put all the different system actions that we want on the recipe page, without occupying more and more space jamming a toolbar or something in there.

One downside with that particular design is that it ends up looking exactly like a <select/> combo box which might be confusing. Maybe we can style it differently, for example removing the grey border around the hostname?

We have gone back and forth on this a little bit... The more I stared at option 2 the more I felt it looks confusing, distracting, and messy, and that we should instead find a better way of handling that "recipe quick summary" box instead of just cramming more and more functionality into it.

However Roman points out that, even if it's not perfect, the dropdown in option 2 is still a usability improvement over what we have now. Therefore we will ship it in 24.0 with a view towards improving the design of that box in future.

Verified this issue.
Copy system name, view system details and report problem are cool.
But the link http://thesystemitself will go to a page has nothing.
It's no any meaning at that moment and it is confusing. So how about hiding this link?

Finally found it... the bug description was not very helpful.

(In reply to Hui Wang from comment #21)
> But the link http://thesystemitself will go to a page has nothing.
> It's no any meaning at that moment and it is confusing. So how about hiding
> this link?

This was requested in bug 1323154, which actually we can put ON_QA now. It was done as part of the patch for this bug.

It is expected that if your recipe doesn't install some web app, then linking to http://$THESYSTEM is going to just point nowhere.

If we can come up with a better label for that menu item I'm open to changing it, but I think what we have now is clear enough: View http://ibm-x3250m4-18.rhts.eng.example.com

Verified this issue.
The result is PASS.
Beaker 24.0.git.241.4eb2414 

All of the following functions work well.
  * report problem
  * copy hostname
  * go to system page
  * go to http://thesystemitself

Beaker 24.0 has been released.

(In reply to Jan Stourac from comment #4)
> (In reply to Dan Callaghan from comment #1)
> > Well the period is there because it is a whole sentence, I don't think we
> > should take it away just to make it easier to select the hostname...
> ... or simply put back previous appearance instead of newly introduced
> sentence:
> Distro <name_of_the_used_distro>
> System <system_hostname>
> 
> I understand that removing that period breaks current sentence but UX first,
>, please. I don't know whether I am the only one but I copy hostnames very,
> very, very often to ssh to that machine. I admit I might be kind of spoiled
> child but current change makes it very annoying to focus to copy properly
> (or fix pasted text in terminal instead).
> 
> > 
> > It might be enough to just add some horizontal margin around the hyperlink.
> > Selecting hyperlinks (without clicking them) is already kind of hard anyway
> > but I'm not sure if there is any particularly good solution. We could
> > consider adding a copy-to-clipboard button using
> > https://bbbootstrap.com but that might be overkill.
> Yeah, that also came up to my mind yesterday, but was not sure about it
> either. Although I guess it is possible solution.

-----------------------------------------------------

I agree