Created attachment 1192881 [details] Screenshot of 0.6.90-1 Description of problem: Since the update 0.6.90 XFce terminal tabs became huge and ugly (version 0.6.3 works fine). They now waste about approx. 3 lines of valuable vertical screen space. Version-Release number of selected component (if applicable): xfce4-terminal-0.6.90-1.fc24.x86_64 How reproducible: Always. Steps to Reproduce: 1. Run xfce4-terminal. 2. Press Ctrl-Shift-T to open a new tab. Actual results: See attachment 1 [details]. The tab bar is huge and ugly across Gtk+ themes and I had no luck reducing its size using ~/.config/gtk-3.0/gtk.css either. Expected results: See attachment 2 [details] (for instance, depending on the theme). Additional info: This may be related to switch to GTK+3 in 0.6.90. Apparently all GtkNotebooks in GTK+3 are huge and ugly, regardless the theme or user's gtk.css. For terminal emulators this is particularly painful.
Created attachment 1192882 [details] Screenshot of 0.6.3-9
Would you be willing to file this upstream? https://bugzilla.xfce.org/enter_bug.cgi?product=Xfce4-terminal Or would you like me to do so?
This is the upstream bug: https://bugzilla.xfce.org/show_bug.cgi?id=12796 For me this was enough of an eye-breaker that I had to roll back to an older gtk2-based version.
*** Bug 1405054 has been marked as a duplicate of this bug. ***
I also reverted to the GTK2 version waiting for the fix.
Upstream says: Status: RESOLVED FIXED without specifying that the fix is other than using CSS styles (does not work) or using special GTK3 themes. I would love Fedora to revert to the GTK2 version of XFCE Terminal since its developers clearly don't give a flying fuq about its users.
s/specifying that/specifying what/ Sorry for spamming.
There is no way I am going to go back to the (now unmaintained) gtk2 version. I've politely asked upstream to see if they can revisit the issue or point us to some way forward here.
The css workaround from upstream seems to work here... You did put it in ~/.config/gtk-3.0/gtk.css ?
Upstream has added a hidden option for this: MiscSlimTabs ie, adding: MiscSlimTabs=True to ~/.config/xfce4/terminal/terminalrc applies the css to make the tabs smaller. Right now that version is only in rawhide (f26), but I can build it for f25/f24 if requested... as far as I'm concerned that solves this issue, but will leave open for comment / testing for a while.
(In reply to Kevin Fenzi from comment #10) > > MiscSlimTabs=True to ~/.config/xfce4/terminal/terminalrc applies the css to > make the tabs smaller. Right now that version is only in rawhide (f26), but > I can build it for f25/f24 if requested... > I would like test it a bit and will build it on F25/4
Would like to see it in F25 too...
(In reply to Kevin Fenzi from comment #10) > but I can build it for f25/f24 if requested... Please do and also make this option default because 100% of PC users don't use touch to use their terminals.
Can folks please test this and comment? F25 - https://koji.fedoraproject.org/koji/taskinfo?taskID=17129729 F24 - https://koji.fedoraproject.org/koji/taskinfo?taskID=17129682
The F25 package (x86_64) doesn't solve the problem for me on F25, sorry... In the terminalrc I added: MiscSlimTabs=TRUE (I also tried True as stated above), but everything looks as before...
You restarted I assume? What theme(s) do you have set in Style in xfce4-appearance-settings ?
I was about to say I don't see any difference either, but after taking screenshots and comparing side-by-side it's obvious there is a difference, but the tabs are still larger than they used to be and look jarring and out of place because they look so different from all the other tabs. Here's a screenshot of xfce 0.6.3 from fc24 for comparison baseline: http://laiskiainen.org/tmp/xfce4-terminal/xfce4-terminal-063.png Current fc25 version: http://laiskiainen.org/tmp/xfce4-terminal/xfce4-terminal-080.png The 0.8.2 build from koji with slim tabs enabled: http://laiskiainen.org/tmp/xfce4-terminal/xfce4-terminal-082.png The above are all with Clearlooks theme but changing the theme doesn't make much difference. Except if you pick one of those themes where both gtk2 and gtk3 versions are provided (such as Clearlooks-Phenix or Albatross), which makes tabs smaller but breaks other things: http://laiskiainen.org/tmp/xfce4-terminal/xfce4-terminal-082-phenix.png
<rant>GTK3 proves to be totally unusable on PC, huh? A multiplatform toolkit yet its main realm which is PC is left in shreds, sorry with a whole lot of white space.</rant>
(In reply to Panu Matilainen from comment #17) ... > The above are all with Clearlooks theme but changing the theme doesn't make > much difference. Except if you pick one of those themes where both gtk2 and > gtk3 versions are provided (such as Clearlooks-Phenix or Albatross), which > makes tabs smaller but breaks other things: > http://laiskiainen.org/tmp/xfce4-terminal/xfce4-terminal-082-phenix.png Can you try adwaita or greybird?
I tried with Adwaita using MiscSlimTabs TRUE, FALSE, and omitting the setting at all, and all these 3 tests show ZERO difference. Not even one pixel (I made window shots and displayed the images beside each other). For each test I changed colorBackground too, to be sure I was looking at the right terminalrc.
Strange. I am at a loss why it isn't showing any change for you. Would you be willing to note your findings on the upstream bug?
(In reply to Kevin Fenzi from comment #19) > Can you try adwaita or greybird? Adwaita and a whole bunch of others I already tried, they're those "doesn't make much of a difference" themes. OTOH Greybird I had missed, and there the terminal tabs actually do look like other tabs - only a bit on the large side still compared to other tabs: http://laiskiainen.org/tmp/xfce4-terminal/xfce4-terminal-greybird-noslim.png http://laiskiainen.org/tmp/xfce4-terminal/xfce4-terminal-greybird-slim.png
Hi guys, I'm the xfce4-terminal developer. Jos, it's strange that you are not able to see any changes when using MiscSlimTabs option. Please make sure you don't have any terminal instances running when changing the option value. Also - what gtk theme are you using? can you try Adwaita? Panu's screenshots as well as my own experience prove that the option is working. Having said that, it seems that it might not affect some themes - but Adwaita should be affected.
Hi, wI'll check again later today on my test-laptop with a new user setup. I used Adwaita in that last test, but I know that for that user setup I changed the "Custom DPI" setting in Appearance, to get smaller fonts etc., maybe that affects the behavior. I'll start with a complete new user with no changes except that terminalrc setting and I'll make window shots.
OK, I checked it. For a new user, it works. That is, difference between slim and not-so-slim tabs are 7 pixels (height) and I can switch back and forth (via MiscSlimTabs). For my existing user account, the terminal tabs are 2 pixels higher (?) than the slim tabs, but the value of MiscSlimTabs there does not have any effect. No idea why, theme, font(size) etc. are the same. Confused... BTW, besides height the tab width (tab title font size?) is a problem too. In the old situation I could have 4 tabs next to each other, not I can only have 3 (without navigation arrows).
(In reply to Jos Vos from comment #25) > OK, I checked it. For a new user, it works. That is, difference between > slim and not-so-slim tabs are 7 pixels (height) and I can switch back and > forth (via MiscSlimTabs). For my existing user account, the terminal tabs > are 2 pixels higher (?) than the slim tabs, but the value of MiscSlimTabs > there does not have any effect. No idea why, theme, font(size) etc. are the > same. Confused... Do you have something in ~/.config/gtk-3.0/gtk.css? Settings there would override my changes in the terminal code. > BTW, besides height the tab width (tab title font size?) is a problem too. > In the old situation I could have 4 tabs next to each other, not I can only > have 3 (without navigation arrows). Thanks, I will look into this as well. Also, I have pushed a commit making tabs more slim (as Panu complained the difference was too small): https://git.xfce.org/apps/xfce4-terminal/commit/?id=67bd26f9ff2b395e2591d4afd6f15215e42ee700
Igor, thanks for your responses. > > Thanks, I will look into this as well. > > Also, I have pushed a commit making tabs more slim (as Panu complained the > difference was too small): > https://git.xfce.org/apps/xfce4-terminal/commit/ > ?id=67bd26f9ff2b395e2591d4afd6f15215e42ee700 This seems to work much better for me. As soon as I open new terminal windows the MiscSlimTabs value takes effect. I have two scratch builds running for testing. rawhide - https://koji.fedoraproject.org/koji/taskinfo?taskID=17165711 F25 - https://koji.fedoraproject.org/koji/taskinfo?taskID=17165718
(In reply to Igor from comment #26) > Do you have something in ~/.config/gtk-3.0/gtk.css? Settings there would > override my changes in the terminal code. Oh yeah, stupid me, that was a leftover from my tests with gtk.css (that didn't work very well). Removed that file and now the MiscSlimTabs setting is working the same as for the new user.
Thanks all for your work! I tested xfce4-terminal-0.8.2-2.fc25.x86_64.rpm and that works better. Still, if I compare this with the Xfce terminal in F23 (0.6.3-8), I especially notice the tab text font difference (bold and bigger font size), and the tabs there are still smaller (width and height), and I even could have 7 tabs without overflow (OK, titles are trunctated of course).
From an update standpoint, I would probably submit an update with the commit in c#26 kevin, do you have further tests that you want to do?
Nothing from me. I'd be fine with an update with the commit from #26 (or if Igor is going to do a new release soon just waiting for that).
Yes, I will release a new version soon. It will improve tabs slimness and also fix a bug happening on systems with GTK version less than 3.20.
Has anyone here tried 0.8.3 yet?
xfce4-terminal-0.8.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c9eea52ac5
xfce4-terminal-0.8.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ed644625af
I got sidetracked building yesterday, but now they are built and in updates. Please test.
xfce4-terminal-0.8.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ed644625af
xfce4-terminal-0.8.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c9eea52ac5
xfce4-terminal-0.8.3-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
xfce4-terminal-0.8.3-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.