Bug 1369530 - protocol/server: readlink rsp xdr failed while readlink got an error
Summary: protocol/server: readlink rsp xdr failed while readlink got an error
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: protocol
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ryan Ding
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1370172
TreeView+ depends on / blocked
 
Reported: 2016-08-23 16:40 UTC by Ryan Ding
Modified: 2017-03-27 18:19 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.9.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1370172 (view as bug list)
Environment:
Last Closed: 2017-03-27 18:19:27 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ryan Ding 2016-08-23 16:40:24 UTC
Description of problem:

in function server_readlink_cbk, if readlink got a file system error (like ENOENT, etc.), rsp.path will leave to be NULL. and this will lead a xdr error in xdr_gfs3_readlink_rsp. original errno is lost.

Comment 1 Worker Ant 2016-08-23 16:44:11 UTC
REVIEW: http://review.gluster.org/15299 (protocol/server: readlink rsp xdr will fail while readlink got an error) posted (#1) for review on master by Anonymous Coward

Comment 2 Worker Ant 2016-08-25 02:06:28 UTC
COMMIT: http://review.gluster.org/15299 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit c70f4b3af619bcdd08d57147a4ed582bdad98084
Author: Ryan Ding <ryan.ding>
Date:   Wed Aug 24 00:41:13 2016 +0800

    protocol/server: readlink rsp xdr will fail while readlink got an error
    
    set gfs3_readlink_rsp.path with an empty string while error happen, to
    make xdr_gfs3_readlink_rsp happy. otherwise the original errno will be
    lost, and return an rpc internal errno instead.
    
    Change-Id: I36655b66df8b9f164e5bd21eb17244722c2f5a52
    BUG: 1369530
    Signed-off-by: Ryan Ding <ryan.ding>
    Reviewed-on: http://review.gluster.org/15299
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Worker Ant 2016-08-25 03:23:49 UTC
REVIEW: http://review.gluster.org/15312 (protocol/server: readlink rsp xdr will fail while readlink got an error) posted (#1) for review on release-3.8 by Ryan Ding (ryan.ding)

Comment 4 Shyamsundar 2017-03-27 18:19:27 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.