Bug 1370172 - protocol/server: readlink rsp xdr failed while readlink got an error
Summary: protocol/server: readlink rsp xdr failed while readlink got an error
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: protocol
Version: 3.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ryan Ding
QA Contact:
URL:
Whiteboard:
Depends On: 1369530
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-25 12:48 UTC by Niels de Vos
Modified: 2016-09-16 18:28 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1369530
Environment:
Last Closed: 2016-09-16 18:28:22 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2016-08-25 12:48:47 UTC
+++ This bug was initially created as a clone of Bug #1369530 +++

Description of problem:

in function server_readlink_cbk, if readlink got a file system error (like ENOENT, etc.), rsp.path will leave to be NULL. and this will lead a xdr error in xdr_gfs3_readlink_rsp. original errno is lost.

--- Additional comment from Worker Ant on 2016-08-23 18:44:11 CEST ---

REVIEW: http://review.gluster.org/15299 (protocol/server: readlink rsp xdr will fail while readlink got an error) posted (#1) for review on master by Anonymous Coward

--- Additional comment from Worker Ant on 2016-08-25 04:06:28 CEST ---

COMMIT: http://review.gluster.org/15299 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit c70f4b3af619bcdd08d57147a4ed582bdad98084
Author: Ryan Ding <ryan.ding>
Date:   Wed Aug 24 00:41:13 2016 +0800

    protocol/server: readlink rsp xdr will fail while readlink got an error
    
    set gfs3_readlink_rsp.path with an empty string while error happen, to
    make xdr_gfs3_readlink_rsp happy. otherwise the original errno will be
    lost, and return an rpc internal errno instead.
    
    Change-Id: I36655b66df8b9f164e5bd21eb17244722c2f5a52
    BUG: 1369530
    Signed-off-by: Ryan Ding <ryan.ding>
    Reviewed-on: http://review.gluster.org/15299
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

--- Additional comment from Worker Ant on 2016-08-25 05:23:49 CEST ---

REVIEW: http://review.gluster.org/15312 (protocol/server: readlink rsp xdr will fail while readlink got an error) posted (#1) for review on release-3.8 by Ryan Ding (ryan.ding)

Comment 1 Worker Ant 2016-08-25 12:49:24 UTC
REVIEW: http://review.gluster.org/15312 (protocol/server: readlink rsp xdr will fail while readlink got an error) posted (#2) for review on release-3.8 by Ryan Ding (ryan.ding)

Comment 2 Worker Ant 2016-09-01 15:20:45 UTC
COMMIT: http://review.gluster.org/15312 committed in release-3.8 by Pranith Kumar Karampuri (pkarampu) 
------
commit ffc7d44095ba23c761a034fb713cae05df135f2b
Author: Ryan Ding <ryan.ding>
Date:   Wed Aug 24 00:41:13 2016 +0800

    protocol/server: readlink rsp xdr will fail while readlink got an error
    
    set gfs3_readlink_rsp.path with an empty string while error happen, to
    make xdr_gfs3_readlink_rsp happy. otherwise the original errno will be
    lost, and return an rpc internal errno instead.
    
    Change-Id: I36655b66df8b9f164e5bd21eb17244722c2f5a52
    BUG: 1370172
    Signed-off-by: Ryan Ding <ryan.ding>
    Reviewed-on: http://review.gluster.org/15312
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>

Comment 3 Niels de Vos 2016-09-12 05:39:36 UTC
All 3.8.x bugs are now reported against version 3.8 (without .x). For more information, see http://www.gluster.org/pipermail/gluster-devel/2016-September/050859.html

Comment 4 Niels de Vos 2016-09-16 18:28:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.4, please open a new bug report.

glusterfs-3.8.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/announce/2016-September/000060.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.