Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1374619

Summary: Engine generates duplicated mac addresses
Product: [oVirt] ovirt-engine Reporter: Pavel Zhukov <pzhukov>
Component: BLL.NetworkAssignee: Martin Mucha <mmucha>
Status: CLOSED DUPLICATE QA Contact: Meni Yakove <myakove>
Severity: medium Docs Contact:
Priority: high    
Version: 4.0.3CC: bugs, danken, pzhukov, ylavi
Target Milestone: ovirt-4.1.0-alphaFlags: rule-engine: ovirt-4.1+
rule-engine: planning_ack+
danken: devel_ack+
myakove: testing_ack+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-05 09:17:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine logs none

Description Pavel Zhukov 2016-09-09 08:45:24 UTC
Created attachment 1199335 [details]
engine logs

Description of problem:
While adding second NIC to the banch of vm with following code:

vms = api.vms.list(name)

for vm in vms:
    if len(vm.nics.list()) == 1:
        print("Adding second NIC to vm %s") % (vm.name)
        nic = params.NIC(name='eth1', network = params.Network(name='rhevm'), interface='virtio')
        vm.nics.add(nic)

At some point NIC is not able to be added with conflict message.


Version-Release number of selected component (if applicable):
ovirt-engine-4.0.3-0.1.el7ev.noarch

How reproducible:
100%



Actual results:
Traceback (most recent call last):
  File "./addnic.py", line 26, in <module>
    vm.nics.add(nic)
  File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/brokers.py", line 33397, in add
    headers={"Correlation-Id":correlation_id, "Expect":expect}
  File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/proxy.py", line 79, in add
    return self.request('POST', url, body, headers, cls=cls)
  File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/proxy.py", line 122, in request
    persistent_auth=self.__persistent_auth
  File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/connectionspool.py", line 79, in do_request
    persistent_auth)
  File "/usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/connectionspool.py", line 156, in __do_request
    raise errors.RequestError(response_code, response_reason, response_body)
ovirtsdk.infrastructure.errors.RequestError: 
status: 409
reason: Conflict
detail: MAC Address is already in use.

Expected results:
Successfully added NIC with randomly generated MAC

Additional info:

Comment 1 Dan Kenigsberg 2016-09-09 11:11:06 UTC
How many VMs and vNICs do you have installed?
How many and how big are your MAC pools?
Is it a regression, or does ovirt-3.6 behave the same?

Can mmucha access to your db ?

Comment 2 Pavel Zhukov 2016-09-12 09:23:00 UTC
(In reply to Dan Kenigsberg from comment #1)
> How many VMs and vNICs do you have installed?
256 VMs in all DCs atm

> How many and how big are your MAC pools?
engine=# select * from mac_pool_ranges;
             mac_pool_id              |     from_mac      |      to_mac       
--------------------------------------+-------------------+-------------------
 00000023-0023-0023-0023-0000000000e7 | 00:1a:4a:16:13:02 | 00:1a:4a:16:13:fe
(1 row)

# select count(*) from vm_interface;
 count 
-------
   273
(1 row)

engine=# select count(mac_addr) from vm_interface;
 count 
-------
   228
(1 row)

engine=# select count(*) from vm_interface where mac_addr like '00:1a:4a:16:13%';
 count 
-------
   180

So looks like we're not evem close to the limit (not all vms have mac_addresses assigned from the pool). 

> Is it a regression, or does ovirt-3.6 behave the same?
> 
> Can mmucha access to your db ?
No problem. His desk is next to mine.

Comment 3 Martin Mucha 2016-11-30 09:54:01 UTC
probably solved in bug: https://bugzilla.redhat.com/show_bug.cgi?id=1395462

Comment 4 Dan Kenigsberg 2016-12-05 09:17:29 UTC

*** This bug has been marked as a duplicate of bug 1395462 ***