Bug 1395462 - [Vm Pool] VMs are created with duplicate MAC addresses
Summary: [Vm Pool] VMs are created with duplicate MAC addresses
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.0.4
Hardware: x86_64
OS: Linux
high
high
Target Milestone: ovirt-4.1.0-beta
: ---
Assignee: Martin Mucha
QA Contact: sefi litmanovich
URL:
Whiteboard:
: 1374619 (view as bug list)
Depends On:
Blocks: 1400043
TreeView+ depends on / blocked
 
Reported: 2016-11-16 00:24 UTC by Germano Veit Michel
Modified: 2021-08-30 11:47 UTC (History)
16 users (show)

Fixed In Version: 4.1.0-3
Doc Type: Bug Fix
Doc Text:
This bug fixes several issues with insufficient synchronization when accessing MAC Pools, which may cause the Manager to allocate the same MAC address to two different virtual machines.
Clone Of:
: 1400043 (view as bug list)
Environment:
Last Closed: 2017-04-25 00:49:57 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 2775081 0 None None None 2016-11-22 05:05:19 UTC
Red Hat Product Errata RHEA-2017:0997 0 normal SHIPPED_LIVE Red Hat Virtualization Manager (ovirt-engine) 4.1 GA 2017-04-18 20:11:26 UTC
oVirt gerrit 67101 0 None MERGED core: Insufficient thread synchronization 2020-10-08 08:53:53 UTC
oVirt gerrit 67138 0 ovirt-engine-4.0 ABANDONED core: add ID property to MacPool. 2020-10-08 08:53:53 UTC
oVirt gerrit 67139 0 ovirt-engine-4.0 ABANDONED core: added logging message to MacPool 2020-10-08 08:53:53 UTC
oVirt gerrit 67245 0 None MERGED core: missing overriding method. 2020-10-08 08:53:53 UTC
oVirt gerrit 67246 0 None MERGED core: locking proxy must lock pool and not decorator. 2020-10-08 08:53:53 UTC
oVirt gerrit 67247 0 master ABANDONED core: added more integration-like test for MacPool 2020-10-08 08:53:53 UTC
oVirt gerrit 74053 0 ovirt-engine-4.1 MERGED core: add ID property to MacPool. 2020-10-08 08:53:54 UTC
oVirt gerrit 75063 0 ovirt-engine-4.1 MERGED core: added logging message to MacPool 2020-10-08 08:53:54 UTC

Description Germano Veit Michel 2016-11-16 00:24:33 UTC
Description of problem:

When additional VmPools are created, many of the VMs from the new VmPool end up with the same MAC address of existing VMs from other Pools which were created many days ago.

When these VMs with duplicate MACs are started, they lose the tap device as the MAC is already in use. See:

2016-11-09 03:00:10,787 WARN  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (org.ovirt.thread.pool-6-thread-30) [699b0a6d] Correlation ID: null, Call Stack: null, Custom Event ID: -1, Message: Network Interface nic1 has MAC address 00:1a:4a:16:01:6c which is in use, therefore it is being unplugged from VM AAA_03.

So the VM ends up without Networking, rendering it completely useless.

Here is an example of two VMs from different Pools and created in completely different points in time:

2016-10-24 14:31:35.292+08 | VM AAA_03 creation has been completed.
2016-10-24 14:32:19.741+08 | VM Pool AAA (containing 20 VMs) was created by <removed>

2016-10-31 16:16:35.77+08  | VM BBB_01 creation has been completed.
2016-10-31 16:16:37.132+08 | VM Pool BBB (containing 10 VMs) was created by <removed>

Result:

     vm_name      |     mac_addr      
------------------+-------------------
 AAA_03           | 00:1a:4a:16:01:6c 
 BBB_013          | 00:1a:4a:16:01:6c 
 

Deleting all Pools and creating them again seems to yield the same result.

Version-Release number of selected component (if applicable):
ovirt-engine-4.0.4.4-0.1.el7ev.noarch

How reproducible:
* 0% after many tries
* Happens constantly on customer site

Actual results:
Duplicate MACs

Expected results:
No Duplicate MACs

Additional info:
* Allow Duplicate Macs option is disabled
* Using default MAC pool, no extra configurations
* Templates which these VMs are based on were imported and have MACs out of the MacPool range
 (Does not seem related as I tried this as well)
* Pools are created by different users (aaa)
 (Does not seem related as I tried this as well)
* It's always 2 VMs with the same MAC, never more than 2.

Comment 7 Dan Kenigsberg 2016-12-05 09:17:29 UTC
*** Bug 1374619 has been marked as a duplicate of this bug. ***

Comment 8 sefi litmanovich 2017-01-04 09:14:52 UTC
Verified with rhevm-4.1.0-0.3.beta2.el7.
I was not able to re produce the bug, added the test case to our automation, so if there's still a problem, hopefully we'll hit it some day.


Note You need to log in before you can comment on or make changes to this bug.