Spec URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi.spec SRPM URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi-0-0.1.20160909git.fc24.src.rpm Description: An irssi plugin that supports connecting to a quassel core. Fedora Account System Username: tc01 rpmlint complains that libquassel-core.so is not stripped, which presumably is why no debuginfo package is generated. I'm not sure why the stripping doesn't happen automatically though. Requires libquasselc.
Also should be noted that the patch here https://patch-diff.githubusercontent.com/raw/phhusson/quassel-irssi/pull/19.patch is a pull request I opened against quassel-irssi; see https://github.com/phhusson/quassel-irssi/pull/19.
Updated package; the patch above was merged and quasselc has been accepted into the repositories, so I've polished and cleaned this one up based on the review of quasselc. Spec URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi.spec SRPM URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi-0-1.20161120gitcbd9bd7.fc24.src.rpm
have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1395726 ? thanks in advance
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 IGNORE ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v3 or later)", "GPL (v2 or later)", "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/gil/1374899-quassel-irssi/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: quassel-irssi-0-1.20161120gitcbd9bd7.fc26.i686.rpm quassel-irssi-0-1.20161120gitcbd9bd7.fc26.src.rpm quassel-irssi.i686: W: unstripped-binary-or-object /usr/lib/irssi/modules/libquassel_core.so 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- quassel-irssi.i686: W: unstripped-binary-or-object /usr/lib/irssi/modules/libquassel_core.so 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- quassel-irssi (rpmlib, GLIBC filtered): irssi Provides -------- quassel-irssi: quassel-irssi quassel-irssi(x86-32) Unversioned so-files -------------------- quassel-irssi: /usr/lib/irssi/modules/libquassel_core.so Source checksums ---------------- https://github.com/phhusson/quassel-irssi/archive/cbd9bd7f4ac44260d9fcafb809fdf153cde193e5.tar.gz#/quassel-irssi-cbd9bd7.tar.gz : CHECKSUM(SHA256) this package : 57ed25135109871ae1817c00282fcfa23362878230b09c5236d954b26805b609 CHECKSUM(SHA256) upstream package : 57ed25135109871ae1817c00282fcfa23362878230b09c5236d954b26805b609 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1374899 --plugins C/C++ -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
NOTE: quassel-irssi.i686: W: unstripped-binary-or-object /usr/lib/irssi/modules/libquassel_core.so https://fedoraproject.org/wiki/Common_Rpmlint_issues#unstripped-binary-or-object
Oh, that's why rpm wasn't stripping correctly. Fixed (by marking libquassel_core.so as executable in $%install), reuploaded spec and SRPM. Spec URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi.spec SRPM URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi-0-2.20161120gitcbd9bd7.fc24.src.rpm
Approved
quassel-irssi-0-2.20161120gitcbd9bd7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b2bb44e437
quassel-irssi-0-2.20161120gitcbd9bd7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-fa837a829b
quassel-irssi-0-2.20161120gitcbd9bd7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ed51b0769f
quassel-irssi-0-2.20161120gitcbd9bd7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b2bb44e437
quassel-irssi-0-2.20161120gitcbd9bd7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fa837a829b
quassel-irssi-0-2.20161120gitcbd9bd7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ed51b0769f
quassel-irssi-0-2.20161120gitcbd9bd7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
quassel-irssi-0-2.20161120gitcbd9bd7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
quassel-irssi-0-2.20161120gitcbd9bd7.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.