Bug 1376326 - separating attach tier and add brick
Summary: separating attach tier and add brick
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tiering
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: hari gowtham
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks: 1478273 1478275 1478276
TreeView+ depends on / blocked
 
Reported: 2016-09-15 06:01 UTC by hari gowtham
Modified: 2017-12-08 17:32 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.13.0
Clone Of:
: 1478273 1478275 1478276 (view as bug list)
Environment:
Last Closed: 2017-12-08 17:32:42 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description hari gowtham 2016-09-15 06:01:57 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2016-09-15 06:36:47 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#1) for review on master by hari gowtham (hari.gowtham005)

Comment 2 hari gowtham 2016-09-19 09:35:45 UTC
Description of problem:
currently attach tier uses the same code as add brick. it has be separated so that we can support add brick on tiered volume.

Version-Release number of selected component (if applicable):


How reproducible:
no change in the testing part.both add brick and attach tier command has to
work same as before. 

Steps to Reproduce:
1.create a volume.
2.try adding a brick/ attaching a hot tier
3.

Actual results:
add brick/attach tier successful 

Expected results:
add brick/attach tier successful (same result)

Additional info:
changes are in code level. functionality is not affected.

Comment 3 Worker Ant 2016-09-20 10:08:14 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#2) for review on master by hari gowtham (hari.gowtham005)

Comment 4 Worker Ant 2016-09-20 10:53:07 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#3) for review on master by hari gowtham (hari.gowtham005)

Comment 5 Worker Ant 2016-09-22 11:54:50 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#4) for review on master by hari gowtham (hari.gowtham005)

Comment 6 Worker Ant 2016-09-30 11:30:11 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#5) for review on master by hari gowtham (hari.gowtham005)

Comment 7 Worker Ant 2016-10-12 12:10:09 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#6) for review on master by hari gowtham (hari.gowtham005)

Comment 8 Worker Ant 2016-10-13 10:08:31 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#7) for review on master by hari gowtham (hari.gowtham005)

Comment 9 Worker Ant 2016-10-20 12:46:57 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#8) for review on master by hari gowtham (hari.gowtham005)

Comment 10 Worker Ant 2016-10-26 12:14:04 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#9) for review on master by hari gowtham (hari.gowtham005)

Comment 11 Worker Ant 2016-10-27 07:17:20 UTC
REVIEW: http://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#10) for review on master by hari gowtham (hari.gowtham005)

Comment 12 Worker Ant 2017-03-07 10:24:54 UTC
REVIEW: https://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#13) for review on master by hari gowtham (hari.gowtham005)

Comment 13 Worker Ant 2017-04-03 09:06:13 UTC
REVIEW: https://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#14) for review on master by hari gowtham (hari.gowtham005)

Comment 14 Worker Ant 2017-04-11 13:00:49 UTC
REVIEW: https://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#15) for review on master by hari gowtham (hari.gowtham005)

Comment 15 Worker Ant 2017-05-19 10:09:09 UTC
REVIEW: https://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#16) for review on master by hari gowtham (hari.gowtham005)

Comment 16 Worker Ant 2017-05-22 09:32:22 UTC
REVIEW: https://review.gluster.org/15503 (tier: separation of attach tier from add brick) posted (#17) for review on master by hari gowtham (hari.gowtham005)

Comment 17 Worker Ant 2017-05-22 10:32:47 UTC
REVIEW: https://review.gluster.org/15503 (tier: separation of attach-tier from add brick) posted (#18) for review on master by hari gowtham (hari.gowtham005)

Comment 18 Worker Ant 2017-05-22 11:28:10 UTC
REVIEW: https://review.gluster.org/15503 (tier: separation of attach-tier from add-brick) posted (#19) for review on master by hari gowtham (hari.gowtham005)

Comment 19 Worker Ant 2017-05-26 08:05:35 UTC
REVIEW: https://review.gluster.org/15503 (tier: separation of attach-tier from add-brick) posted (#20) for review on master by hari gowtham (hari.gowtham005)

Comment 20 Worker Ant 2017-07-04 11:57:26 UTC
REVIEW: https://review.gluster.org/17693 (tier: separation of attach-tier from add-brick) posted (#1) for review on experimental by hari gowtham (hari.gowtham005)

Comment 21 Worker Ant 2017-07-05 10:56:03 UTC
COMMIT: https://review.gluster.org/17693 committed in experimental by Amar Tumballi (amarts) 
------
commit 0b3f47372ffbe1c5c07e217bc1730933b8c00b7c
Author: hari gowtham <hgowtham>
Date:   Tue Jul 4 16:16:37 2017 +0530

    tier: separation of attach-tier from add-brick
    
    PROBLEM: Both attach tier and add brick have the same RPC
    and set of code. This becomes a hurdle while tring to implement
    add brick on a tiered volume.
    
    FIX: This patch separates the add brick and attach tier
    giving them separate RPCs.
    
    Conflicts:
    
    	xlators/mgmt/glusterd/src/glusterd-messages.h
    
    Change-Id: Iec57e972be968a9ff00b15b507e56a4f6dc398a2
    BUG: 1376326
    Signed-off-by: hari gowtham <hgowtham>
    Reviewed-on: https://review.gluster.org/17693
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: hari gowtham <hari.gowtham005>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>

Comment 22 Worker Ant 2017-07-31 10:16:43 UTC
REVIEW: https://review.gluster.org/15503 (tier: separation of attach-tier from add-brick) posted (#21) for review on master by hari gowtham (hari.gowtham005)

Comment 23 Worker Ant 2017-08-01 11:08:09 UTC
COMMIT: https://review.gluster.org/15503 committed in master by Atin Mukherjee (amukherj) 
------
commit e5db980504bc4ace037ea806ad89a1ca897150d5
Author: hari gowtham <hgowtham>
Date:   Mon Jan 23 16:38:00 2017 +0530

    tier: separation of attach-tier from add-brick
    
    PROBLEM: Both attach tier and add brick have the same RPC
    and set of code. This becomes a hurdle while tring to implement
    add brick on a tiered volume.
    
    FIX: This patch separates the add brick and attach tier
    giving them separate RPCs.
    
    Change-Id: Iec57e972be968a9ff00b15b507e56a4f6dc398a2
    BUG: 1376326
    Signed-off-by: hari gowtham <hgowtham>
    Reviewed-on: https://review.gluster.org/15503
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: hari gowtham <hari.gowtham005>
    Reviewed-by: Samikshan Bairagya <samikshan>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 24 Shyamsundar 2017-12-08 17:32:42 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.