Bug 1376603 - Azure Orchestration template no longer defaults to Default.
Summary: Azure Orchestration template no longer defaults to Default.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Provisioning
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.8.0
Assignee: eclarizi
QA Contact: Jeff Teehan
URL:
Whiteboard: provider:azure:provision:stack
Depends On:
Blocks: 1382830 1382835
TreeView+ depends on / blocked
 
Reported: 2016-09-15 22:04 UTC by Jeff Teehan
Modified: 2017-06-12 17:18 UTC (History)
5 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1382830 1382835 (view as bug list)
Environment:
Last Closed: 2017-06-12 17:18:38 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jeff Teehan 2016-09-15 22:04:40 UTC
Description of problem:
The built in Orchestration template for Azure create_one_vm prior to 5.6.2 would default the Mode to Incremental (Default)  Now it doesn't default to Default but rather to complete, which is killing my azure account.  This is a regression/change from 5.6.1

Version-Release number of selected component (if applicable):
5.6.2.0

How reproducible:
Always

Steps to Reproduce:
1.Create a catalog with the azure_create_one_vm
2.Order the item
3.Don't edit the mode

Actual results:
Because I didn't change anything, I would expect Default to be the Default but it is not any longer.

Expected results:


Additional info:

Comment 2 Jeff Teehan 2016-09-15 22:14:38 UTC
Just a reminder, if not caught by customer, everything in their resource group will be deleted, even if it has a 1000 active vms running and non-replaceable data.

Comment 3 Greg McCullough 2016-09-19 14:12:15 UTC
Bill - Please review this issue and see if it is related to the fix in https://github.com/ManageIQ/manageiq/pull/10358.  Work with Erik if needed.

Comment 4 Bill Wei 2016-09-19 14:57:00 UTC
Yes. I saw the same thing. Since the dialog was already created with the default value selected long time ago, I would have Erik to look at possible UI issue.

Comment 6 CFME Bot 2016-09-26 18:15:47 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/62f44ce0afdad55344fa73f4814c1502ed066312

commit 62f44ce0afdad55344fa73f4814c1502ed066312
Author:     Erik Clarizio <eclarizi>
AuthorDate: Wed Sep 21 02:05:12 2016 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Sep 21 02:05:12 2016 -0700

    Remove attr_accessor for default_value on DialogField
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1376603
    
    This was causing issues when creating dialogs (likely all the time, but
    it became apparent because of the orchestration template dialogs, hence
    the addition to the spec file in spec/services)

 app/models/dialog_field.rb                                  | 7 +------
 spec/models/dialog_field_spec.rb                            | 4 ++--
 spec/services/orchestration_template_dialog_service_spec.rb | 1 +
 3 files changed, 4 insertions(+), 8 deletions(-)

Comment 7 CFME Bot 2016-09-26 18:15:52 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/d6b006abcf2d01b9b807b8ae7d74fb4187b61a90

commit d6b006abcf2d01b9b807b8ae7d74fb4187b61a90
Author:     Erik Clarizio <eclarizi>
AuthorDate: Wed Sep 21 02:07:47 2016 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Thu Sep 22 08:02:49 2016 -0700

    Remove references to @default_value in favor of default_value
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1376603
    
    Except for assigning, so that ruby does not simply create a local
    variable

 app/models/dialog_field_drop_down_list.rb    |  21 ----
 app/models/dialog_field_radio_button.rb      |  21 ----
 app/models/dialog_field_sorted_item.rb       |  28 ++++-
 spec/models/dialog_field_sorted_item_spec.rb | 157 +++++++++++++++++++++++++++
 4 files changed, 181 insertions(+), 46 deletions(-)

Comment 10 Jeff Teehan 2017-03-08 17:53:19 UTC
This is working fine in 58004  Moving to Verified.


Note You need to log in before you can comment on or make changes to this bug.