Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/

Bug 1376763

Summary: New package: python-networking-bgpvpn
Product: [Community] RDO Reporter: Ricardo Noriega <rnoriega>
Component: Package ReviewAssignee: Javier Peña <jpena>
Status: CLOSED ERRATA QA Contact: hguemar
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: trunkCC: apevec, brault, chris.brown, jjung, jpena, lhinds, rnoriega
Target Milestone: ---Flags: jpena: rdo-review+
Target Release: trunk   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-06-22 15:43:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1379646    
Bug Blocks: 1373513, 1375272    

Description Ricardo Noriega 2016-09-16 11:02:55 UTC 
Spec file: https://github.com/oglok/networking-bgpvpn-rpm/blob/master/python-networking-bgpvpn.spec
Comment 1 Ricardo Noriega 2016-09-16 12:58:48 UTC 
Spec file: https://raw.githubusercontent.com/oglok/networking-bgpvpn-rpm/master/python-networking-bgpvpn.spec
SRPM file: https://github.com/oglok/networking-bgpvpn-rpm/blob/master/python-networking-bgpvpn-4.0.1-1.fc26.src.rpm?raw=true

Description: Neutron driver for BGP VPN connectivity
Comment 3 Ricardo Noriega 2016-10-04 14:53:05 UTC 
Finished

Spec file:https://raw.githubusercontent.com/oglok/networking-bgpvpn-rpm/master/python-networking-bgpvpn.spec

SRPM file: https://github.com/oglok/networking-bgpvpn-rpm/blob/master/python-networking-bgpvpn-4.0.1-1.el7.centos.src.rpm?raw=true
Comment 4 Ricardo Noriega 2016-10-04 14:54:47 UTC 
Added FE-NEEDSPONSOR
Comment 5 Ricardo Noriega 2016-10-04 15:08:52 UTC 
%check is disable until package WebOb==1.6.1 is available. With the current version 1.4.2, unit tests are failing.
Comment 6 Alan Pevec 2016-11-17 13:42:08 UTC 
Spec URL: https://raw.githubusercontent.com/oglok/networking-bgpvpn-rpm/master/python-networking-bgpvpn.spec
SRPM URL: https://github.com/oglok/networking-bgpvpn-rpm/raw/master/python-networking-bgpvpn-4.0.1-1.el7.centos.src.rpm
Description: BGPMPLS VPN Extension for OpenStack Networking
Comment 7 Javier Peña 2016-11-17 13:46:52 UTC 
Initial License check

$ licensecheck -r .
./tools/tox_install.sh: *No copyright* UNKNOWN
./tools/ostestr_compat_shim.sh: *No copyright* UNKNOWN
./tools/django-manage.py: *No copyright* Apache (v2.0)
./setup.py: Apache (v2.0) GENERATED FILE
./releasenotes/source/conf.py: Apache (v2.0) GENERATED FILE
./networking_bgpvpn_tempest/tests/base.py: Apache (v2.0)
./networking_bgpvpn_tempest/tests/api/test_bgpvpn.py: Apache (v2.0)
./networking_bgpvpn_tempest/services/bgpvpn/bgpvpn_client.py: Apache (v2.0)
./networking_bgpvpn_tempest/plugin.py: Apache (v2.0)
./networking_bgpvpn_tempest/config.py: Apache (v2.0)
./networking_bgpvpn_heat/bgpvpnservice.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/version.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/services/test_plugin.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/services/odl/test_odl.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/services/bagpipe/test_bagpipe.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/osc/test_resource_association.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/osc/test_bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/osc/fakes.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/extensions/test_bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/db/test_db.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/client/test_client.py: Apache (v2.0)
./networking_bgpvpn/tests/functional/test_placeholder.py: *No copyright* UNKNOWN
./networking_bgpvpn/tests/functional/db/test_migrations.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/osc/router_association.py: Apache (v2.0)
./networking_bgpvpn/osc/resource_association.py: Apache (v2.0)
./networking_bgpvpn/osc/network_association.py: Apache (v2.0)
./networking_bgpvpn/osc/bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/neutronclient/neutron/v2_0/bgpvpn/bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/opendaylight/odl.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/opencontrail/opencontrail_client.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/opencontrail/opencontrail.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/opencontrail/exceptions.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/driver_api.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/bagpipe/agent_extension.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/plugin.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/common/utils.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/common/constants.py: Apache (v2.0)
./networking_bgpvpn/neutron/extensions/bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/start_networking_bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/newton/expand/0ab4049986b8_add_indexes_to_tenant_id.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/newton/contract/23ce05e0a19f_rename_tenant_to_project.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/liberty/expand/3600132c6147_add_router_association_table.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/liberty/expand/17d9fd4fddee_initial.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/liberty/contract/180baa4183e0_initial.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/EXPAND_HEAD: *No copyright* UNKNOWN
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/CONTRACT_HEAD: *No copyright* UNKNOWN
./networking_bgpvpn/neutron/db/migration/alembic_migrations/env.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/README: *No copyright* UNKNOWN
./networking_bgpvpn/neutron/db/head.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/neutron/db/bgpvpn_db.py: Apache (v2.0)
./networking_bgpvpn/_i18n.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/__init__.py: *No copyright* Apache (v2.0)
./doc/source/samples/bgpvpn-sample01.py: Apache (v2.0)
./doc/source/conf.py: Apache (v2.0)
./devstack/settings: *No copyright* UNKNOWN
./devstack/pre_test_hook.sh: *No copyright* UNKNOWN
./devstack/post_test_hook.sh: *No copyright* UNKNOWN
./devstack/plugin.sh: *No copyright* UNKNOWN
./devstack/gate_hook.sh: *No copyright* UNKNOWN
./devstack/devstack-gate-rc: *No copyright* UNKNOWN
./devstack/devstack-gate-bagpipe-rc: *No copyright* UNKNOWN
./bgpvpn_dashboard/test/urls.py: *No copyright* Apache (v2.0)
./bgpvpn_dashboard/test/test_data/utils.py: *No copyright* Apache (v2.0)
./bgpvpn_dashboard/test/test_data/bgpvpn_data.py: *No copyright* Apache (v2.0)
./bgpvpn_dashboard/test/test.py: *No copyright* Apache (v2.0)$ licensecheck -r .
./tools/tox_install.sh: *No copyright* UNKNOWN
./tools/ostestr_compat_shim.sh: *No copyright* UNKNOWN
./tools/django-manage.py: *No copyright* Apache (v2.0)
./setup.py: Apache (v2.0) GENERATED FILE
./releasenotes/source/conf.py: Apache (v2.0) GENERATED FILE
./networking_bgpvpn_tempest/tests/base.py: Apache (v2.0)
./networking_bgpvpn_tempest/tests/api/test_bgpvpn.py: Apache (v2.0)
./networking_bgpvpn_tempest/services/bgpvpn/bgpvpn_client.py: Apache (v2.0)
./networking_bgpvpn_tempest/plugin.py: Apache (v2.0)
./networking_bgpvpn_tempest/config.py: Apache (v2.0)
./networking_bgpvpn_heat/bgpvpnservice.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/version.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/services/test_plugin.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/services/odl/test_odl.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/services/bagpipe/test_bagpipe.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/osc/test_resource_association.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/osc/test_bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/osc/fakes.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/extensions/test_bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/db/test_db.py: Apache (v2.0)
./networking_bgpvpn/tests/unit/client/test_client.py: Apache (v2.0)
./networking_bgpvpn/tests/functional/test_placeholder.py: *No copyright* UNKNOWN
./networking_bgpvpn/tests/functional/db/test_migrations.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/osc/router_association.py: Apache (v2.0)
./networking_bgpvpn/osc/resource_association.py: Apache (v2.0)
./networking_bgpvpn/osc/network_association.py: Apache (v2.0)
./networking_bgpvpn/osc/bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/neutronclient/neutron/v2_0/bgpvpn/bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/opendaylight/odl.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/opencontrail/opencontrail_client.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/opencontrail/opencontrail.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/opencontrail/exceptions.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/driver_api.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/service_drivers/bagpipe/agent_extension.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/plugin.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/common/utils.py: Apache (v2.0)
./networking_bgpvpn/neutron/services/common/constants.py: Apache (v2.0)
./networking_bgpvpn/neutron/extensions/bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/start_networking_bgpvpn.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/newton/expand/0ab4049986b8_add_indexes_to_tenant_id.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/newton/contract/23ce05e0a19f_rename_tenant_to_project.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/liberty/expand/3600132c6147_add_router_association_table.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/liberty/expand/17d9fd4fddee_initial.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/liberty/contract/180baa4183e0_initial.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/EXPAND_HEAD: *No copyright* UNKNOWN
./networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/CONTRACT_HEAD: *No copyright* UNKNOWN
./networking_bgpvpn/neutron/db/migration/alembic_migrations/env.py: Apache (v2.0)
./networking_bgpvpn/neutron/db/migration/alembic_migrations/README: *No copyright* UNKNOWN
./networking_bgpvpn/neutron/db/head.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/neutron/db/bgpvpn_db.py: Apache (v2.0)
./networking_bgpvpn/_i18n.py: *No copyright* Apache (v2.0)
./networking_bgpvpn/__init__.py: *No copyright* Apache (v2.0)
./doc/source/samples/bgpvpn-sample01.py: Apache (v2.0)
./doc/source/conf.py: Apache (v2.0)
./devstack/settings: *No copyright* UNKNOWN
./devstack/pre_test_hook.sh: *No copyright* UNKNOWN
./devstack/post_test_hook.sh: *No copyright* UNKNOWN
./devstack/plugin.sh: *No copyright* UNKNOWN
./devstack/gate_hook.sh: *No copyright* UNKNOWN
./devstack/devstack-gate-rc: *No copyright* UNKNOWN
./devstack/devstack-gate-bagpipe-rc: *No copyright* UNKNOWN
./bgpvpn_dashboard/test/urls.py: *No copyright* Apache (v2.0)
./bgpvpn_dashboard/test/test_data/utils.py: *No copyright* Apache (v2.0)
./bgpvpn_dashboard/test/test_data/bgpvpn_data.py: *No copyright* Apache (v2.0)
./bgpvpn_dashboard/test/test.py: *No copyright* Apache (v2.0)
./bgpvpn_dashboard/test/settings.py: *No copyright* Apache (v2.0)
./bgpvpn_dashboard/test/helpers.py: Apache (v2.0)
./bgpvpn_dashboard/test/api_tests/bgpvpn_tests.py: Apache (v2.0)
./bgpvpn_dashboard/enabled/_2115_admin_bgpvpn_panel.py: *No copyright* UNKNOWN
./bgpvpn_dashboard/enabled/_1495_project_bgpvpn_panel.py: *No copyright* UNKNOWN
./bgpvpn_dashboard/dashboards/project/bgpvpn/workflows.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/views.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/urls.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/tables.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/panel.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/forms.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/workflows.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/views.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/urls.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/tables.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/panel.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/forms.py: Apache (v2.0)
./bgpvpn_dashboard/common/bgpvpn.py: Apache (v2.0)
./bgpvpn_dashboard/api/bgpvpn.py: Apache (v2.0)
./LICENSE: *No copyright* GENERATED FILE

./bgpvpn_dashboard/test/settings.py: *No copyright* Apache (v2.0)
./bgpvpn_dashboard/test/helpers.py: Apache (v2.0)
./bgpvpn_dashboard/test/api_tests/bgpvpn_tests.py: Apache (v2.0)
./bgpvpn_dashboard/enabled/_2115_admin_bgpvpn_panel.py: *No copyright* UNKNOWN
./bgpvpn_dashboard/enabled/_1495_project_bgpvpn_panel.py: *No copyright* UNKNOWN
./bgpvpn_dashboard/dashboards/project/bgpvpn/workflows.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/views.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/urls.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/tables.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/panel.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/project/bgpvpn/forms.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/workflows.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/views.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/urls.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/tables.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/panel.py: Apache (v2.0)
./bgpvpn_dashboard/dashboards/admin/bgpvpn/forms.py: Apache (v2.0)
./bgpvpn_dashboard/common/bgpvpn.py: Apache (v2.0)
./bgpvpn_dashboard/api/bgpvpn.py: Apache (v2.0)
./LICENSE: *No copyright* GENERATED FILE
Comment 8 Ricardo Noriega 2016-11-18 15:05:39 UTC 
Spec file: https://raw.githubusercontent.com/oglok/networking-bgpvpn-rpm/master/python-networking-bgpvpn.spec

SRPM file: https://github.com/oglok/networking-bgpvpn-rpm/raw/master/python-networking-bgpvpn-5.0.1-0.20161118134619.34c094d.el7.centos.src.rpm

TripleO CI has verified the spec file and build this src rpm file.
Comment 9 Javier Peña 2016-11-18 15:40:57 UTC 
Note the Source URL and SRPM vs spec differences are expected, due to the SRPM being created by DLRN.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Dist tag is present.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 23 files have unknown license. Detailed output of
     licensecheck in /tmp/review-python-networking-bgpvpn/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /etc/neutron/policy.d, /etc/neutron
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/neutron,
     /etc/neutron/policy.d
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     https://files.pythonhosted.org/packages/source/n/networking-bgpvpn
     /networking-bgpvpn-5.0.1.tar.gz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
    -networking-bgpvpn , python-networking-bgpvpn-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[-]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python2-networking-bgpvpn-5.0.1-0.20161118134619.34c094d.el7.centos.noarch.rpm
          python-networking-bgpvpn-doc-5.0.1-0.20161118134619.34c094d.el7.centos.noarch.rpm
          python-networking-bgpvpn-tests-5.0.1-0.20161118134619.34c094d.el7.centos.noarch.rpm
          python-networking-bgpvpn-dashboard-5.0.1-0.20161118134619.34c094d.el7.centos.noarch.rpm
          python-networking-bgpvpn-heat-5.0.1-0.20161118134619.34c094d.el7.centos.noarch.rpm
          python-networking-bgpvpn-5.0.1-0.20161118134619.34c094d.el7.centos.src.rpm
python2-networking-bgpvpn.noarch: E: no-changelogname-tag
python2-networking-bgpvpn.noarch: E: non-readable /etc/neutron/networking_bgpvpn.conf 640
python2-networking-bgpvpn.noarch: W: non-conffile-in-etc /etc/neutron/networking_bgpvpn.conf
python2-networking-bgpvpn.noarch: E: non-readable /etc/neutron/policy.d/bgpvpn.conf 640
python2-networking-bgpvpn.noarch: W: non-conffile-in-etc /etc/neutron/policy.d/bgpvpn.conf
python-networking-bgpvpn-doc.noarch: W: summary-not-capitalized C networking-bgpvpn documentation
python-networking-bgpvpn-doc.noarch: E: no-changelogname-tag
python-networking-bgpvpn-doc.noarch: W: no-documentation
python-networking-bgpvpn-tests.noarch: W: summary-not-capitalized C networking-bgpvpn tests
python-networking-bgpvpn-tests.noarch: E: no-changelogname-tag
python-networking-bgpvpn-dashboard.noarch: W: summary-not-capitalized C networking-bgpvpn dashboard
python-networking-bgpvpn-dashboard.noarch: E: no-changelogname-tag
python-networking-bgpvpn-dashboard.noarch: W: no-documentation
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_associated_routers.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_associated_routers.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/modify.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/modify.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_associated_networks.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_associated_networks.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/_create.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_modify.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_modify.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/detail.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/detail.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/create.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/detail.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/detail.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/_detail_overview.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/_detail_overview.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_detail_overview.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_detail_overview.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/index.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/index.html
python-networking-bgpvpn-heat.noarch: W: summary-not-capitalized C networking-bgpvpn heat
python-networking-bgpvpn-heat.noarch: E: no-changelogname-tag
python-networking-bgpvpn-heat.noarch: W: no-documentation
python-networking-bgpvpn.src: E: no-changelogname-tag
python-networking-bgpvpn.src:110: W: macro-in-comment %{__python2}
python-networking-bgpvpn.src:138: W: macro-in-comment %doc
python-networking-bgpvpn.src: W: invalid-url Source0: networking-bgpvpn-5.0.1.dev37-0.20161118134619.34c094d.tar.gz
6 packages and 0 specfiles checked; 28 errors, 12 warnings.




Rpmlint (installed packages)
----------------------------
python-networking-bgpvpn-tests.noarch: W: summary-not-capitalized C networking-bgpvpn tests
python-networking-bgpvpn-tests.noarch: E: no-changelogname-tag
python-networking-bgpvpn-heat.noarch: W: summary-not-capitalized C networking-bgpvpn heat
python-networking-bgpvpn-heat.noarch: E: no-changelogname-tag
python-networking-bgpvpn-heat.noarch: W: no-documentation
python2-networking-bgpvpn.noarch: E: no-changelogname-tag
python2-networking-bgpvpn.noarch: E: non-readable /etc/neutron/networking_bgpvpn.conf 0640L
python2-networking-bgpvpn.noarch: W: non-conffile-in-etc /etc/neutron/networking_bgpvpn.conf
python2-networking-bgpvpn.noarch: E: non-readable /etc/neutron/policy.d/bgpvpn.conf 0640L
python2-networking-bgpvpn.noarch: W: non-conffile-in-etc /etc/neutron/policy.d/bgpvpn.conf
python-networking-bgpvpn-dashboard.noarch: W: summary-not-capitalized C networking-bgpvpn dashboard
python-networking-bgpvpn-dashboard.noarch: E: no-changelogname-tag
python-networking-bgpvpn-dashboard.noarch: W: no-documentation
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_associated_routers.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_associated_routers.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/_create.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/modify.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/modify.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/detail.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/detail.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_associated_networks.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_associated_networks.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_modify.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_modify.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/index.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/index.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/detail.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/detail.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_detail_overview.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/project/bgpvpn/templates/bgpvpn/_detail_overview.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/_detail_overview.html
python-networking-bgpvpn-dashboard.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/_detail_overview.html
python-networking-bgpvpn-dashboard.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/bgpvpn_dashboard/dashboards/admin/bgpvpn/templates/bgpvpn/create.html
python-networking-bgpvpn-doc.noarch: W: summary-not-capitalized C networking-bgpvpn documentation
python-networking-bgpvpn-doc.noarch: E: no-changelogname-tag
python-networking-bgpvpn-doc.noarch: W: no-documentation
5 packages and 0 specfiles checked; 27 errors, 9 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /tmp/python-networking-bgpvpn.spec	2016-11-18 16:14:25.013489262 +0100
+++ /tmp/review-python-networking-bgpvpn/srpm-unpacked/python-networking-bgpvpn.spec	2016-11-18 14:46:19.000000000 +0100
@@ -1,2 +1,4 @@
+%global dlrn 1
+%define upstream_version 5.0.1.dev37
 %global pypi_name networking-bgpvpn
 %global sname networking_bgpvpn
@@ -4,11 +6,11 @@
 
 Name:           python-%{pypi_name}
-Version:        5.0.1
-Release:        0.20161118134619.34c094d
+Version: 5.0.1
+Release: 0.20161118134619.34c094d%{?dist}
 Summary:        API and Framework to interconnect bgpvpn to neutron networks
 
 License:        ASL 2.0
 URL:            http://www.openstack.org/
-Source0:        https://files.pythonhosted.org/packages/source/n/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz
+Source0: networking-bgpvpn-5.0.1.dev37-0.20161118134619.34c094d.tar.gz
 BuildArch:      noarch
 
@@ -151,4 +153,2 @@
 
 %changelog
-* Thu Sep 15 2016 Ricardo Noriega <rnoriega> - 4.0.1
-- Initial package.


Requires
--------
python-networking-bgpvpn-tests (rpmlib, GLIBC filtered):
    python(abi)
    python-networking-bgpvpn

python-networking-bgpvpn-heat (rpmlib, GLIBC filtered):
    python(abi)
    python-networking-bgpvpn

python2-networking-bgpvpn (rpmlib, GLIBC filtered):
    openstack-neutron-common
    python(abi)
    python-babel
    python-oslo-config
    python-oslo-db
    python-oslo-log
    python-oslo-utils
    python-pbr
    python-setuptools
    python-webob
    python-webtest

python-networking-bgpvpn-dashboard (rpmlib, GLIBC filtered):
    python(abi)
    python-networking-bgpvpn

python-networking-bgpvpn-doc (rpmlib, GLIBC filtered):



Provides
--------
python-networking-bgpvpn-tests:
    python-networking-bgpvpn-tests

python-networking-bgpvpn-heat:
    python-networking-bgpvpn-heat

python2-networking-bgpvpn:
    python-networking-bgpvpn
    python2-networking-bgpvpn

python-networking-bgpvpn-dashboard:
    python-networking-bgpvpn-dashboard

python-networking-bgpvpn-doc:
    python-networking-bgpvpn-doc



Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n python-networking-bgpvpn -m dlrn
Buildroot used: dlrn-centos7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

The package is APPROVED, we can move ahead with step 4 of https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk
Comment 10 Christopher Brown 2017-06-22 15:43:35 UTC 
This was merged so closing this.