RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1379646 - New package: python-networking-bagpipe - Mechanism driver for Neutron ML2 plugin using BGP E-VPNs/IP VPNs as a backend
Summary: New package: python-networking-bagpipe - Mechanism driver for Neutron ML2 plu...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: trunk
Assignee: Javier Peña
QA Contact: hguemar
URL:
Whiteboard:
Depends On:
Blocks: RDO-OCATA 1375272 1376763
TreeView+ depends on / blocked
 
Reported: 2016-09-27 10:12 UTC by Luke Hinds
Modified: 2017-02-20 13:03 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-14 17:19:52 UTC
Embargoed:
jpena: rdo-review+


Attachments (Terms of Use)

Comment 1 Luke Hinds 2016-09-28 14:57:45 UTC
Some more changes coming in, so not ready for consumption just yet.

Comment 3 Luke Hinds 2016-10-03 09:08:33 UTC
Added FE-NEEDSPONSOR

Comment 4 Alan Pevec 2016-10-04 16:14:13 UTC
> Added FE-NEEDSPONSOR

oh I see now, this is RDO review not in Fedora, so no need for FE-NEEDSPONSOR.
Are there any plans to add it in Fedora too?

Comment 5 Luke Hinds 2016-10-04 16:24:31 UTC
hi alan, no need, its just planned for rdo trunk, and then sig.

Comment 6 Luke Hinds 2016-10-10 09:23:04 UTC
Hi Alan / Haïkel, whats needed now to move to the next step? It seems the rdo.yml patch is in good shape now?

https://review.rdoproject.org/r/#/c/2897/

Comment 8 Alan Pevec 2016-11-08 00:11:36 UTC
Spec URL: https://github.com/lukehinds/rdo-packaging/blob/master/python-networking-bagpipe/SPEC/python-networking-bagpipe.spec
SRPM URL: <srpm info here>
Description: <description here>

Comment 9 Alan Pevec 2016-11-08 00:13:14 UTC
Spec URL: https://github.com/lukehinds/rdo-packaging/blob/master/python-networking-bagpipe/SPEC/python-networking-bagpipe.spec
SRPM URL: https://github.com/lukehinds/rdo-packaging/raw/master/python-networking-bagpipe/RPMS/python-networking-bagpipe-4.0.1-0.20160929163359.d1029ee.el7.centos.src.rpm
Description: BaGPipe BGP is a lightweight implementation of BGP VPNs (IP VPNs and E-VPNs),
targeting deployments on servers hosting VMs, in particular for Openstack/KVM
platforms.

Comment 10 Alan Pevec 2016-11-08 01:29:43 UTC
Please drop:
BuildConflicts: python-oslosphinx = 3.4.0
BuildConflicts: python-sphinx = 1.2.0
BuildConflicts: python-sphinx = 1.3b1

Those are != from upstream's requirements.txt but RDO as a distro ensures that known bad versions are not available.

Conflicts in general are to be avoided: https://fedoraproject.org/wiki/Packaging:Guidelines#Conflicts

Comment 12 Javier Peña 2016-11-08 09:54:17 UTC
$ licensecheck -r .
./tools/tox_install.sh: *No copyright* UNKNOWN
./setup.py: Apache (v2.0) GENERATED FILE
./releasenotes/source/conf.py: Apache (v2.0) GENERATED FILE
./networking_bagpipe/version.py: Apache (v2.0)
./networking_bagpipe/tests/unit/driver/test_type_route_target.py: Apache (v2.0)
./networking_bagpipe/tests/unit/driver/test_mech_bagpipe.py: Apache (v2.0)
./networking_bagpipe/tests/unit/agent/test_linuxbridge_agent_extension.py: Apache (v2.0)
./networking_bagpipe/tests/unit/agent/test_bagpipe_bgp_agent.py: Apache (v2.0)
./networking_bagpipe/rpc/client.py: Apache (v2.0)
./networking_bagpipe/rpc/agent.py: Apache (v2.0)
./networking_bagpipe/driver/type_route_target.py: Apache (v2.0)
./networking_bagpipe/driver/mech_bagpipe.py: Apache (v2.0)
./networking_bagpipe/db/migration/alembic_migrations/versions/start_networking_bagpipe.py: Apache (v2.0)
./networking_bagpipe/db/migration/alembic_migrations/versions/liberty/expand/d4d4d7f03b21_initial.py: Apache (v2.0)
./networking_bagpipe/db/migration/alembic_migrations/versions/liberty/contract/0a2ee5cbb1a5_initial.py: Apache (v2.0)
./networking_bagpipe/db/migration/alembic_migrations/versions/HEADS: *No copyright* UNKNOWN
./networking_bagpipe/db/migration/alembic_migrations/env.py: Apache (v2.0)
./networking_bagpipe/db/migration/alembic_migrations/README: *No copyright* UNKNOWN
./networking_bagpipe/agent/bgpvpn/rpc_client.py: Apache (v2.0)
./networking_bagpipe/agent/bgpvpn/rpc_agent.py: Apache (v2.0)
./networking_bagpipe/agent/bagpipe_linuxbridge_neutron_agent.py: Apache (v2.0)
./networking_bagpipe/agent/bagpipe_bgp_agent.py: Apache (v2.0)
./networking_bagpipe/_i18n.py: *No copyright* Apache (v2.0)
./networking_bagpipe/__init__.py: *No copyright* Apache (v2.0)
./doc/source/conf.py: Apache (v2.0)
./devstack/settings: *No copyright* UNKNOWN
./devstack/plugin.sh: *No copyright* UNKNOWN
./devstack/override-defaults: *No copyright* UNKNOWN
./devstack/gate_hook.sh: *No copyright* UNKNOWN
./devstack/devstack-gate-rc: *No copyright* UNKNOWN
./devstack/agent: *No copyright* UNKNOWN
./LICENSE: *No copyright* GENERATED FILE

The package is using an ASL 2.0 license.

Comment 13 Luke Hinds 2016-11-08 11:21:00 UTC
Spec URL: https://github.com/lukehinds/rdo-packaging/blob/master/python-networking-bagpipe/SPEC/python-networking-bagpipe.spec
SRPM URL: https://github.com/lukehinds/rdo-packaging/blob/master/python-networking-bagpipe/RPMS/python-networking-bagpipe-5.0.1-0.20161108095739.1e5983e.el7.centos.src.rpm
Description: BaGPipe BGP is a lightweight implementation of BGP VPNs (IP VPNs and E-VPNs),
targeting deployments on servers hosting VMs, in particular for Openstack/KVM
platforms.

Comment 14 Alan Pevec 2016-11-11 01:28:34 UTC
Spec URL: https://github.com/lukehinds/rdo-packaging/blob/master/python-networking-bagpipe/SPEC/python-networking-bagpipe.spec
SRPM URL: https://github.com/lukehinds/rdo-packaging/raw/master/python-networking-bagpipe/RPMS/python-networking-bagpipe-5.0.1-0.20161108095739.1e5983e.el7.centos.src.rpm
Description: BaGPipe BGP is a lightweight implementation of BGP VPNs (IP VPNs and E-VPNs),
targeting deployments on servers hosting VMs, in particular for Openstack/KVM
platforms.

Comment 15 Javier Peña 2016-11-11 09:29:51 UTC
It looks like the SRPM in comments #13 and #14 was not built from the spec URL.

Luke, could you open a review in review.rdoproject.org for the initial spec import (as described in step 3 of https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk)? We will iron out the spec details there, then give it a formal approval here in the bz.

Comment 16 Luke Hinds 2016-11-11 09:50:37 UTC
spec file on review.rdoproject: https://review.rdoproject.org/r/#/c/3648/

Comment 18 Javier Peña 2016-11-14 10:28:19 UTC
The spec is in good shape. The spec vs srpm and the Source0 URL errors seen below are caused by using a DLRN spec, so they are expected.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 16 files have unknown license. Detailed output of
     licensecheck in /tmp/review-python-networking-bagpipe/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0: http://tarballs.openstack.org
     /networking-bagpipe/networking-bagpipe-5.0.1.tar.gz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -networking-bagpipe , python-networking-bagpipe-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python2-networking-bagpipe-5.0.1-0.20161111113303.ebd54f1.el7.centos.noarch.rpm
          python-networking-bagpipe-doc-5.0.1-0.20161111113303.ebd54f1.el7.centos.noarch.rpm
          python-networking-bagpipe-5.0.1-0.20161111113303.ebd54f1.el7.centos.src.rpm
python2-networking-bagpipe.noarch: W: spelling-error Summary(en_US) backend -> backed, back end, back-end
python2-networking-bagpipe.noarch: E: no-changelogname-tag
python2-networking-bagpipe.noarch: W: no-manual-page-for-binary neutron-bagpipe-linuxbridge-agent
python-networking-bagpipe-doc.noarch: W: summary-not-capitalized C networking-bagpipe documentation
python-networking-bagpipe-doc.noarch: E: no-changelogname-tag
python-networking-bagpipe.src: W: spelling-error Summary(en_US) backend -> backed, back end, back-end
python-networking-bagpipe.src: E: no-changelogname-tag
python-networking-bagpipe.src: W: invalid-url Source0: networking-bagpipe-5.0.1.dev29-0.20161111113303.ebd54f1.tar.gz
3 packages and 0 specfiles checked; 3 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
python2-networking-bagpipe.noarch: E: no-changelogname-tag
python2-networking-bagpipe.noarch: W: no-manual-page-for-binary neutron-bagpipe-linuxbridge-agent
python-networking-bagpipe-doc.noarch: W: summary-not-capitalized C networking-bagpipe documentation
python-networking-bagpipe-doc.noarch: E: no-changelogname-tag
2 packages and 0 specfiles checked; 2 errors, 2 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /tmp/python-networking-bagpipe.spec	2016-11-14 10:55:50.836386459 +0100
+++ /tmp/review-python-networking-bagpipe/srpm-unpacked/python-networking-bagpipe.spec	2016-11-11 12:33:03.000000000 +0100
@@ -1,2 +1,4 @@
+%global dlrn 1
+%define upstream_version 5.0.1.dev29
 %global pypi_name networking-bagpipe
 %global sname networking_bagpipe
@@ -4,11 +6,11 @@
 
 Name:           python-%{pypi_name}
-Version:        5.0.1
-Release:        0%{?dist}
+Version: 5.0.1
+Release: 0.20161111113303.ebd54f1%{?dist}
 Summary:        Mechanism driver for Neutron ML2 plugin using BGP E-VPNs/IP VPNs as a backend
 
 License:        ASL 2.0
 URL:            https://github.com/openstack/networking-bagpipe
-Source0:        http://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz
+Source0: networking-bagpipe-5.0.1.dev29-0.20161111113303.ebd54f1.tar.gz
 
 BuildArch:      noarch
@@ -85,4 +87,2 @@
 
 %changelog
-* Fri Nov 11 2016 Luke Hinds <lhinds> - 4.0.0-2
-- Initial package.


Requires
--------
python2-networking-bagpipe (rpmlib, GLIBC filtered):
    /usr/bin/python2
    python(abi)
    python-babel
    python-neutron-lib
    python-oslo-concurrency
    python-oslo-config
    python-oslo-db
    python-oslo-log
    python-oslo-messaging
    python-oslo-service
    python-pbr
    python-setuptools

python-networking-bagpipe-doc (rpmlib, GLIBC filtered):



Provides
--------
python2-networking-bagpipe:
    python-networking-bagpipe
    python2-networking-bagpipe

python-networking-bagpipe-doc:
    python-networking-bagpipe-doc



Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n python-networking-bagpipe -m dlrn
Buildroot used: dlrn-centos7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

The package is APPROVED.

Comment 19 Javier Peña 2016-11-14 10:30:31 UTC
Luke, we can now proceed with step 4 of https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk to get the package built. Could you open the review?

Comment 20 Javier Peña 2016-11-14 15:23:27 UTC
There were a couple mistakes in the previous checklist, here is an updated one.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 16 files have unknown license. Detailed output of
     licensecheck in /tmp/review-python-networking-bagpipe/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0: http://tarballs.openstack.org
     /networking-bagpipe/networking-bagpipe-5.0.1.tar.gz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -networking-bagpipe , python-networking-bagpipe-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python2-networking-bagpipe-5.0.1-0.20161111113303.ebd54f1.el7.centos.noarch.rpm
          python-networking-bagpipe-doc-5.0.1-0.20161111113303.ebd54f1.el7.centos.noarch.rpm
          python-networking-bagpipe-5.0.1-0.20161111113303.ebd54f1.el7.centos.src.rpm
python2-networking-bagpipe.noarch: W: spelling-error Summary(en_US) backend -> backed, back end, back-end
python2-networking-bagpipe.noarch: E: no-changelogname-tag
python2-networking-bagpipe.noarch: W: no-manual-page-for-binary neutron-bagpipe-linuxbridge-agent
python-networking-bagpipe-doc.noarch: W: summary-not-capitalized C networking-bagpipe documentation
python-networking-bagpipe-doc.noarch: E: no-changelogname-tag
python-networking-bagpipe.src: W: spelling-error Summary(en_US) backend -> backed, back end, back-end
python-networking-bagpipe.src: E: no-changelogname-tag
python-networking-bagpipe.src: W: invalid-url Source0: networking-bagpipe-5.0.1.dev29-0.20161111113303.ebd54f1.tar.gz
3 packages and 0 specfiles checked; 3 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
python2-networking-bagpipe.noarch: E: no-changelogname-tag
python2-networking-bagpipe.noarch: W: no-manual-page-for-binary neutron-bagpipe-linuxbridge-agent
python-networking-bagpipe-doc.noarch: W: summary-not-capitalized C networking-bagpipe documentation
python-networking-bagpipe-doc.noarch: E: no-changelogname-tag
2 packages and 0 specfiles checked; 2 errors, 2 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /tmp/python-networking-bagpipe.spec	2016-11-14 10:55:50.836386459 +0100
+++ /tmp/review-python-networking-bagpipe/srpm-unpacked/python-networking-bagpipe.spec	2016-11-11 12:33:03.000000000 +0100
@@ -1,2 +1,4 @@
+%global dlrn 1
+%define upstream_version 5.0.1.dev29
 %global pypi_name networking-bagpipe
 %global sname networking_bagpipe
@@ -4,11 +6,11 @@
 
 Name:           python-%{pypi_name}
-Version:        5.0.1
-Release:        0%{?dist}
+Version: 5.0.1
+Release: 0.20161111113303.ebd54f1%{?dist}
 Summary:        Mechanism driver for Neutron ML2 plugin using BGP E-VPNs/IP VPNs as a backend
 
 License:        ASL 2.0
 URL:            https://github.com/openstack/networking-bagpipe
-Source0:        http://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz
+Source0: networking-bagpipe-5.0.1.dev29-0.20161111113303.ebd54f1.tar.gz
 
 BuildArch:      noarch
@@ -85,4 +87,2 @@
 
 %changelog
-* Fri Nov 11 2016 Luke Hinds <lhinds> - 4.0.0-2
-- Initial package.


Requires
--------
python2-networking-bagpipe (rpmlib, GLIBC filtered):
    /usr/bin/python2
    python(abi)
    python-babel
    python-neutron-lib
    python-oslo-concurrency
    python-oslo-config
    python-oslo-db
    python-oslo-log
    python-oslo-messaging
    python-oslo-service
    python-pbr
    python-setuptools

python-networking-bagpipe-doc (rpmlib, GLIBC filtered):



Provides
--------
python2-networking-bagpipe:
    python-networking-bagpipe
    python2-networking-bagpipe

python-networking-bagpipe-doc:
    python-networking-bagpipe-doc



Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n python-networking-bagpipe -m dlrn
Buildroot used: dlrn-centos7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 21 Javier Peña 2016-11-14 17:19:52 UTC
The package has been successfully merged, and it is now available in the RDO Trunk repos: https://trunk.rdoproject.org/centos7/a4/f9/a4f9a75d1cf06fb43beeb848b39faffb937fa543_f41f414a/rpmbuild.log

Comment 22 Luke Hinds 2017-02-20 13:03:22 UTC
clear needinfo


Note You need to log in before you can comment on or make changes to this bug.