Bug 1377628 - mirror redirect from https to http breaks download
Summary: mirror redirect from https to http breaks download
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mediawriter
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Martin Bříza
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-20 08:50 UTC by lnie
Modified: 2016-09-27 00:31 UTC (History)
3 users (show)

Fixed In Version: mediawriter-3.97.1-0.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-27 00:31:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot (563.49 KB, image/png)
2016-09-20 08:50 UTC, lnie
no flags Details
journal (376.61 KB, text/plain)
2016-09-20 08:54 UTC, lnie
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1377678 0 unspecified CLOSED try multiple mirrors if some of them fail 2021-02-22 00:41:40 UTC

Internal Links: 1377678

Description lnie 2016-09-20 08:50:49 UTC
Created attachment 1202778 [details]
screenshot

Description of problem:
get "insecure redirect" error everytime I click the "create live usb" button

Version-Release number of selected component (if applicable):
mediawriter-3.96.0-0.fc25.x86_64

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 lnie 2016-09-20 08:54:33 UTC
Created attachment 1202779 [details]
journal

Comment 2 Kamil Páral 2016-09-20 10:58:21 UTC
The log contains:
Sep 20 16:53:00 localhost.localdomain mediawriter.desktop[1866]: Warning: Error QNetworkReply::NetworkError(InsecureRedirectError) reading from QUrl("https://mirrors.ustc.edu.cn/fedora/linux/releases/24/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-24-1.2.iso") : "Insecure redirect" ((null):0, (null))


That URL seems to redirect to http (which in the end returns 404). It seems that https -> http redirection is not allowed by default in QNetworkReply (which might be a very reasonable configuration). However, FMW should not fail just because one mirror is badly configured.

Comment 3 Kamil Páral 2016-09-20 11:07:00 UTC
Fixing bug 1377678 would fix this one as well.

Comment 4 Martin Bříza 2016-09-20 11:10:30 UTC
Actually, the problem in this case is that HTTP servers point to HTTPS mirrors and those in turn point to HTTP ones. I specifically included only HTTP links to avoid this problem before either 1) mirrors are fixed or 2) Qt allows an option to not care about insecure redirects.
After including HTTP links only I didn't hit this issue but it seems it still affects other so I'll implement a redirect handler to avoid this.

Comment 5 Kamil Páral 2016-09-20 13:20:34 UTC
If you use the list from bug 1377678 comment 2, maybe you don't need to do anything. The insecure redirect will simply be skipped and another mirror from the list will be used instead.

Comment 6 Martin Bříza 2016-09-20 13:25:09 UTC
Yes. That seems like the most reasonable approach. I'll maybe add a regular redirect handling too just in case the link you mentioned is not accessible for some reason.

Comment 7 Fedora Update System 2016-09-23 05:24:03 UTC
mediawriter-3.97.0-0.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d84f684d42

Comment 8 Kamil Páral 2016-09-23 12:17:17 UTC
Lili, can you test this? Thanks.

Comment 9 Fedora Update System 2016-09-24 17:51:52 UTC
mediawriter-3.97.1-0.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e34fd77aaf

Comment 10 lnie 2016-09-26 04:31:15 UTC
(In reply to Kamil Páral from comment #8)
> Lili, can you test this? Thanks.
 Sure,gonna to do.

Comment 11 Fedora Update System 2016-09-27 00:31:23 UTC
mediawriter-3.97.1-0.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.