Bug 1378412 - Split dashboard javascript code in hosted-engine and node subdirectories
Summary: Split dashboard javascript code in hosted-engine and node subdirectories
Keywords:
Status: CLOSED DUPLICATE of bug 1380641
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Hosted Engine
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.1.0-alpha
: ---
Assignee: Sandro Bonazzola
QA Contact: dguo
URL:
Whiteboard:
Depends On:
Blocks: 1346835
TreeView+ depends on / blocked
 
Reported: 2016-09-22 11:06 UTC by Sandro Bonazzola
Modified: 2017-01-18 12:46 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-01 19:08:32 UTC
oVirt Team: Integration
sbonazzo: ovirt-4.1?
sbonazzo: planning_ack?
fdeutsch: devel_ack?
ycui: testing_ack+

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Sandro Bonazzola 2016-09-22 11:06:49 UTC 
Description of problem:
Currently Hosted Engine tab Javascript code and Node dashboard Javascript code are bundled in a single application within dashboard directory

We need to split it as it has been done with vdsm tab in order to allow to install only the required tab in separate rpms.
Comment 1 Ryan Barry 2016-09-22 12:30:57 UTC 
It's important to node that the vdsm tab is actually not bundled separately -- it's also together.

If "--with-vdsm" is specified, then the vdsm code is built (and linked into the same bundle).

The ideal is something like:

cockpit-ovirt-dashboard:
# generates foo.js

cockpit-ovirt-dashboard-node:
# generates bar.js
# try to lazily load this in react-router, and add the tab if it's there

cockpit-ovirt-dashboard-vdsm:
# generates baz.js
# try to lazily load this as well
Comment 3 Fabian Deutsch 2016-10-01 19:08:32 UTC 
This bug is obsoleted by bug 1380641

*** This bug has been marked as a duplicate of bug 1380641 ***
Note You need to log in before you can comment on or make changes to this bug.