Bug 1380641 - Disable node functionality in virtualization dashboard if nodectl is not available
Summary: Disable node functionality in virtualization dashboard if nodectl is not avai...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-node
Classification: oVirt
Component: UI
Version: 4.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium vote
Target Milestone: ovirt-4.1.0-beta
: 4.1
Assignee: Ryan Barry
QA Contact: Wei Wang
URL:
Whiteboard:
: 1378412 1415562 (view as bug list)
Depends On:
Blocks: 1346835
TreeView+ depends on / blocked
 
Reported: 2016-09-30 08:48 UTC by Fabian Deutsch
Modified: 2017-02-15 14:52 UTC (History)
6 users (show)

Fixed In Version: cockpit-ovirt-0.10.7-0.0.4.el7ev
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-15 14:52:36 UTC
oVirt Team: Node
rule-engine: ovirt-4.1+
rule-engine: blocker+
rule-engine: planning_ack+
fdeutsch: devel_ack+
ycui: testing_ack+


Attachments (Terms of Use)
screenshot_cockpit-ovirt-dashboard (61.68 KB, image/png)
2017-01-23 06:06 UTC, Ying Cui
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 65171 0 'None' 'MERGED' 'dashboard: disable node calls if nodectl isn''t present' 2019-12-09 04:47:12 UTC
oVirt gerrit 65589 0 'None' 'MERGED' 'dashboard: disable node calls if nodectl isn''t present' 2019-12-09 04:47:12 UTC

Description Fabian Deutsch 2016-09-30 08:48:30 UTC
Description of problem:
The nodectl depending informations should be hidden if nodectl is not available.
This is i.e. the case on plain CentOS hosts.

Comment 1 Ryan Barry 2016-09-30 13:58:32 UTC
This leaves the dashboard relatively rare.

Unless I've missed something, the goal on non-Node hosts is to not use the "dashboard" page at all, but to present only "Hosted Engine" and "Virtual Machines".

*** This bug has been marked as a duplicate of bug 1346835 ***

Comment 2 Ryan Barry 2016-09-30 16:00:11 UTC
It seems that we'll ship the dashboard on RHEL-H, so re-opening this.

Comment 3 Fabian Deutsch 2016-10-01 19:08:32 UTC
*** Bug 1378412 has been marked as a duplicate of this bug. ***

Comment 7 Wei Wang 2017-01-18 09:49:02 UTC
According to comments #4,#5,#6, change the status to VERIFIED.

Comment 8 Ying Cui 2017-01-23 06:05:51 UTC
I have to reopen this bug, tested failed on cockpit-ovirt-dashboard-0.10.7-0.0.3.el7ev.noarch on RHEL 7.3 host.

Steps to Reproduce:
1. Installed the cockpit-ovirt-dashboard plugin in regular hosts(RHEL 7.3)
2. Accessed cockpit UI by _root_ account.
3. Navigated to Virtualization Dashboard in Cockpit UI.
4. Checking Node Status UI.

Actual results:
1. Node status is always with spinner icon, and display "Can't check node status! Please run as an administrator!"

Expected results:
ovirt-node-ng-nodectl is for RHVH only, so here should not show Node status in cockpit-ovirt-dashbaord in regular hosts.

Comment 9 Red Hat Bugzilla Rules Engine 2017-01-23 06:05:58 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 10 Ying Cui 2017-01-23 06:06:36 UTC
Created attachment 1243513 [details]
screenshot_cockpit-ovirt-dashboard

Comment 11 Ying Cui 2017-01-23 06:07:50 UTC
*** Bug 1415562 has been marked as a duplicate of this bug. ***

Comment 12 Ryan Barry 2017-01-23 06:43:44 UTC
This was merged upstream and needs a new build to include it.

This also cannot be a regression, since the appropriate patch missed cherry picking to ovirt-4.1, and was only present in master until Jan 12th.

Comment 13 Ying Cui 2017-01-24 10:39:40 UTC
(In reply to Ryan Barry from comment #12)
> This was merged upstream and needs a new build to include it.
> 
> This also cannot be a regression, since the appropriate patch missed cherry
> picking to ovirt-4.1, and was only present in master until Jan 12th.

Confirmed with team for comment #4 #5 #6, then it is not regression, team missed checking the dashboard UI in regular host.

Comment 14 Wei Wang 2017-02-06 08:16:34 UTC
Test Version
fedora-release-server-24-1.noarch
kernel-4.5.5-300.fc24.x86_64
cockpit-0.103-1.fc24.x86_64
cockpit-ovirt-dashboard-0.10.7-0.0.6.fc24.noarch
vdsm-4.19.4-1.fc24.x86_64

Test Steps:
1. Clean install Fedora24
2. dnf install http://resources.ovirt.org/pub/yum-repo/ovirt-release41-pre.rpm
3. dnf install cockpit-ovirt-dashboard.noarch
4. Login cockpit webUI with root account
5. Go to "Virtualization", check "Dashboard" page


Result:
The "Dashboard" page exists. According to comment #1, the bug can be reproduced, change status to ASSIGNED

Comment 15 Red Hat Bugzilla Rules Engine 2017-02-06 08:16:41 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 16 Wei Wang 2017-02-06 09:35:11 UTC
Ryan,
According to comment #1, the solution is to disable "Dashboard" page for the regular host with cockpit-ovirt plugin. But from patch, the solution only make nodectl disabled. Could you please tell us which one is the right one?

Comment 17 Ryan Barry 2017-02-06 13:15:12 UTC
See comment#2.

We are actually shipping a dashboard page, just without any of the node functionality on it (so there should only be links back to "Networking", "Storage", and other base cockpit pages).

Comment 18 Wei Wang 2017-02-07 06:16:59 UTC
For Fedora24 server, the bug cannot be reproduced.
Version
fedora-release-server-24-1.noarch
kernel-4.5.5-300.fc24.x86_64
cockpit-0.103-1.fc24.x86_64
cockpit-ovirt-dashboard-0.10.7-0.0.6.fc24.noarch
vdsm-4.19.4-1.fc24.x86_64


Steps:
1. Clean install Fedora24
2. dnf install http://resources.ovirt.org/pub/yum-repo/ovirt-release41-pre.rpm
3. dnf install cockpit-ovirt-dashboard.noarch
4. Login cockpit webUI with root account
5. Go to "Virtualization"-->"Dashboard", check node status is disabled
6. Check nodectl in console
   #nodectl -h

Results:
The nodectl depending informations are hidden.
   # nodectl -h
   -bash: nodectl: command not found


For Centos7.3 server, the bug cannot be reproduced.
Version
centos-release-7-3.1611.el7.centos.x86_64
kernel-3.10.0-514.el7.x86_64
cockpit-126-1.el7.centos.x86_64
cockpit-ovirt-dashboard-0.10.7-0.0.6.el7.centos.noarch
vdsm-4.19.4-1.el7.centos.x86_64

Steps:
1. Clean install Centos73
2. yum install http://resources.ovirt.org/pub/yum-repo/ovirt-release41-pre.rpm
3. yum install cockpit
4. yum install cockpit-ovirt-dashboard.noarch
6. Config firewall with cockpit
7. Login cockpit webUI with root account
8. Go to "Virtualization"-->"Dashboard", check node status is disabled
9. Check nodectl in console
   #nodectl -h

Results:
The nodectl depending informations are hidden.
   # nodectl -h
   -bash: nodectl: command not found


For RHEL7.3 server, the bug cannot be reproduced.
Version:
redhat-release-server-7.3-7.el7.x86_64
kernel-3.10.0-514.el7.x86_64
cockpit-126-1.el7.x86_64
cockpit-ovirt-dashboard-0.10.7-0.0.6.el7ev.noarch
vdsm-4.19.4-1.el7ev.x86_64

Steps:
1. Clean install RHEL7.3
2. yum install http://bob.eng.lab.tlv.redhat.com/builds/latest_4.1/rhv-release-latest-4.1.noarch.rpm
3. yum install cockpit
4. yum install cockpit-ovirt-dashboard
5. Login cockpit webUI with root account
6. Go to "Virtualization"-->"Dashboard", check node status is disabled
7. Check nodectl in console
   #nodectl -h

Results:
The nodectl depending informations are hidden.
   # nodectl -h
   -bash: nodectl: command not found



The bug is verified with Fedora24/Centos7.3/RHEL7.3 host. Change status to VERIFIED.


Note You need to log in before you can comment on or make changes to this bug.