Bug 1381223 - Retire ovirt-image-uploader
Summary: Retire ovirt-image-uploader
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-image-uploader
Classification: oVirt
Component: Documentation
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.3.0
: ---
Assignee: Sandro Bonazzola
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On: 1049604
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-03 13:06 UTC by Sandro Bonazzola
Modified: 2019-02-13 07:48 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Deprecated Functionality
Doc Text:
With this update, ovirt-image-uploader has been retired. In Red Hat Virtualization 4.0 ovirt-image-uploader was deprecated in favor of ovirt-imageio.
Clone Of:
Environment:
Last Closed: 2019-02-13 07:48:11 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.3+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github oVirt ovirt-site pull 564 0 'None' closed subprojects: add deprecated section 2021-01-27 23:58:53 UTC
oVirt gerrit 65837 0 'None' MERGED packaging: drop references to ovirt-image-uploader 2021-01-27 23:58:09 UTC
oVirt gerrit 88061 0 'None' MERGED ovirt-image-uploader: drop master jobs 2021-01-27 23:58:09 UTC

Description Sandro Bonazzola 2016-10-03 13:06:45 UTC
Description of problem:
In 4.0 we deprecated ovirt-image-uplaoder in favor of ovirt-imageio.
In 4.1 we're going to retire ovirt-image-uploader.

Comment 1 Yaniv Kaul 2016-10-03 21:01:41 UTC
Can't it be converted to use the image upload API?

Comment 2 Sandro Bonazzola 2016-10-04 06:31:56 UTC
(In reply to Yaniv Kaul from comment #1)
> Can't it be converted to use the image upload API?

It probably can, but what was the point of deprecating it in 4.0 if we want just to convert it instead of dropping it?

Comment 3 Yaniv Kaul 2016-10-04 06:43:09 UTC
(In reply to Sandro Bonazzola from comment #2)
> (In reply to Yaniv Kaul from comment #1)
> > Can't it be converted to use the image upload API?
> 
> It probably can, but what was the point of deprecating it in 4.0 if we want
> just to convert it instead of dropping it?

I don't know why we need to deprecate it. It's a tool customers are familiar with. We may need to switch to the new mechanism for upload, but I personally not sure what other tool is available from the CLI to upload.

Comment 4 Yaniv Lavi 2016-10-27 08:44:39 UTC
(In reply to Yaniv Kaul from comment #3)
> (In reply to Sandro Bonazzola from comment #2)
> > (In reply to Yaniv Kaul from comment #1)
> > > Can't it be converted to use the image upload API?
> > 
> > It probably can, but what was the point of deprecating it in 4.0 if we want
> > just to convert it instead of dropping it?
> 
> I don't know why we need to deprecate it. It's a tool customers are familiar
> with. We may need to switch to the new mechanism for upload, but I
> personally not sure what other tool is available from the CLI to upload.

I believe this should be used either from the SDKs or the API, which we will be adding in 4.1.

Comment 5 Gonza 2016-11-18 08:46:59 UTC
How does imageio cover the additional image-uploader features? 
like:
--mac-address: this tool will remove any network interface cards from the image to prevent conflicts with NICs on other VMs

--disk-instance-id: This ensures that there are no conflicts between the disks on the imported image and those within oVirt engine.

--ignore-lsc: Ignore free space errors on local  /tmp filesystem, useful with sparse files (default=off)

--force: replace like named files on the target file server

Comment 6 Yaniv Lavi 2016-11-20 12:57:39 UTC
(In reply to Gonza from comment #5)
> How does imageio cover the additional image-uploader features? 
> like:
> --mac-address: this tool will remove any network interface cards from the
> image to prevent conflicts with NICs on other VMs
> 
> --disk-instance-id: This ensures that there are no conflicts between the
> disks on the imported image and those within oVirt engine.
> 
> --ignore-lsc: Ignore free space errors on local  /tmp filesystem, useful
> with sparse files (default=off)
> 
> --force: replace like named files on the target file server

All of these options are already covered by the engine validations.

Comment 7 Gonza 2016-12-07 14:41:08 UTC
Verified with:
ovirt-engine-4.1.0-0.2.master.20161205151239.git8f91a7d.el7.centos.noarch

Comment 8 Sandro Bonazzola 2017-01-12 16:47:26 UTC
It has been decided to unretir ovirt-image-uploader since ovirt-imageio is not able to handle OVAs and this will break several flows.
Postponing to 4.2.

Comment 9 Sandro Bonazzola 2017-04-11 09:05:11 UTC
Yaniv, can you open a bz on imageio with what's missing from ovirt-image-uploader and block this bug on it?

Comment 10 Yaniv Kaul 2017-11-29 10:36:19 UTC
What's the status of this BZ?

Comment 11 Sandro Bonazzola 2017-11-29 16:20:33 UTC
(In reply to Yaniv Kaul from comment #10)
> What's the status of this BZ?

It was blocked waiting for 
Bug #1319758 - [RFE] Allow uploading a pre-existing VM image (OVA) into the environment
to be fixed providing a way to upload an OVA from the engine instead of using command line.
But now I read in https://bugzilla.redhat.com/show_bug.cgi?id=1319758#c4 that the engine won't be able to upload an ova, but just able to generate one and download it.

So the blocking bug is now bug #1049604 which should be the upload one which is still on POST and still targeted 4.2.0.
So, I'm keeping this in NEW targeted to 4.2.0 and will eventually not release ovirt-image-uploader in 4.2.0 GA if 1049604 will be fixed before GA.
Otherwise, I'll re-target this to 4.3.0 since once released I'm not going to drop the package in zstream.

Comment 12 Sandro Bonazzola 2018-02-22 07:47:39 UTC
Bug #1049604 is ON_QA in 4.2.1 so it's now possible to upload an ova using the web UI. I can now proceed removing ovirt-image-uploader from master.

Comment 13 zhao 2018-03-28 09:31:40 UTC
In ovirt4.2, the ticket of uploadimage has a validity time of one hour. then when you click the recovery button, it will not apply for a new ticket, resulting in failure to recover and complete.But in ovirt4.1,the opertion has no problem,and why??

Comment 14 Sandro Bonazzola 2018-03-28 09:43:22 UTC
(In reply to zhao from comment #13)
> In ovirt4.2, the ticket of uploadimage has a validity time of one hour. then
> when you click the recovery button, it will not apply for a new ticket,
> resulting in failure to recover and complete.But in ovirt4.1,the opertion
> has no problem,and why??

Please open a bug on ovirt-imageio product: https://bugzilla.redhat.com/enter_bug.cgi?product=ovirt-imageio
Thanks.

Comment 15 Jiri Belka 2018-08-30 07:26:55 UTC
ok, ovirt-engine-4.3.0-0.0.master.20180828114844.git0bc18b1.el7.noarch

# yum repolist -v | egrep -i 'baseurl.*ovirt'
Repo-baseurl : http://cbs.centos.org/repos/virt7-ovirt-common-testing/x86_64/os/
Repo-baseurl : http://cbs.centos.org/repos/virt7-ovirt-43-testing/x86_64/os/
Repo-baseurl : http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7Server/
Repo-baseurl : http://resources.ovirt.org/pub/ovirt-master-snapshot-static/rpm/el7Server/
Repo-baseurl : https://copr-be.cloud.fedoraproject.org/results/ovirtwebui/ovirt-web-ui/epel-7-x86_64/

# yum search ovirt-image-uploader
Loaded plugins: product-id, search-disabled-repos, versionlock
Warning: No matches found for: ovirt-image-uploader
No matches found

Comment 17 Sandro Bonazzola 2018-11-02 14:36:50 UTC
This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 18 Sandro Bonazzola 2018-11-02 14:47:21 UTC
Closed by mistake, moving back to qa -> verified

Comment 19 Sandro Bonazzola 2019-02-13 07:48:11 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.