I've noticed this multiple times over the last few weeks on my F24 laptop, with all current updates each time it's happened. I do this quite often: suspend the laptop (by closing the lid) while it's on AC power, then unplug it - with the lid still closed - take it somewhere else, and open the lid to resume it. When I do that, consistently, the wifi connection does not come back up. I have to close the lid again, wait for the system to suspend (which takes longer than usual, at this point), then open the lid once more to bring the wifi connection up. I'll attach logs covering the whole sequence.
Created attachment 1208057 [details] journal extract covering the whole sequence This journal extract runs from the initial suspend (with the system on AC), through the resume on battery where wifi doesn't appear, suspending again on battery, and resuming again on battery, up until the connection comes up properly after the second resume.
any chance to gather a debug-logfile of NetworkManager? configure /etc/NetworkManager/NetworkManager.conf with [logging] level=TRACE restart NM, and reproduce.
sorry I didn't get the info for this yet, it's on my todo list. It's actually not quite as deterministic as the original report says, but does happen frequently.
Created attachment 1221132 [details] [PATCH] manager: fix state transition on resuming from sleep I think I found the issue and the attached patch should solve it.
lgtm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16474353
Sounds very plausible - I'll try it out. Thanks! This may also be the reason why sometimes my desktop loses its DNS config shortly after resuming, too?
(In reply to Adam Williamson from comment #8) > Sounds very plausible - I'll try it out. Thanks! This may also be the reason > why sometimes my desktop loses its DNS config shortly after resuming, too? It's hard to say without further information. Do you have configured dns=dnsmasq in NM.conf? If so, maybe it's related to bug 1373485. If not, does resolv.conf have the right name servers? Debug logs would be very helpful to understand the issue. But I tend to think the DNS issue is not related to this one.
Yeah, I'm using dnsmasq, but it's not quite the same symptom: the connection works for some seconds after resume, then suddenly stops resolving names, and /etc/resolv.conf is *empty*. I'll file a new bug for that if it doesn't go away.
I've since upgraded the affected system to F25, so I did my own scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16478583 I've installed that and I'll keep an eye out to see if the bug goes away.
I tried a few suspend/resume cycles and it didn't happen, so looking good, but I'll keep an eye on it for a few days.
(In reply to Adam Williamson from comment #12) > I tried a few suspend/resume cycles and it didn't happen, so looking good, > but I'll keep an eye on it for a few days. Hi, did the issue happen again?
Nope. And I got a new laptop in the mean time, and it seemed to have the same problem, but I loaded the scratch build onto *that* laptop and it seems OK too. So I think you nailed it. Thanks a lot for the fix! Let's do official builds :)
just to update i installed the scratch f24 build on my laptop which had the same issue.
(In reply to Adam Williamson from comment #14) > Nope. And I got a new laptop in the mean time, and it seemed to have the > same problem, but I loaded the scratch build onto *that* laptop and it seems > OK too. So I think you nailed it. Thanks a lot for the fix! Let's do > official builds :) Thanks for testing. Patch applied to master branch: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=5f1e36e02612a565d653c2cd76e1f37fb8c9af8e and nm-1-4: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?h=nm-1-4&id=ad4d3ba008e74f46f18905eb4c28295bf436bc3b
nm-1-2: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?h=nm-1-2&id=b749f7d31b7e5f57f18026a14b6a444e59a488cf
another update: this stopped happening after i applied the scratch build. last night i upgraded to fedora 25 and hit it again. I can take the one by Alex as a stopgap, but i hope this gets merged soon.
it's merged upstream, but not built downstream yet. I'm re-running my f25 scratch build, for anyone who needs it, since the previous one has had its output deleted, I think. Here's the new one: https://koji.fedoraproject.org/koji/taskinfo?taskID=16953199
Ah, in fact, I see a 1.4.4-2.fc25 build in Koji now which probably has the fix: https://koji.fedoraproject.org/koji/buildinfo?buildID=826019
I'm traveling and in my current location this happens every other suspend... would be good to have it pushed formally. I doubt everyone track this bug for the koji build... Thanks.
regarding F25, this is fixed with NetworkManager-1.4.4-2.fc25.
NetworkManager-1.2.6-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-78a478cd32
NetworkManager-1.2.6-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-78a478cd32
NetworkManager-1.2.6-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.