Bug 1383220 - [UI] - Not possible to create new disks for existing VMs in UI
Summary: [UI] - Not possible to create new disks for existing VMs in UI
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.1.0
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ovirt-4.1.0-alpha
: 4.1.0.2
Assignee: Tal Nisan
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-10 08:45 UTC by Michael Burman
Modified: 2017-02-01 14:38 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:38:52 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: blocker+
rule-engine: planning_ack+
tnisan: devel_ack+
ratamir: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 65296 0 master MERGED webadmin: Fix disk creation in webadmin 2016-10-10 11:23:22 UTC
oVirt gerrit 65714 0 master MERGED webadmin: Restore SAN storage device size column header in new disk popup 2016-10-25 14:51:32 UTC

Description Michael Burman 2016-10-10 08:45:07 UTC
Description of problem:
[UI] - Not possible to create new disks for existing VMs in UI at all.

Not via the 'Disks' main tab and not via the 'Disks' sub tab under 'Virtual Machines' main tab in the ovirt UI.

2016-10-10 11:42:37,749 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-13) [] Permutation name: 19945154F5A7C5DF9D8ECB57C9BC2792
2016-10-10 11:42:37,749 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-13) [] Uncaught exception: com.google.gwt.event.shared.UmbrellaException: Exception caught: (Error) 
 __gwt$exception: <skipped>: Syntax error, unrecognized expression: Dev. Size
        at java.lang.Throwable.fillInStackTrace(Throwable.java:114) [rt.jar:1.8.0_102]
        at java.lang.RuntimeException.RuntimeException(RuntimeException.java:32) [rt.jar:1.8.0_102]
        at com.google.web.bindery.event.shared.UmbrellaException.UmbrellaException(UmbrellaException.java:70) [gwt-servlet.jar:]
        at com.google.gwt.event.shared.UmbrellaException.UmbrellaException(UmbrellaException.java:25) [gwt-servlet.jar:]
        at com.google.gwt.event.shared.HandlerManager.$fireEvent(HandlerManager.java:117) [gwt-servlet.jar:]
        at com.google.gwt.user.client.ui.Widget.$fireEvent(Widget.java:127) [gwt-servlet.jar:]
        at com.google.gwt.user.client.ui.Widget.fireEvent(Widget.java:127) [gwt-servlet.jar:]
        at com.google.gwt.event.dom.client.DomEvent.fireNativeEvent(DomEvent.java:110) [gwt-servlet.jar:]
        at com.google.gwt.user.client.ui.Widget.$onBrowserEvent(Widget.java:163) [gwt-servlet.jar:]
        at com.google.gwt.user.client.ui.CustomButton.onBrowserEvent(CustomButton.java:631) [gwt-servlet.jar:]
        at com.google.gwt.user.client.ui.Composite.onBrowserEvent(Composite.java:78) [gwt-servlet.jar:]
        at com.google.gwt.user.client.DOM.dispatchEvent(DOM.java:1648) [gwt-servlet.jar:]
        at com.google.gwt.user.client.impl.DOMImplStandard.dispatchEvent(DOMImplStandard.java:320) [gwt-servlet.jar:]
        at com.google.gwt.core.client.impl.Impl.apply(Impl.java:296) [gwt-servlet.jar:]
        at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:335) [gwt-servlet.jar:]
        at Unknown.eval(webadmin-0.js@54)
        at com.google.gwt.dom.client.DOMImplStandard.$dispatchEvent(DOMImplStandard.java:68) [gwt-servlet.jar:]
        at com.google.gwt.user.client.ui.CustomButton.$onClick(CustomButton.java:822) [gwt-servlet.jar:]
        at com.google.gwt.user.client.ui.ToggleButton.onClick(ToggleButton.java:255) [gwt-servlet.jar:]
        at com.google.gwt.user.client.ui.CustomButton.onBrowserEvent(CustomButton.java:631) [gwt-servlet.jar:]
        at com.google.gwt.user.client.ui.Composite.onBrowserEvent(Composite.java:78) [gwt-servlet.jar:]
        at com.google.gwt.user.client.DOM.dispatchEvent(DOM.java:1648) [gwt-servlet.jar:]
        at com.google.gwt.user.client.DOM.dispatchEvent(DOM.java:1666) [gwt-servlet.jar:]
        at com.google.gwt.user.client.impl.DOMImplStandard.dispatchCapturedMouseEvent(DOMImplStandard.java:352) [gwt-servlet.jar:]
        at com.google.gwt.core.client.impl.Impl.apply(Impl.java:296) [gwt-servlet.jar:]
        at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:335) [gwt-servlet.jar:]
        at Unknown.eval(webadmin-0.js@54)
Caused by: com.google.gwt.core.client.JavaScriptException: (Error) 
 __gwt$exception: <skipped>: Syntax error, unrecognized expression: Dev. Size
        at Unknown.ga.error(https://mburman-4-test-rpms.scl.lab.tlv.redhat.com/ovirt-engine/webadmin/theme/00-ovirt.brand/jquery-1.11.3.min.js@12731)
        at Unknown.tokenize(https://mburman-4-test-rpms.scl.lab.tlv.redhat.com/ovirt-engine/webadmin/theme/00-ovirt.brand/jquery-1.11.3.min.js@18658)
        at Unknown.select(https://mburman-4-test-rpms.scl.lab.tlv.redhat.com/ovirt-engine/webadmin/theme/00-ovirt.brand/jquery-1.11.3.min.js@21386)
        at Unknown.ga(https://mburman-4-test-rpms.scl.lab.tlv.redhat.com/ovirt-engine/webadmin/theme/00-ovirt.brand/jquery-1.11.3.min.js@7364)
        at Unknown.fn.extend.find(https://mburman-4-test-rpms.scl.lab.tlv.redhat.com/ovirt-engine/webadmin/theme/00-ovirt.brand/jquery-1.11.3.min.js@23660)
        at Unknown.fn.init(https://mburman-4-test-rpms.scl.lab.tlv.redhat.com/ovirt-engine/webadmin/theme/00-ovirt.brand/jquery-1.11.3.min.js@24231)
        at Unknown.m(https://mburman-4-test-rpms.scl.lab.tlv.redhat.com/ovirt-engine/webadmin/theme/00-ovirt.brand/jquery-1.11.3.min.js@393)
        at org.ovirt.engine.ui.common.utils.JqueryUtils.getTextFromHtml(JqueryUtils.java:41)
        at org.ovirt.engine.ui.common.widget.table.ColumnResizeCellTable.$getColumnContextMenuTitle(ColumnResizeCellTable.java:413)
        at org.ovirt.engine.ui.common.widget.table.ColumnContextMenuItem.$update(ColumnContextMenuItem.java:75)


Version-Release number of selected component (if applicable):
4.1.0-0.0.master.20161009231313.git5985891.el7.centos

How reproducible:
100

Steps to Reproduce:
1. Create new VM without disk
2. Try to create and add new disk via the 'Disks' main tab
3. Try to add new disk to the VM via the 'Disks' sub tab under the 'Virtual Machines' main tab.

Actual results:
Nothing happens and ui exception in displayed in fronted UI

Expected results:
Should work as expected.

Additional info:
See also - https://bugzilla.redhat.com/show_bug.cgi?id=1382357 which is covering the scenario of creating a disk from within the VM dialog

Comment 1 Tal Nisan 2016-10-10 08:48:44 UTC
Additional info is not correct, this is a completely different bug, the scenario in bug 1382357 is fixed, new issue affects all disks creation through the UI

Comment 2 Tal Nisan 2016-10-10 10:54:31 UTC
This bug was caused by change 7f3a3e704 which made it impossible to open the new/edit disk dialog.
Most likely due to unescaping of the dot ('.') character but I leave it for the UX guys to investigate further.
I didn't want to revert their work so this is a temporary fix that removes the dot and solves the issue, the change still needs to be fixed permanently and the column header should be return to its original form.

Comment 3 Vojtech Szocs 2016-10-10 19:51:42 UTC
> at org.ovirt.engine.ui.common.utils.JqueryUtils.getTextFromHtml(JqueryUtils.java:41)
> at org.ovirt.engine.ui.common.widget.table.ColumnResizeCellTable.$getColumnContextMenuTitle(ColumnResizeCellTable.java:413)

jQuery related, I'll have a look.

Comment 4 Vojtech Szocs 2016-10-24 15:49:18 UTC
UI infra fix tracked by bug 1386765

Comment 5 Allon Mureinik 2016-11-01 12:58:22 UTC
Tal - shouldn't this be on MODIFIED?

Comment 6 Tal Nisan 2016-11-01 15:01:08 UTC
Yes, the revert of the workaround patch moved it back to POST

Comment 7 Raz Tamir 2016-11-27 13:56:47 UTC
Verified on -  
ovirt-engine-4.1.0-0.0.master.20161126211319.gitae69c34.el7.centos.noarch

Comment 8 Sandro Bonazzola 2016-12-12 13:57:48 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 9 Raz Tamir 2016-12-13 17:44:42 UTC
Verified on Verified on 4.1.0-0.2.master.20161212071212.git8a015dd.el7.centos

Comment 10 Red Hat Bugzilla Rules Engine 2016-12-27 16:39:42 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.


Note You need to log in before you can comment on or make changes to this bug.