Description of problem: max file size supported by trashcan feature is hardcoded to 1GB. For admins who manage volumes where only larger files are stored, this heavily erodes the value of the trashcan feature. it would be nice to either not have this limit, or have an override option. Version-Release number of selected component (if applicable): all versions with trashcan I believe. I am using 3.8 myself. How reproducible: trivial, it was a feature, not a bug. Steps to Reproduce: 1. enable trashcan 2. increase limit to something above 1GB 3. delete a large file (larger than 1GB) Actual results: large file deleted permanently, bypassing trashcan Desired (by me at least!) results: large file goes to trashcan Additional info:
REVIEW: http://review.gluster.org/15689 (xlators/trash : Remove upper limit for trash max file size) posted (#1) for review on master by jiffin tony Thottan (jthottan)
COMMIT: http://review.gluster.org/15689 committed in master by Vijay Bellur (vbellur) ------ commit cd9be49f6fe05d424989c0686a7e55a3f3ead27e Author: Jiffin Tony Thottan <jthottan> Date: Fri Oct 21 00:08:26 2016 +0530 xlators/trash : Remove upper limit for trash max file size Currently file which size exceeds more than 1GB never moved to trash directory. This is due to the hard coded check using GF_ALLOWED_MAX_FILE_SIZE. Change-Id: I2ed707bfe1c3114818896bb27a9856b9a164be92 BUG: 1386766 Signed-off-by: Jiffin Tony Thottan <jthottan> Reviewed-on: http://review.gluster.org/15689 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Anoop C S <anoopcs> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Vijay Bellur <vbellur>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report. glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html [2] https://www.gluster.org/pipermail/gluster-users/
So this was released in 3.10, but the latest docs in 2020 are still referencing this 1GB limitation and say it's not something that can be overridden. > Considering the fact that trash directory is consuming the glusterfs volume space, trash feature is implemented to function in such a way that it directly deletes/truncates files with size > 1GB even if this option is set to some value greater than 1GB. Please update the docs.
I filed https://bugzilla.redhat.com/show_bug.cgi?id=1803984 but that project doesn't seem to be active, so I'm not sure anyone will see it.
(In reply to Artem Russakovskii from comment #4) > So this was released in 3.10, but the latest docs in 2020 are still > referencing this 1GB limitation and say it's not something that can be > overridden. > > > Considering the fact that trash directory is consuming the glusterfs volume space, trash feature is implemented to function in such a way that it directly deletes/truncates files with size > 1GB even if this option is set to some value greater than 1GB. > > Please update the docs. Thanks for reporting the required change. Raised PR https://github.com/gluster/glusterdocs/pull/540