+++ This bug was initially created as a clone of Bug #1386766 +++ Description of problem: max file size supported by trashcan feature is hardcoded to 1GB. For admins who manage volumes where only larger files are stored, this heavily erodes the value of the trashcan feature. it would be nice to either not have this limit, or have an override option. Version-Release number of selected component (if applicable): all versions with trashcan I believe. I am using 3.8 myself. How reproducible: trivial, it was a feature, not a bug. Steps to Reproduce: 1. enable trashcan 2. increase limit to something above 1GB 3. delete a large file (larger than 1GB) Actual results: large file deleted permanently, bypassing trashcan Desired (by me at least!) results: large file goes to trashcan Additional info: --- Additional comment from Worker Ant on 2016-10-21 00:13:57 IST --- REVIEW: http://review.gluster.org/15689 (xlators/trash : Remove upper limit for trash max file size) posted (#1) for review on master by jiffin tony Thottan (jthottan) --- Additional comment from Worker Ant on 2016-11-03 19:39:47 IST --- COMMIT: http://review.gluster.org/15689 committed in master by Vijay Bellur (vbellur) ------ commit cd9be49f6fe05d424989c0686a7e55a3f3ead27e Author: Jiffin Tony Thottan <jthottan> Date: Fri Oct 21 00:08:26 2016 +0530 xlators/trash : Remove upper limit for trash max file size Currently file which size exceeds more than 1GB never moved to trash directory. This is due to the hard coded check using GF_ALLOWED_MAX_FILE_SIZE. Change-Id: I2ed707bfe1c3114818896bb27a9856b9a164be92 BUG: 1386766 Signed-off-by: Jiffin Tony Thottan <jthottan> Reviewed-on: http://review.gluster.org/15689 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Anoop C S <anoopcs> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/15784 (xlators/trash : Remove upper limit for trash max file size) posted (#1) for review on release-3.9 by jiffin tony Thottan (jthottan)
This bug is getting closed because GlusterFS-3.9 has reached its end-of-life [1]. Note: This bug is being closed using a script. No verification has been performed to check if it still exists on newer releases of GlusterFS. If this bug still exists in newer GlusterFS releases, please open a new bug against the newer release. [1]: https://www.gluster.org/community/release-schedule/