Description of problem: When creating new VM, it should be possible to set custom number of VM. Now when setting different count of cpu, that column is marked as bad value when confirming the dialog Version-Release number of selected component (if applicable): 4.0.5-5 ovirt-engine-webadmin-portal-4.0.5.4-0.1.el7ev.noarch How reproducible: always - you must add disk before (without adding disk, it works) Steps to Reproduce: 1. install clean environment 2. add host and storage domain 3. add VM with disk! and with more than 1 virtual CPU Actual results: - Column is marked red -> user can't modify count of virtual CPU - when VM is already created, edit VM and modify count of virtual CPU works Expected results: should work when creating VM Additional info: -
This is a regression caused by https://gerrit.ovirt.org/#/c/63708/ The problem is that when you open the "create disk" dialog from the "create vm" dialog, the "create vm" dialog will get cleared up. Than, when the "create disk" dialog is closed, the "create vm" dialog is not properly inited again (especially the model listeners". The consequence is that big part of the dialog, including the CPU count will stop working. I think that all places where a dialog is opened from other dialog and than moved back can cause this issue. For example the new quota dialog looks strange after pressing "edit" on the quota (e.g. the button is grey but clickable). For some reason it seems to be working on configure->and any window opened there. Not sure how the wizard of "new dc, new cluster" will work. Moving to UX for further investigation.
Tomas, many thanks for clearing up the situation. I've posted a patch that defers cleanup of all dialog related resources to the point where there are no active (visible) dialogs left. This should cover the "dialog triggered by another dialog" scenario as described in comment #1.
still can't change count of CPU in ovirt-engine-4.1.0-0.0.master.20161121231311.git19a0953.el7.centos.noarch Steps to Reproduce: 1. click on 'New VM', enter name 2. click on 'Create' in section Instance Images, enter disk size, click 'OK' 3. go to System, change value in Total Virtual CPUs VM can't be created until the number of CPU is back to value before disk creation and error 'Incorrect number of Total Virtual CPUs....' is shown on the input
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
After talking offline with UX and Virt guys, we come up with the following analysis (I'm quoting Vojtech): " The problem seems to be VM dialog being closed [*] before the Disk dialog is shown. [*] at this point, active dialog count == 0 -> perform dialog cleanup If a dialog is closed && active dialog count == 0, there is no way for UI infra to know if [some] dialog models are still needed. I'd suggest to modify existing code to either: 1, show Disk dialog on top of VM dialog (prevent 0 active dialog count scenario that triggers dialog model cleanup) 2, exclude VM dialog resources from cleanup (results in memory leaks) Again, as I wrote many times, dialogs are designed as *non*-singleton components, including the associated dialog Model. Referring to dialog model once the dialog is closed therefore contradicts existing design (which has existed since the very beginning). Our memory leak fixes basically uncovered cases where dialog models are (incorrectly) referenced *after* the given dialog is closed. The proper solution is to refactor code that goes against established design. Trying to solve this on UI infra level is neither optimal nor correct. " Therefor, moving this to Virt to implement one of the alternatives mentioned above. Let us know if you need assistance.
We'll need a minimal UI infra change to support triggering Disk dialog on top of VM dialog. The minimal UI infra change + VM dialog code fix should be merged & backported into 4.0. Afterwards, we can improve UI infra code (master only).
*** Bug 1400706 has been marked as a duplicate of this bug. ***
changing value of CPU with disk creation is OK verified in ovirt-engine-webadmin-portal-4.1.0-0.2.master.20161205231208.gitf0af92b.el7.centos.noarch and ovirt-engine-webadmin-portal-4.0.6.2-0.1.el7ev.noarch