Bug 1392049 - Add desktop entry for IDLE 3
Summary: Add desktop entry for IDLE 3
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python3
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Charalampos Stratakis
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1418469 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-04 16:17 UTC by Yaakov Selkowitz
Modified: 2017-02-28 20:58 UTC (History)
12 users (show)

Fixed In Version: python3-3.6.0-20.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-28 20:58:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch for rawhide (3.05 KB, patch)
2016-11-04 17:07 UTC, Yaakov Selkowitz
no flags Details | Diff
Add idle3 desktop entry (3.10 KB, patch)
2017-02-02 14:31 UTC, Charalampos Stratakis
no flags Details | Diff
Screenshot 1 (59.37 KB, image/png)
2017-02-21 16:12 UTC, Miro Hrončok
no flags Details
Screenshot 2 (81.78 KB, image/png)
2017-02-21 16:13 UTC, Miro Hrončok
no flags Details
Screenshot 3 (31.84 KB, image/png)
2017-02-21 16:13 UTC, Miro Hrončok
no flags Details
software center screenshot (106.69 KB, image/png)
2017-02-28 10:57 UTC, Charalampos Stratakis
no flags Details
software center screenshot2 (168.38 KB, image/png)
2017-02-28 10:57 UTC, Charalampos Stratakis
no flags Details
idle3 appdata.xml (1.68 KB, application/xml)
2017-02-28 10:59 UTC, Charalampos Stratakis
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Python 1353344 0 None None None 2017-02-02 15:01:38 UTC

Description Yaakov Selkowitz 2016-11-04 16:17:49 UTC
idle3 (from python3-tools) is a GUI application without an easy way to launch it from the desktop.  The following patch adds a desktop entry and icons.

Comment 1 Yaakov Selkowitz 2016-11-04 17:07:25 UTC
Created attachment 1217455 [details]
Patch for rawhide

Scratch build:  http://koji.fedoraproject.org/koji/taskinfo?taskID=16286224

Comment 2 William Moreno 2017-02-01 22:54:02 UTC
*** Bug 1418469 has been marked as a duplicate of this bug. ***

Comment 3 William Moreno 2017-02-01 22:54:44 UTC
cc

Comment 4 Zbigniew Jędrzejewski-Szmek 2017-02-02 14:17:28 UTC
It really needs an appdata file too [https://fedoraproject.org/wiki/Packaging:AppData].

Comment 5 Charalampos Stratakis 2017-02-02 14:31:17 UTC
Created attachment 1247135 [details]
Add idle3 desktop entry

My diff so far for rawhide

Comment 6 Petr Viktorin (pviktori) 2017-02-02 15:01:39 UTC
Upstream issue: https://bugs.python.org/issue1353344

Comment 7 Zbigniew Jędrzejewski-Szmek 2017-02-02 15:29:00 UTC
Oh, typical python development: 12+ years to add a freakin' desktop file.

Here's a draft of an appdata file, please take a look:
http://in.waw.pl/~zbyszek/fedora/idle3-appdata/idle3.appdata.xml

It passes appstream-util validate, and appstream-util validate-strict except for missing translations.

Comment 8 William Moreno 2017-02-02 15:50:57 UTC
The idle3 will be a sub package? There will be no sence to install a .dektop and icon file in a headless server

Comment 9 Zbigniew Jędrzejewski-Szmek 2017-02-02 16:03:29 UTC
A .desktop file and the icon could be on the order of 5kb together. Why do you think this makes a difference?

Comment 10 Charalampos Stratakis 2017-02-09 15:19:32 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> Oh, typical python development: 12+ years to add a freakin' desktop file.
> 
> Here's a draft of an appdata file, please take a look:
> http://in.waw.pl/~zbyszek/fedora/idle3-appdata/idle3.appdata.xml
> 
> It passes appstream-util validate, and appstream-util validate-strict except
> for missing translations.

Could you replace your 3.5.2 screenshots with the 3.6 equivalent ones?

Comment 11 Zbigniew Jędrzejewski-Szmek 2017-02-09 15:49:03 UTC
Redoing the screenshots is a bit of work, especially under wayland where single-window screenshots don't work ootb. I just checked, and the idle3 in 3.6 would look exactly the same in those three screenshots, except for the version number of course.

If you think the version number is an issue, I can just delete it from the screen shot. This way the screen shot wouldn't feel out of date so quickly.

Comment 12 Miro Hrončok 2017-02-21 16:12:50 UTC
Created attachment 1256190 [details]
Screenshot 1

Comment 13 Miro Hrončok 2017-02-21 16:13:11 UTC
Created attachment 1256191 [details]
Screenshot 2

Comment 14 Miro Hrončok 2017-02-21 16:13:41 UTC
Created attachment 1256192 [details]
Screenshot 3

Added some 3.6.0 screenshots

Comment 15 Charalampos Stratakis 2017-02-23 15:03:51 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #11)
> Redoing the screenshots is a bit of work, especially under wayland where
> single-window screenshots don't work ootb. I just checked, and the idle3 in
> 3.6 would look exactly the same in those three screenshots, except for the
> version number of course.
> 
> If you think the version number is an issue, I can just delete it from the
> screen shot. This way the screen shot wouldn't feel out of date so quickly.

Could you replace the images with the one that Miro provided?

Also I guess the translation tag can be removed as according to [0] only the 
'appstream-util validate-relax <file>' has to pass, which doesn't require the translation tag to be present.

[0] https://fedoraproject.org/wiki/Packaging:AppData

Comment 16 Zbigniew Jędrzejewski-Szmek 2017-02-23 16:45:08 UTC
(In reply to Miro Hrončok from comment #14)
> Added some 3.6.0 screenshots
Thanks, updated.

(In reply to Charalampos Stratakis from comment #15)
> Also I guess the translation tag can be removed
Removed.

Those screenshots are on my server. That's not an issue in the short run, because it's not going anywhere, but from upstream POV, it would probably be better to move them somewhere underneath https://docs.python.org/3/library. It might even make sense to add one of the screeshots (probably the "main window" one) to idle.html. A bit of color is always nice. If all three files were included in the doc tree, they could be linked there.

Comment 17 Charalampos Stratakis 2017-02-23 18:59:38 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #16)
> (In reply to Miro Hrončok from comment #14)
> > Added some 3.6.0 screenshots
> Thanks, updated.
> 
> (In reply to Charalampos Stratakis from comment #15)
> > Also I guess the translation tag can be removed
> Removed.
> 
> Those screenshots are on my server. That's not an issue in the short run,
> because it's not going anywhere, but from upstream POV, it would probably be
> better to move them somewhere underneath https://docs.python.org/3/library.
> It might even make sense to add one of the screeshots (probably the "main
> window" one) to idle.html. A bit of color is always nice. If all three files
> were included in the doc tree, they could be linked there.

We should definitely try to initiate some discussions upstream in regards to that.

For the time being though I will push these changes to our builds soon.

It seems your file still contains the translation tag, could you remove it?

Comment 18 Zbigniew Jędrzejewski-Szmek 2017-02-23 19:11:04 UTC
(In reply to Charalampos Stratakis from comment #17)
> We should definitely try to initiate some discussions upstream in regards to
> that.
> 
> For the time being though I will push these changes to our builds soon.
Sounds reasonable. It probably is even better to make sure it looks properly in gnome-software, etc.

> It seems your file still contains the translation tag, could you remove it?
I don't see it. Maybe you need to force refresh?

Comment 19 Charalampos Stratakis 2017-02-23 19:32:51 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #18)
> (In reply to Charalampos Stratakis from comment #17)
> > We should definitely try to initiate some discussions upstream in regards to
> > that.
> > 
> > For the time being though I will push these changes to our builds soon.
> Sounds reasonable. It probably is even better to make sure it looks properly
> in gnome-software, etc.
> 
> > It seems your file still contains the translation tag, could you remove it?
> I don't see it. Maybe you need to force refresh?

Yes you are right. Thanks for it.

Comment 20 Fedora End Of Life 2017-02-28 10:33:35 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 21 Charalampos Stratakis 2017-02-28 10:57:04 UTC
Created attachment 1258329 [details]
software center screenshot

Comment 22 Charalampos Stratakis 2017-02-28 10:57:42 UTC
Created attachment 1258330 [details]
software center screenshot2

Comment 23 Charalampos Stratakis 2017-02-28 10:59:16 UTC
Created attachment 1258331 [details]
idle3 appdata.xml

Modified a bit the appdata.xml. You can see at the above screenshots how it will look at gnome's software center.

Comment 24 Zbigniew Jędrzejewski-Szmek 2017-02-28 12:31:48 UTC
Looks nice. I think the text looks OK too.

Comment 25 Charalampos Stratakis 2017-02-28 20:58:51 UTC
Built in rawhide.


Note You need to log in before you can comment on or make changes to this bug.